Clear out unused compiler options when transpiling #9176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/services/services.ts
Outdated
| options.noLib = true; | ||
|
|
||
| // Clear out the lib and types option as well | ||
| // Clear out other settings that would not be participate in transpiling this module |
|
@mhegazy you will want to merge master in sicne we have change our unittests/transpile to use baselines instead |
|
@yuit can you take a look? |
|
@mhegazy sorry didn't realize my comment on Friday didn't show up. The change looks good. though I think we should pull transpile option test out as the file is growing |
|
i am not sure i see the need to split the file. they are all unit tests for the same API. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take-2 Fixes #9173.
Clear out more settings, and add tests for all the settings that were not covered before.