Skip to content

Fix global plugin search paths, fixes #62618 #62619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

Fix global plugin search paths, fixes #62618 #62619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/server/project.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2106,8 +2106,9 @@ export abstract class Project implements LanguageServiceHost, ModuleResolutionHo
// Search any globally-specified probe paths, then our peer node_modules
return [
...this.projectService.pluginProbeLocations,
// ../../.. to walk from X/node_modules/typescript/lib/tsserver.js to X/node_modules/
combinePaths(this.projectService.getExecutingFilePath(), "../../.."),
// ../../.. to walk from X/node_modules/typescript/lib/tsserver.js to X/
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment mentions '../../..' (3 updirs) but the code now uses '../../../..' (4 updirs). The comment should be updated to match the actual number of updirs used in the code below.

Suggested change
// ../../.. to walk from X/node_modules/typescript/lib/tsserver.js to X/
// ../../../.. to walk from X/node_modules/typescript/lib/tsserver.js to X/

Copilot uses AI. Check for mistakes.
// later we will append node_modules back on to resolve the plugin location
combinePaths(this.projectService.getExecutingFilePath(), "../../../.."),
];
}

Expand Down Expand Up @@ -3204,3 +3205,4 @@ export function isBackgroundProject(project: Project): project is AutoImportProv
export function isProjectDeferredClose(project: Project): project is ConfiguredProject {
return isConfiguredProject(project) && !!project.deferredClose;
}

Loading