Skip to content

Clear out checker-level stacks on pop #62016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2025
Merged

Clear out checker-level stacks on pop #62016

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ed5ca3
Clear out checker-level stacks on pop
jakebailey Jul 7, 2025
db04cbe
Use better incantation
jakebailey Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32741,6 +32741,10 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {

function popContextualType() {
contextualTypeCount--;
// Clear out the popped element's referenced objects.
contextualTypeNodes[contextualTypeCount] = undefined!;
contextualTypes[contextualTypeCount] = undefined;
contextualIsCache[contextualTypeCount] = undefined!;
}

function findContextualNode(node: Node, includeCaches: boolean) {
Expand All @@ -32760,6 +32764,8 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {

function popInferenceContext() {
inferenceContextCount--;
inferenceContextNodes[inferenceContextCount] = undefined!;
inferenceContexts[inferenceContextCount] = undefined;
}

function getInferenceContext(node: Node) {
Expand All @@ -32772,12 +32778,15 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {

function pushActiveMapper(mapper: TypeMapper) {
activeTypeMappers[activeTypeMappersCount] = mapper;
activeTypeMappersCaches[activeTypeMappersCount] = new Map();
activeTypeMappersCaches[activeTypeMappersCount] ??= new Map();
activeTypeMappersCount++;
}

function popActiveMapper() {
activeTypeMappersCount--;
// Clear out the popped element's referenced objects.
activeTypeMappers[activeTypeMappersCount] = undefined!;
activeTypeMappersCaches[activeTypeMappersCount].clear();
}

function findActiveMapper(mapper: TypeMapper) {
Expand Down