experiment: remove SymbolConstructor ESSymbol transform #61893

Renegade334 · 2025-06-18T16:06:14Z

jakebailey · 2025-06-18T18:37:12Z

typescript-bot · 2025-06-18T18:37:17Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	👀 Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-06-18T18:59:40Z

Hey @jakebailey, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: jquery
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/jquery/misc.d.ts
  7359:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'toStringTag' must be of type 'unique symbol', but here has type 'symbol'  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

You can check the log here.

typescript-bot · 2025-06-18T19:04:29Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/61893/merge:

Everything looks good!

typescript-bot · 2025-06-18T19:22:08Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,370	_62,370	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,386	_50,386	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{195,943k (± 0.73%)}	_{195,375k (± 0.94%)}	_~	_192,968k	_196,647k	_{p=0.810 n=6}
_{Parse Time}	_{1.62s (± 1.72%)}	_{1.60s (± 1.09%)}	_~	_1.58s	_1.63s	_{p=0.331 n=6}
_{Bind Time}	_{0.88s (± 1.67%)}	_{0.88s (± 0.58%)}	_~	_0.88s	_0.89s	_{p=0.784 n=6}
_{Check Time}	_{11.73s (± 0.58%)}	_{11.79s (± 0.58%)}	_~	_11.71s	_11.91s	_{p=0.229 n=6}
_{Emit Time}	_{3.32s (± 3.89%)}	_{3.29s (± 0.74%)}	_~	_3.26s	_3.32s	_{p=0.872 n=6}
_{Total Time}	_{17.56s (± 0.93%)}	_{17.57s (± 0.61%)}	_~	_17.48s	_17.77s	_{p=0.688 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅₆	₅₆	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,750	_948,706	_{-44 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_410,846	_410,886	_{+40 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,224,644k (± 0.00%)}	_{1,224,640k (± 0.01%)}	_~	_1,224,530k	_1,224,734k	_{p=0.936 n=6}
_{Parse Time}	_{6.58s (± 0.87%)}	_{6.60s (± 0.94%)}	_~	_6.54s	_6.69s	_{p=0.517 n=6}
_{Bind Time}	_{1.88s (± 0.93%)}	_{1.89s (± 0.56%)}	_~	_1.87s	_1.90s	_{p=0.869 n=6}
_{Check Time}	_{31.75s (± 0.36%)}	_{31.81s (± 0.20%)}	_~	_31.75s	_31.90s	_{p=0.230 n=6}
_{Emit Time}	_{14.91s (± 0.73%)}	_{14.87s (± 0.37%)}	_~	_14.81s	_14.95s	_{p=0.335 n=6}
_{Total Time}	_{55.11s (± 0.41%)}	_{55.17s (± 0.19%)}	_~	_55.01s	_55.32s	_{p=0.630 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,561,651	_2,561,651	_~	_~	_~	_{p=1.000 n=6}
_Types	_892,630	_892,630	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,836,536k (± 0.00%)}	_{2,836,524k (± 0.00%)}	_~	_2,836,468k	_2,836,559k	_{p=1.000 n=6}
_{Parse Time}	_{9.19s (± 0.35%)}	_{9.17s (± 0.27%)}	_~	_9.14s	_9.21s	_{p=0.417 n=6}
_{Bind Time}	_{2.31s (± 0.36%)}	_{2.30s (± 0.27%)}	_~	_2.29s	_2.31s	_{p=0.340 n=6}
_{Check Time}	_{83.66s (± 0.18%)}	_{83.68s (± 0.47%)}	_~	_83.09s	_84.28s	_{p=0.936 n=6}
_{Emit Time}	_{0.30s (± 1.37%)}	_0.30s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{95.45s (± 0.18%)}	_{95.45s (± 0.43%)}	_~	_94.84s	_96.09s	_{p=0.936 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,126	_1,227,126	_~	_~	_~	_{p=1.000 n=6}
_Types	_267,408	_267,407	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,973,547k (±10.04%)}	_{2,999,101k (± 7.83%)}	_~	_2,518,973k	_3,095,658k	_{p=0.298 n=6}
_{Parse Time}	_{6.64s (± 1.39%)}	_{6.63s (± 1.10%)}	_~	_6.53s	_6.74s	_{p=0.471 n=6}
_{Bind Time}	_{2.17s (± 0.79%)}	_{2.13s (± 1.75%)}	_{-0.04s (- 1.92%)}	_2.06s	_2.17s	_{p=0.019 n=6}
_{Check Time}	_{42.52s (± 0.21%)}	_{42.56s (± 0.55%)}	_~	_42.11s	_42.75s	_{p=0.298 n=6}
_{Emit Time}	_{3.39s (± 3.35%)}	_{3.42s (± 1.86%)}	_~	_3.31s	_3.49s	_{p=0.630 n=6}
_{Total Time}	_{54.74s (± 0.28%)}	_{54.75s (± 0.40%)}	_~	_54.31s	_54.90s	_{p=0.689 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,126	_1,227,126	_~	_~	_~	_{p=1.000 n=6}
_Types	_267,408	_267,407	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,428,975k (± 0.01%)}	_{2,549,995k (± 7.34%)}	_~	_2,428,680k	_2,792,055k	_{p=0.298 n=6}
_{Parse Time}	_{5.38s (± 1.21%)}	_{5.45s (± 1.36%)}	_{+0.08s (+ 1.46%)}	_5.37s	_5.56s	_{p=0.045 n=6}
_{Bind Time}	_{1.82s (± 1.86%)}	_{1.82s (± 1.33%)}	_~	_1.79s	_1.85s	_{p=0.807 n=6}
_{Check Time}	_{35.20s (± 0.46%)}	_{35.02s (± 0.97%)}	_~	_34.47s	_35.38s	_{p=0.378 n=6}
_{Emit Time}	_{3.04s (± 0.54%)}	_{2.98s (± 0.63%)}	_{-0.05s (- 1.70%)}	_2.96s	_3.01s	_{p=0.005 n=6}
_{Total Time}	_{45.44s (± 0.38%)}	_{45.29s (± 0.66%)}	_~	_44.81s	_45.65s	_{p=0.471 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,474	_262,474	_~	_~	_~	_{p=1.000 n=6}
_Types	_107,135	_107,134	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{441,735k (± 0.01%)}	_{441,699k (± 0.01%)}	_~	_441,640k	_441,795k	_{p=0.298 n=6}
_{Parse Time}	_{3.52s (± 0.80%)}	_{3.54s (± 1.13%)}	_~	_3.47s	_3.57s	_{p=0.627 n=6}
_{Bind Time}	_{1.32s (± 1.62%)}	_{1.32s (± 0.83%)}	_~	_1.31s	_1.34s	_{p=0.868 n=6}
_{Check Time}	_{18.84s (± 0.47%)}	_{18.91s (± 0.24%)}	_~	_18.85s	_18.96s	_{p=0.148 n=6}
_{Emit Time}	_{1.53s (± 1.47%)}	_{1.51s (± 0.80%)}	_~	_1.50s	_1.53s	_{p=0.370 n=6}
_{Total Time}	_{25.22s (± 0.43%)}	_{25.28s (± 0.26%)}	_~	_25.23s	_25.37s	_{p=0.467 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₁	₇₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,327	_225,327	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,288	_94,288	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,024k (± 0.01%)}	_{370,985k (± 0.02%)}	_~	_370,923k	_371,056k	_{p=0.230 n=6}
_{Parse Time}	_{2.31s (± 0.65%)}	_{2.32s (± 0.63%)}	_~	_2.30s	_2.34s	_{p=0.462 n=6}
_{Bind Time}	_{1.35s (± 1.69%)}	_{1.33s (± 1.48%)}	_~	_1.32s	_1.36s	_{p=0.161 n=6}
_{Check Time}	_{13.64s (± 0.19%)}	_{13.60s (± 0.42%)}	_~	_13.50s	_13.66s	_{p=0.324 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{17.30s (± 0.24%)}	_{17.26s (± 0.40%)}	_~	_17.13s	_17.34s	_{p=0.261 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃₃	₃₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,471,654	_3,471,654	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,167,299	_1,167,299	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,518,645k (± 0.00%)}	_{3,518,609k (± 0.00%)}	_~	_3,518,338k	_3,518,726k	_{p=0.936 n=6}
_{Parse Time}	_{14.98s (± 0.73%)}	_{15.02s (± 0.22%)}	_~	_14.99s	_15.08s	_{p=0.520 n=6}
_{Bind Time}	_{4.87s (± 0.69%)}	_{4.84s (± 0.83%)}	_~	_4.77s	_4.88s	_{p=0.226 n=6}
_{Check Time}	_{96.11s (± 2.61%)}	_{94.83s (± 4.88%)}	_~	_92.30s	_104.24s	_{p=0.230 n=6}
_{Emit Time}	_{29.95s (± 2.80%)}	_{29.44s (± 1.39%)}	_~	_29.15s	_30.23s	_{p=0.575 n=6}
_{Total Time}	_{145.91s (± 2.10%)}	_{144.12s (± 3.48%)}	_~	_141.37s	_154.32s	_{p=0.298 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₂	₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_320,000	_320,000	_~	_~	_~	_{p=1.000 n=6}
_Types	_140,356	_140,356	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{474,133k (± 0.01%)}	_{474,224k (± 0.03%)}	_~	_474,034k	_474,369k	_{p=0.298 n=6}
_{Parse Time}	_{4.35s (± 0.43%)}	_{4.32s (± 0.40%)}	_~	_4.29s	_4.34s	_{p=0.054 n=6}
_{Bind Time}	_{1.76s (± 1.64%)}	_{1.75s (± 1.75%)}	_~	_1.71s	_1.80s	_{p=1.000 n=6}
_{Check Time}	_{20.68s (± 0.34%)}	_{20.72s (± 0.40%)}	_~	_20.62s	_20.82s	_{p=0.521 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{26.79s (± 0.36%)}	_{26.80s (± 0.33%)}	_~	_26.68s	_26.91s	_{p=0.873 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_667,036	_666,295	_{-741 (- 0.11%)}	_~	_~	_{p=0.001 n=6}
_Types	_198,508	_198,987	_{+479 (+ 0.24%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{569,745k (± 0.01%)}	_{569,731k (± 0.01%)}	_~	_569,675k	_569,771k	_{p=0.936 n=6}
_{Parse Time}	_{5.54s (± 0.82%)}	_{5.53s (± 0.85%)}	_~	_5.46s	_5.58s	_{p=1.000 n=6}
_{Bind Time}	_{1.67s (± 0.49%)}	_{1.66s (± 1.12%)}	_~	_1.64s	_1.68s	_{p=0.288 n=6}
_{Check Time}	_{25.36s (± 0.45%)}	_{25.34s (± 0.53%)}	_~	_25.19s	_25.54s	_{p=0.688 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{32.57s (± 0.28%)}	_{32.53s (± 0.43%)}	_~	_32.40s	_32.75s	_{p=0.298 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-06-18T20:23:05Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61893/merge:

Something interesting changed - please have a look.

Details

pmndrs/jotai

tsconfig.json

error TS2769: No overload matches this call.
error TS2322: Type 'unknown' is not assignable to type 'ReactNode'.
- tests/react/vanilla-utils/atomWithObservable.test.tsx#L632

experiment: remove SymbolConstructor ESSymbolType transform

d5210de

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jun 18, 2025

Renegade334 closed this Jun 18, 2025

LukeAbby mentioned this pull request Jun 18, 2025

Declaration merging lib file's unique symbol with symbol errors microsoft/typescript-go#1212

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

experiment: remove SymbolConstructor ESSymbol transform #61893

experiment: remove SymbolConstructor ESSymbol transform #61893

Uh oh!

Renegade334 commented Jun 18, 2025 •

edited

Loading

Uh oh!

jakebailey commented Jun 18, 2025

Uh oh!

typescript-bot commented Jun 18, 2025 •

edited

Loading

Uh oh!

typescript-bot commented Jun 18, 2025

Uh oh!

typescript-bot commented Jun 18, 2025

Uh oh!

typescript-bot commented Jun 18, 2025

tsc

Uh oh!

typescript-bot commented Jun 18, 2025

pmndrs/jotai

tsconfig.json

Uh oh!

Uh oh!

experiment: remove SymbolConstructor ESSymbol transform #61893

experiment: remove SymbolConstructor ESSymbol transform #61893

Uh oh!

Conversation

Renegade334 commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakebailey commented Jun 18, 2025

Uh oh!

typescript-bot commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jun 18, 2025

Uh oh!

typescript-bot commented Jun 18, 2025

Uh oh!

typescript-bot commented Jun 18, 2025

tsc

Uh oh!

typescript-bot commented Jun 18, 2025

pmndrs/jotai

tsconfig.json

Uh oh!

Uh oh!

Renegade334 commented Jun 18, 2025 •

edited

Loading

typescript-bot commented Jun 18, 2025 •

edited

Loading