Skip to content

Sort symbol members #61420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Sort symbol members #61420

wants to merge 2 commits into from

Conversation

@jakebailey
Copy link
Member

@jakebailey jakebailey commented Mar 14, 2025

Similar to #61399; seeing the impact here.

Very interestingly, the type baselines indicate a reduction in type counts.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 14, 2025
@jakebailey
Copy link
Member Author

jakebailey commented Mar 14, 2025

@typescript-bot test it
@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 14, 2025 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
pack this ✅ Started ✅ Results
test top400 ✅ Started 👀 Results
user test this ✅ Started 👀 Results
run dt ✅ Started 👀 Results
perf test this faster ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 14, 2025 •
edited
Loading

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/164921/artifacts?artifactName=tgz&fileId=859C616807850EF465B8E70A5F58E95D873637AEA59D072C67C5779CAEF8887F02&fileName=/typescript-5.9.0-insiders.20250314.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 14, 2025

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/61420/merge:

Something interesting changed - please have a look.

Details

effect

tsconfig.json

tsconfig.build.json

tsconfig.base.json

packages/platform/dtslint/tsconfig.json

npmlog

/mnt/ts_downloads/_/m/npmlog/tsconfig.json

  • [NEW] error TS2551: Property '_paused' does not exist on type '{ useColor: () => any; enableColor: () => void; disableColor: () => void; level: string; gauge: any; tracker: any; progressEnabled: any; enableUnicode: () => void; disableUnicode: () => void; setGaugeThemeset: (themes: any) => void; ... 35 more ...; eventNames(): (string | symbol)[]; }'. Did you mean 'pause'?
    • /mnt/ts_downloads/_/m/npmlog/node_modules/npmlog/log.js(218,12)
  • [MISSING] error TS2551: Property '_paused' does not exist on type '{ [EventEmitter.captureRejectionSymbol]?<K>(error: Error, event: string | symbol, ...args: AnyRest): void; addListener<K>(eventName: string | symbol, listener: (...args: any[]) => void): EventEmitter<...>; ... 43 more ...; disp: {}; }'. Did you mean 'pause'?
    • /mnt/ts_downloads/_/m/npmlog/node_modules/npmlog/log.js(218,12)

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 14, 2025

Hey @jakebailey, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: json-merge-patch
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/json-merge-patch/json-merge-patch-tests.ts
  14:5  error  TypeScript@local expected type to be:
  { a: string; b?: undefined; } | { b: string; a?: undefined; }
got:
  { a: string; b?: undefined; } | { a?: undefined; b: string; }                                                          @definitelytyped/expect
  26:5  error  TypeScript@local expected type to be:
  { a: string; b: string; } | { a: string; b?: undefined; }
got:
  { a: string; b: string; } | { b?: undefined; a: string; }                                                                  @definitelytyped/expect
  32:5  error  TypeScript@local expected type to be:
  { a: any; b?: undefined; } | { b: string; a?: undefined; }
got:
  { b?: undefined; a: any; } | { a?: undefined; b: string; }                                                                @definitelytyped/expect
  62:5  error  TypeScript@local expected type to be:
  { a: { b: { c: string; }; }; d: string; } | { a: { b: string; }; d?: undefined; }
got:
  { a: { b: { c: string; }; }; d: string; } | { d?: undefined; a: { b: string; }; }                  @definitelytyped/expect
  68:5  error  TypeScript@local expected type to be:
  { a: { b: { c: string; }; d: string; }; } | { a: { b: { c: string; }; d?: undefined; }; }
got:
  { a: { b: { c: string; }; d: string; }; } | { a: { d?: undefined; b: { c: string; }; }; }  @definitelytyped/expect

✖ 5 problems (5 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: conventional-changelog-config-spec
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/conventional-changelog-config-spec/conventional-changelog-config-spec-tests.ts
  8:5  error  TypeScript@local expected type to be:
  JSONSchema7 || { default: JSONSchema7; $id?: string | undefined; $ref?: string | undefined; $schema?: string | undefined; $comment?: string | undefined; $defs?: { [key: string]: JSONSchema7Definition; } | undefined; type?: JSONSchema7TypeName | JSONSchema7TypeName[] | undefined; enum?: JSONSchema7Type[] | undefined; const?: JSONSchema7Type | undefined; multipleOf?: number | undefined; maximum?: number | undefined; exclusiveMaximum?: number | undefined; minimum?: number | undefined; exclusiveMinimum?: number | undefined; maxLength?: number | undefined; minLength?: number | undefined; pattern?: string | undefined; items?: JSONSchema7Definition | JSONSchema7Definition[] | undefined; additionalItems?: JSONSchema7Definition | undefined; maxItems?: number | undefined; minItems?: number | undefined; uniqueItems?: boolean | undefined; contains?: JSONSchema7Definition | undefined; maxProperties?: number | undefined; minProperties?: number | undefined; required?: string[] | undefined; properties?: { [key: string]: JSONSchema7Definition; } | undefined; patternProperties?: { [key: string]: JSONSchema7Definition; } | undefined; additionalProperties?: JSONSchema7Definition | undefined; dependencies?: { [key: string]: JSONSchema7Definition | string[]; } | undefined; propertyNames?: JSONSchema7Definition | undefined; if?: JSONSchema7Definition | undefined; then?: JSONSchema7Definition | undefined; else?: JSONSchema7Definition | undefined; allOf?: JSONSchema7Definition[] | undefined; anyOf?: JSONSchema7Definition[] | undefined; oneOf?: JSONSchema7Definition[] | undefined; not?: JSONSchema7Definition | undefined; format?: string | undefined; contentMediaType?: string | undefined; contentEncoding?: string | undefined; definitions?: { [key: string]: JSONSchema7Definition; } | undefined; title?: string | undefined; description?: string | undefined; readOnly?: boolean | undefined; writeOnly?: boolean | undefined; examples?: JSONSchema7Type | undefined; } || { default: JSONSchema7; $id?: string | undefined; $ref?: string | undefined; $schema?: string | undefined; $comment?: string | undefined; $defs?: { [key: string]: JSONSchema7Definition; } | undefined; type?: JSONSchema7TypeName | JSONSchema7TypeName[] | undefined; enum?: JSONSchema7Type[] | undefined; const?: JSONSchema7Type | undefined; multipleOf?: number | undefined; maximum?: number | undefined; exclusiveMaximum?: number | undefined; minimum?: number | undefined; exclusiveMinimum?: number | undefined; maxLength?: number | undefined; minLength?: number | undefined; pattern?: string | undefined; items?: JSONSchema7Definition | JSONSchema7Definition[] | undefined; additionalItems?: JSONSchema7Definition | undefined; maxItems?: number | undefined; minItems?: number | undefined; uniqueItems?: boolean | undefined; contains?: JSONSchema7Definition | undefined; maxProperties?: number | undefined; minProperties?: number | undefined; required?: string[] | undefined; properties?: { [key: string]: JSONSchema7Definition; } | undefined; patternProperties?: { [key: string]: JSONSchema7Definition; } | undefined; additionalProperties?: JSONSchema7Definition | undefined; dependencies?: { [key: string]: string[] | JSONSchema7Definition; } | undefined; propertyNames?: JSONSchema7Definition | undefined; if?: JSONSchema7Definition | undefined; then?: JSONSchema7Definition | undefined; else?: JSONSchema7Definition | undefined; allOf?: JSONSchema7Definition[] | undefined; anyOf?: JSONSchema7Definition[] | undefined; oneOf?: JSONSchema7Definition[] | undefined; not?: JSONSchema7Definition | undefined; format?: string | undefined; contentMediaType?: string | undefined; contentEncoding?: string | undefined; definitions?: { [key: string]: JSONSchema7Definition; } | undefined; title?: string | undefined; description?: string | undefined; readOnly?: boolean | undefined; writeOnly?: boolean | undefined; examples?: JSONSchema7Type | undefined; }
got:
  { $id?: string | undefined; $ref?: string | undefined; $schema?: string | undefined; $comment?: string | undefined; $defs?: { [key: string]: JSONSchema7Definition; } | undefined; type?: JSONSchema7TypeName | JSONSchema7TypeName[] | undefined; enum?: JSONSchema7Type[] | undefined; const?: JSONSchema7Type | undefined; multipleOf?: number | undefined; maximum?: number | undefined; exclusiveMaximum?: number | undefined; minimum?: number | undefined; exclusiveMinimum?: number | undefined; maxLength?: number | undefined; minLength?: number | undefined; pattern?: string | undefined; items?: JSONSchema7Definition | JSONSchema7Definition[] | undefined; additionalItems?: JSONSchema7Definition | undefined; maxItems?: number | undefined; minItems?: number | undefined; uniqueItems?: boolean | undefined; contains?: JSONSchema7Definition | undefined; maxProperties?: number | undefined; minProperties?: number | undefined; required?: string[] | undefined; properties?: { [key: string]: JSONSchema7Definition; } | undefined; patternProperties?: { [key: string]: JSONSchema7Definition; } | undefined; additionalProperties?: JSONSchema7Definition | undefined; dependencies?: { [key: string]: string[] | JSONSchema7Definition; } | undefined; propertyNames?: JSONSchema7Definition | undefined; if?: JSONSchema7Definition | undefined; then?: JSONSchema7Definition | undefined; else?: JSONSchema7Definition | undefined; allOf?: JSONSchema7Definition[] | undefined; anyOf?: JSONSchema7Definition[] | undefined; oneOf?: JSONSchema7Definition[] | undefined; not?: JSONSchema7Definition | undefined; format?: string | undefined; contentMediaType?: string | undefined; contentEncoding?: string | undefined; definitions?: { [key: string]: JSONSchema7Definition; } | undefined; title?: string | undefined; description?: string | undefined; readOnly?: boolean | undefined; writeOnly?: boolean | undefined; examples?: JSONSchema7Type | undefined; default: JSONSchema7; }  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: crimsonq
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/crimsonq/crimsonq-tests.ts
  28:5  error  TypeScript@local expected type to be:
  { default: RedisStatic; Cluster: ClusterStatic; Command: typeof Command; };
got:
  { Cluster: ClusterStatic; Command: typeof Command; default: RedisStatic; }  @definitelytyped/expect
  29:5  error  TypeScript@local expected type to be:
  { default: RedisStatic; Cluster: ClusterStatic; Command: typeof Command; };
got:
  { Cluster: ClusterStatic; Command: typeof Command; default: RedisStatic; }  @definitelytyped/expect

✖ 2 problems (2 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: yargs/v15
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/yargs/v15/yargs-tests.ts
   148:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; update: boolean | undefined; extern: boolean | undefined; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; extern: boolean | undefined; update: boolean | undefined; }                                                                                                                                                                                                                                                 @definitelytyped/expect
   447:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; file: unknown; cleanDestination: boolean | undefined; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; cleanDestination: boolean | undefined; file: unknown; }                                                                                                                                                                                                                                                         @definitelytyped/expect
   938:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; a: (string | number)[] | undefined; b: boolean | undefined; c: number; n: number | undefined; s: string | undefined; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; a: (string | number)[] | undefined; b: boolean | undefined; c: number; n: number | undefined; s: string | undefined; }                                                                                                                           @definitelytyped/expect
   947:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; a: number; b: boolean; c: string; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; a: number; b: boolean; c: string; }                                                                                                                                                                                                                                                                                                 @definitelytyped/expect
   954:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; a: (string | number)[] | undefined; b: boolean | undefined; n: number | undefined; s: string | undefined; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; a: (string | number)[] | undefined; b: boolean | undefined; n: number | undefined; s: string | undefined; }                                                                                                                                                 @definitelytyped/expect
   962:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; choices: Color; numberChoices: Stage; coerce: Date | undefined; count: number; normalize: string | undefined; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; choices: Color; coerce: Date | undefined; count: number; normalize: string | undefined; numberChoices: Stage; }                                                                                                                                         @definitelytyped/expect
  1015:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; x: string; y: number; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; x: string; y: number; }                                                                                                                                                                                                                                                                                                                         @definitelytyped/expect
  1018:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; x: string; y: number; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; x: string; y: number; }                                                                                                                                                                                                                                                                                                                         @definitelytyped/expect
  1021:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; x: string | undefined; y: number | undefined; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; x: string | undefined; y: number | undefined; }                                                                                                                                                                                                                                                                         @definitelytyped/expect
  1024:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; x: string; y: number; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; x: string; y: number; }                                                                                                                                                                                                                                                                                                                         @definitelytyped/expect
  1027:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; x: string; y: number; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; x: string; y: number; }                                                                                                                                                                                                                                                                                                                         @definitelytyped/expect
  1030:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; x: string | undefined; y: number | undefined; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; x: string | undefined; y: number | undefined; }                                                                                                                                                                                                                                                                         @definitelytyped/expect
  1060:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; a: string; b: boolean; c: number; d: number; e: number; _: (string | number)[]; $0: string; } || { [x: string]: unknown; b: boolean; a: string; d: number; e: number; c: number; _: (string | number)[]; $0: string; } ||  { [x: string]: unknown; b: boolean; a: string; c: number; d: number; e: number; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; a: string; b: boolean; c: number; d: number; e: number; }  @definitelytyped/expect
  1068:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; a: string; b: boolean; c: number; d: number; e: number; _: (string | number)[]; $0: string; } || { [x: string]: unknown; b: boolean; a: string; d: number; e: number; c: number; _: (string | number)[]; $0: string; } || { [x: string]: unknown; b: boolean; a: string; c: number; d: number; e: number; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; a: string; b: boolean; c: number; d: number; e: number; }   @definitelytyped/expect
  1076:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; a: number; b: string; c: boolean; _: (string | number)[]; $0: string; } || { [x: string]: unknown; b: string; a: number; c: Date; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; a: number; b: string; c: boolean; }                                                                                                                                                                                                 @definitelytyped/expect
  1082:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; a: number; b: string; c: Date; _: (string | number)[]; $0: string; } || { [x: string]: unknown; b: string; a: number; c: Date; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; a: number; b: string; c: Date; }                                                                                                                                                                                                       @definitelytyped/expect
  1088:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; a: number; b: string[]; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; a: number; b: string[]; }                                                                                                                                                                                                                                                                                                                     @definitelytyped/expect
  1103:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; a: number | undefined; b: string | undefined; c: Color; _: (string | number)[]; $0: string; } || { [x: string]: unknown; b: string | undefined; a: number | undefined; c: Color; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; c: Color; a: number | undefined; b: string | undefined; }                                                                                                                            @definitelytyped/expect
  1111:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; u: string | undefined; url: string | undefined; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; u: string | undefined; url: string | undefined; }                                                                                                                                                                                                                                                                     @definitelytyped/expect
  1118:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; v: boolean; loud: boolean; noisy: boolean; verbose: boolean; n: boolean; _: (string | number)[]; $0: string; } || { [x: string]: unknown; v: boolean; verbose: boolean; loud: boolean; noisy: boolean; n: boolean; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; loud: boolean; n: boolean; noisy: boolean; v: boolean; verbose: boolean; }                                                                         @definitelytyped/expect
  1125:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; n: number; count: number; num: number; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; count: number; n: number; num: number; }                                                                                                                                                                                                                                                                                       @definitelytyped/expect

✖ 21 problems (21 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: yargs/v16
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/yargs/v16/yargs-tests.ts
   149:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; update: boolean | undefined; extern: boolean | undefined; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; extern: boolean | undefined; update: boolean | undefined; }                                                                                                                                                                                                                                                 @definitelytyped/expect
   448:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; file: unknown; cleanDestination: boolean | undefined; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; cleanDestination: boolean | undefined; file: unknown; }                                                                                                                                                                                                                                                         @definitelytyped/expect
   939:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; a: (string | number)[] | undefined; b: boolean | undefined; c: number; n: number | undefined; s: string | undefined; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; a: (string | number)[] | undefined; b: boolean | undefined; c: number; n: number | undefined; s: string | undefined; }                                                                                                                           @definitelytyped/expect
   948:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; a: number; b: boolean; c: string; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; a: number; b: boolean; c: string; }                                                                                                                                                                                                                                                                                                 @definitelytyped/expect
   955:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; a: (string | number)[] | undefined; b: boolean | undefined; n: number | undefined; s: string | undefined; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; a: (string | number)[] | undefined; b: boolean | undefined; n: number | undefined; s: string | undefined; }                                                                                                                                                 @definitelytyped/expect
   963:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; choices: Color; numberChoices: Stage; coerce: Date | undefined; count: number; normalize: string | undefined; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; choices: Color; coerce: Date | undefined; count: number; normalize: string | undefined; numberChoices: Stage; }                                                                                                                                         @definitelytyped/expect
  1016:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; x: string; y: number; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; x: string; y: number; }                                                                                                                                                                                                                                                                                                                         @definitelytyped/expect
  1019:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; x: string; y: number; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; x: string; y: number; }                                                                                                                                                                                                                                                                                                                         @definitelytyped/expect
  1022:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; x: string | undefined; y: number | undefined; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; x: string | undefined; y: number | undefined; }                                                                                                                                                                                                                                                                         @definitelytyped/expect
  1025:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; x: string; y: number; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; x: string; y: number; }                                                                                                                                                                                                                                                                                                                         @definitelytyped/expect
  1028:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; x: string; y: number; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; x: string; y: number; }                                                                                                                                                                                                                                                                                                                         @definitelytyped/expect
  1031:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; x: string | undefined; y: number | undefined; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; x: string | undefined; y: number | undefined; }                                                                                                                                                                                                                                                                         @definitelytyped/expect
  1061:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; a: string; b: boolean; c: number; d: number; e: number; _: (string | number)[]; $0: string; } || { [x: string]: unknown; b: boolean; a: string; d: number; e: number; c: number; _: (string | number)[]; $0: string; } ||  { [x: string]: unknown; b: boolean; a: string; c: number; d: number; e: number; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; a: string; b: boolean; c: number; d: number; e: number; }  @definitelytyped/expect
  1069:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; a: string; b: boolean; c: number; d: number; e: number; _: (string | number)[]; $0: string; } || { [x: string]: unknown; b: boolean; a: string; d: number; e: number; c: number; _: (string | number)[]; $0: string; } || { [x: string]: unknown; b: boolean; a: string; c: number; d: number; e: number; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; a: string; b: boolean; c: number; d: number; e: number; }   @definitelytyped/expect
  1077:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; a: number; b: string; c: boolean; _: (string | number)[]; $0: string; } || { [x: string]: unknown; b: string; a: number; c: Date; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; a: number; b: string; c: boolean; }                                                                                                                                                                                                 @definitelytyped/expect
  1083:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; a: number; b: string; c: Date; _: (string | number)[]; $0: string; } || { [x: string]: unknown; b: string; a: number; c: Date; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; a: number; b: string; c: Date; }                                                                                                                                                                                                       @definitelytyped/expect
  1089:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; a: number; b: string[]; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; a: number; b: string[]; }                                                                                                                                                                                                                                                                                                                     @definitelytyped/expect
  1104:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; a: number | undefined; b: string | undefined; c: Color; _: (string | number)[]; $0: string; } || { [x: string]: unknown; b: string | undefined; a: number | undefined; c: Color; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; c: Color; a: number | undefined; b: string | undefined; }                                                                                                                            @definitelytyped/expect
  1112:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; u: string | undefined; url: string | undefined; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; u: string | undefined; url: string | undefined; }                                                                                                                                                                                                                                                                     @definitelytyped/expect
  1119:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; v: boolean; loud: boolean; noisy: boolean; verbose: boolean; n: boolean; _: (string | number)[]; $0: string; } || { [x: string]: unknown; v: boolean; verbose: boolean; loud: boolean; noisy: boolean; n: boolean; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; loud: boolean; n: boolean; noisy: boolean; v: boolean; verbose: boolean; }                                                                         @definitelytyped/expect
  1126:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; n: number; count: number; num: number; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; _: (string | number)[]; $0: string; count: number; n: number; num: number; }                                                                                                                                                                                                                                                                                       @definitelytyped/expect

✖ 21 problems (21 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: yargs
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/yargs/yargs-tests.ts
   156:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; _: (string | number)[]; $0: string; } | Promise<{ [x: string]: unknown; _: (string | number)[]; $0: string; }>
got:
  { [x: string]: unknown; $0: string; _: (string | number)[]; } | Promise<{ [x: string]: unknown; $0: string; _: (string | number)[]; }>                                                                                                                                                                                                                          @definitelytyped/expect
   159:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; _: (string | number)[]; $0: string; } | Promise<{ [x: string]: unknown; _: (string | number)[]; $0: string; }>
got:
  { [x: string]: unknown; $0: string; _: (string | number)[]; } | Promise<{ [x: string]: unknown; $0: string; _: (string | number)[]; }>                                                                                                                                                                                                                          @definitelytyped/expect
   162:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; _: (string | number)[]; $0: string; } | Promise<{ [x: string]: unknown; _: (string | number)[]; $0: string; }>
got:
  { [x: string]: unknown; $0: string; _: (string | number)[]; } | Promise<{ [x: string]: unknown; $0: string; _: (string | number)[]; }>                                                                                                                                                                                                                          @definitelytyped/expect
   165:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; _: (string | number)[]; $0: string; } | Promise<{ [x: string]: unknown; _: (string | number)[]; $0: string; }>
got:
  { [x: string]: unknown; $0: string; _: (string | number)[]; } | Promise<{ [x: string]: unknown; $0: string; _: (string | number)[]; }>                                                                                                                                                                                                                          @definitelytyped/expect
   168:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; update: boolean | undefined; extern: boolean | undefined; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; $0: string; _: (string | number)[]; extern: boolean | undefined; update: boolean | undefined; }                                                                                                                                                                                                                                                        @definitelytyped/expect
   467:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; file: unknown; cleanDestination: boolean | undefined; _: (string | number)[]; $0: string; } | Promise<{ [x: string]: unknown; file: unknown; cleanDestination: boolean | undefined; _: (string | number)[]; $0: string; }>
got:
  { [x: string]: unknown; $0: string; _: (string | number)[]; cleanDestination: boolean | undefined; file: unknown; } | Promise<{ [x: string]: unknown; $0: string; _: (string | number)[]; cleanDestination: boolean | undefined; file: unknown; }>  @definitelytyped/expect
  1029:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; a: (string | number)[] | undefined; b: boolean | undefined; c: number; n: number | undefined; s: string | undefined; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; $0: string; _: (string | number)[]; a: (string | number)[] | undefined; b: boolean | undefined; c: number; n: number | undefined; s: string | undefined; }                                                                                                                                  @definitelytyped/expect
  1038:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; a: number; b: boolean; c: string; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; $0: string; _: (string | number)[]; a: number; b: boolean; c: string; }                                                                                                                                                                                                                                                                                                        @definitelytyped/expect
  1045:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; a: (string | number)[] | undefined; b: boolean | undefined; n: number | undefined; s: string | undefined; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; $0: string; _: (string | number)[]; a: (string | number)[] | undefined; b: boolean | undefined; n: number | undefined; s: string | undefined; }                                                                                                                                                        @definitelytyped/expect
  1053:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; choices: Color; numberChoices: Stage; coerce: Date | undefined; count: number; normalize: string | undefined; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; $0: string; _: (string | number)[]; choices: Color; coerce: Date | undefined; count: number; normalize: string | undefined; numberChoices: Stage; }                                                                                                                                                @definitelytyped/expect
  1062:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; choices: Color; numberChoices: Stage; coerce: Date; count: number | "no"; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; $0: string; _: (string | number)[]; choices: Color; coerce: Date; count: number | "no"; numberChoices: Stage; }                                                                                                                                                                                                                        @definitelytyped/expect
  1073:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; p: ("x" | "y")[] | undefined; q: string[] | undefined; r: "x" | "y" | undefined; s: ("x" | "y")[] | undefined; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; $0: string; _: (string | number)[]; p: ("x" | "y")[] | undefined; q: string[] | undefined; r: "x" | "y" | undefined; s: ("x" | "y")[] | undefined; }                                                                                                                                              @definitelytyped/expect
  1153:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; x: string; y: number; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; $0: string; _: (string | number)[]; x: string; y: number; }                                                                                                                                                                                                                                                                                                                                @definitelytyped/expect
  1156:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; x: string; y: number; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; $0: string; _: (string | number)[]; x: string; y: number; }                                                                                                                                                                                                                                                                                                                                @definitelytyped/expect
  1159:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; x: string | undefined; y: number | undefined; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; $0: string; _: (string | number)[]; x: string | undefined; y: number | undefined; }                                                                                                                                                                                                                                                                                @definitelytyped/expect
  1162:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; x: string; y: number; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; $0: string; _: (string | number)[]; x: string; y: number; }                                                                                                                                                                                                                                                                                                                                @definitelytyped/expect
  1165:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; x: string; y: number; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; $0: string; _: (string | number)[]; x: string; y: number; }                                                                                                                                                                                                                                                                                                                                @definitelytyped/expect
  1168:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; x: string | undefined; y: number | undefined; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; $0: string; _: (string | number)[]; x: string | undefined; y: number | undefined; }                                                                                                                                                                                                                                                                                @definitelytyped/expect
  1219:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; a: string; b: boolean; c: number; d: number; e: number; _: (string | number)[]; $0: string; } || { [x: string]: unknown; b: boolean; a: string; d: number; e: number; c: number; _: (string | number)[]; $0: string; } ||  { [x: string]: unknown; b: boolean; a: string; c: number; d: number; e: number; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; $0: string; _: (string | number)[]; a: string; b: boolean; c: number; d: number; e: number; }         @definitelytyped/expect
  1227:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; a: string; b: boolean; c: number; d: number; e: number; _: (string | number)[]; $0: string; } || { [x: string]: unknown; b: boolean; a: string; d: number; e: number; c: number; _: (string | number)[]; $0: string; } || { [x: string]: unknown; b: boolean; a: string; c: number; d: number; e: number; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; $0: string; _: (string | number)[]; a: string; b: boolean; c: number; d: number; e: number; }          @definitelytyped/expect
  1235:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; a: number; b: string; c: boolean; _: (string | number)[]; $0: string; } || { [x: string]: unknown; b: string; a: number; c: Date; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; $0: string; _: (string | number)[]; a: number; b: string; c: boolean; }                                                                                                                                                                                                        @definitelytyped/expect
  1241:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; a: number; b: string; c: Date; _: (string | number)[]; $0: string; } || { [x: string]: unknown; b: string; a: number; c: Date; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; $0: string; _: (string | number)[]; a: number; b: string; c: Date; }                                                                                                                                                                                                              @definitelytyped/expect
  1247:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; a: number; b: string[]; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; $0: string; _: (string | number)[]; a: number; b: string[]; }                                                                                                                                                                                                                                                                                                                            @definitelytyped/expect
  1262:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; a: number | undefined; b: string | undefined; c: Color; _: (string | number)[]; $0: string; } || { [x: string]: unknown; b: string | undefined; a: number | undefined; c: Color; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; $0: string; _: (string | number)[]; a: number | undefined; b: string | undefined; c: Color; }                                                                                                                                   @definitelytyped/expect
  1270:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; u: string | undefined; url: string | undefined; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; $0: string; _: (string | number)[]; u: string | undefined; url: string | undefined; }                                                                                                                                                                                                                                                                            @definitelytyped/expect
  1277:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; v: boolean; loud: boolean; noisy: boolean; verbose: boolean; n: boolean; _: (string | number)[]; $0: string; } || { [x: string]: unknown; v: boolean; verbose: boolean; loud: boolean; noisy: boolean; n: boolean; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; $0: string; _: (string | number)[]; loud: boolean; n: boolean; noisy: boolean; v: boolean; verbose: boolean; }                                                                                @definitelytyped/expect
  1284:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; n: number; count: number; num: number; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; $0: string; _: (string | number)[]; count: number; n: number; num: number; }                                                                                                                                                                                                                                                                                              @definitelytyped/expect
  1291:5  error  TypeScript@local expected type to be:
  { [x: string]: unknown; u: string | undefined; url: string | undefined; _: (string | number)[]; $0: string; }
got:
  { [x: string]: unknown; $0: string; _: (string | number)[]; u: string | undefined; url: string | undefined; }                                                                                                                                                                                                                                                                            @definitelytyped/expect

✖ 28 problems (28 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: ramda
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/ramda/test/fromPairs-tests.ts
  13:5  error  TypeScript@local expected type to be:
  { 2: string; 1: string; }
got:
  { 1: string; 2: string; }  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

You can check the log here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 14, 2025

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 34 34 ~ ~ ~ p=1.000 n=6
Symbols 62,390 62,398 +8 (+ 0.01%) ~ ~ p=0.001 n=6
Types 50,395 50,399 +4 (+ 0.01%) ~ ~ p=0.001 n=6
Memory used 192,982k (± 0.07%) 194,779k (± 1.01%) +1,797k (+ 0.93%) 192,950k 196,616k p=0.031 n=6
Parse Time 1.31s (± 0.62%) 1.31s (± 0.57%) ~ 1.30s 1.32s p=0.306 n=6
Bind Time 0.73s 0.73s ~ ~ ~ p=1.000 n=6
Check Time 9.74s (± 0.65%) 10.13s (± 0.24%) 🔻+0.39s (+ 4.02%) 10.10s 10.16s p=0.005 n=6
Emit Time 2.74s (± 1.30%) 2.73s (± 0.60%) ~ 2.71s 2.75s p=0.418 n=6
Total Time 14.52s (± 0.59%) 14.91s (± 0.14%) +0.39s (+ 2.68%) 14.88s 14.93s p=0.005 n=6
angular-1 - node (v18.15.0, x64)
Errors 56 56 ~ ~ ~ p=1.000 n=6
Symbols 948,670 948,852 +182 (+ 0.02%) ~ ~ p=0.001 n=6
Types 410,947 416,682 +5,735 (+ 1.40%) ~ ~ p=0.001 n=6
Memory used 1,224,329k (± 0.00%) 1,229,287k (± 0.00%) +4,958k (+ 0.40%) 1,229,208k 1,229,339k p=0.005 n=6
Parse Time 6.65s (± 0.67%) 6.61s (± 0.98%) ~ 6.52s 6.70s p=0.297 n=6
Bind Time 1.89s (± 0.52%) 1.88s (± 0.52%) ~ 1.87s 1.89s p=0.058 n=6
Check Time 31.86s (± 0.22%) 32.70s (± 0.45%) +0.83s (+ 2.62%) 32.46s 32.90s p=0.005 n=6
Emit Time 15.28s (± 0.49%) 15.25s (± 0.32%) ~ 15.18s 15.30s p=0.809 n=6
Total Time 55.69s (± 0.27%) 56.45s (± 0.30%) +0.76s (+ 1.36%) 56.24s 56.62s p=0.005 n=6
mui-docs - node (v18.15.0, x64)
Errors 0 1 🔻+1 (+ ∞%) ~ ~ p=0.001 n=6
Symbols 2,363,439 2,551,681 🔻+188,242 (+ 7.96%) ~ ~ p=0.001 n=6
Types 846,685 861,345 +14,660 (+ 1.73%) ~ ~ p=0.001 n=6
Memory used 2,133,380k (± 0.01%) 2,228,143k (± 0.01%) 🔻+94,764k (+ 4.44%) 2,228,008k 2,228,564k p=0.005 n=6
Parse Time 7.24s (± 0.32%) 7.24s (± 0.33%) ~ 7.20s 7.26s p=0.871 n=6
Bind Time 2.50s (± 0.55%) 2.49s (± 1.17%) ~ 2.46s 2.54s p=0.568 n=6
Check Time 73.89s (± 0.43%) 77.73s (± 0.31%) 🔻+3.84s (+ 5.19%) 77.32s 77.96s p=0.005 n=6
Emit Time 0.15s (± 3.53%) 0.15s (± 3.53%) ~ 0.15s 0.16s p=1.000 n=6
Total Time 83.79s (± 0.38%) 87.62s (± 0.28%) 🔻+3.83s (+ 4.58%) 87.23s 87.85s p=0.005 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,226,697 1,227,217 +520 (+ 0.04%) ~ ~ p=0.001 n=6
Types 266,990 269,646 +2,656 (+ 0.99%) ~ ~ p=0.001 n=6
Memory used 2,357,186k (± 0.02%) 2,359,342k (± 0.03%) +2,156k (+ 0.09%) 2,358,907k 2,360,469k p=0.005 n=6
Parse Time 5.22s (± 0.67%) 5.20s (± 1.05%) ~ 5.14s 5.27s p=0.810 n=6
Bind Time 1.78s (± 1.26%) 1.79s (± 0.55%) ~ 1.78s 1.81s p=0.391 n=6
Check Time 35.34s (± 0.11%) 35.71s (± 0.25%) +0.37s (+ 1.04%) 35.61s 35.81s p=0.005 n=6
Emit Time 3.08s (± 3.99%) 3.01s (± 1.09%) ~ 2.98s 3.05s p=0.378 n=6
Total Time 45.43s (± 0.34%) 45.74s (± 0.23%) +0.32s (+ 0.69%) 45.55s 45.81s p=0.013 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,226,697 1,227,217 +520 (+ 0.04%) ~ ~ p=0.001 n=6
Types 266,990 269,646 +2,656 (+ 0.99%) ~ ~ p=0.001 n=6
Memory used 3,032,241k (± 9.75%) 3,157,264k (± 0.02%) 🔻+125,023k (+ 4.12%) 3,156,562k 3,157,940k p=0.005 n=6
Parse Time 6.92s (± 1.30%) 6.99s (± 0.74%) ~ 6.92s 7.07s p=0.128 n=6
Bind Time 2.13s (± 1.28%) 2.13s (± 0.84%) ~ 2.11s 2.16s p=0.872 n=6
Check Time 42.76s (± 0.38%) 43.21s (± 0.25%) +0.45s (+ 1.05%) 43.12s 43.37s p=0.005 n=6
Emit Time 3.47s (± 1.68%) 3.59s (± 2.14%) +0.13s (+ 3.70%) 3.50s 3.72s p=0.020 n=6
Total Time 55.28s (± 0.49%) 55.91s (± 0.21%) +0.63s (+ 1.15%) 55.78s 56.09s p=0.005 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 262,669 263,114 +445 (+ 0.17%) ~ ~ p=0.001 n=6
Types 106,848 108,337 +1,489 (+ 1.39%) ~ ~ p=0.001 n=6
Memory used 440,460k (± 0.01%) 441,351k (± 0.01%) +891k (+ 0.20%) 441,315k 441,400k p=0.005 n=6
Parse Time 3.54s (± 0.50%) 3.53s (± 1.29%) ~ 3.46s 3.59s p=0.518 n=6
Bind Time 1.32s (± 1.33%) 1.31s (± 1.57%) ~ 1.28s 1.33s p=0.289 n=6
Check Time 18.99s (± 0.61%) 19.22s (± 0.20%) +0.22s (+ 1.18%) 19.17s 19.26s p=0.006 n=6
Emit Time 1.51s (± 1.37%) 1.53s (± 0.76%) ~ 1.51s 1.54s p=0.243 n=6
Total Time 25.37s (± 0.51%) 25.59s (± 0.16%) +0.22s (+ 0.85%) 25.54s 25.64s p=0.005 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 71 71 ~ ~ ~ p=1.000 n=6
Symbols 225,981 226,050 +69 (+ 0.03%) ~ ~ p=0.001 n=6
Types 94,356 94,799 +443 (+ 0.47%) ~ ~ p=0.001 n=6
Memory used 371,251k (± 0.02%) 371,593k (± 0.05%) +342k (+ 0.09%) 371,413k 371,829k p=0.005 n=6
Parse Time 2.90s (± 1.16%) 2.88s (± 0.71%) ~ 2.84s 2.90s p=0.331 n=6
Bind Time 1.60s (± 0.65%) 1.59s (± 1.22%) ~ 1.56s 1.61s p=0.140 n=6
Check Time 16.49s (± 0.38%) 16.74s (± 0.19%) +0.24s (+ 1.48%) 16.70s 16.79s p=0.005 n=6
Emit Time 0.00s (±244.70%) 0.00s ~ ~ ~ p=0.405 n=6
Total Time 21.00s (± 0.28%) 21.20s (± 0.29%) +0.21s (+ 0.98%) 21.12s 21.30s p=0.005 n=6
vscode - node (v18.15.0, x64)
Errors 8 8 ~ ~ ~ p=1.000 n=6
Symbols 3,301,356 3,302,032 +676 (+ 0.02%) ~ ~ p=0.001 n=6
Types 1,117,677 1,191,485 🔻+73,808 (+ 6.60%) ~ ~ p=0.001 n=6
Memory used 3,362,385k (± 0.00%) 3,396,807k (± 0.00%) +34,423k (+ 1.02%) 3,396,698k 3,396,876k p=0.005 n=6
Parse Time 14.55s (± 0.75%) 14.60s (± 0.75%) ~ 14.43s 14.68s p=0.520 n=6
Bind Time 4.70s (± 2.23%) 4.72s (± 2.50%) ~ 4.59s 4.88s p=0.572 n=6
Check Time 93.07s (± 2.92%) 92.11s (± 0.46%) ~ 91.45s 92.48s p=0.810 n=6
Emit Time 27.52s (± 8.62%) 29.11s (± 0.49%) ~ 28.95s 29.30s p=0.230 n=6
Total Time 139.84s (± 1.68%) 140.54s (± 0.35%) ~ 139.61s 141.07s p=0.199 n=6
webpack - node (v18.15.0, x64)
Errors 2 2 ~ ~ ~ p=1.000 n=6
Symbols 308,237 307,865 -372 (- 0.12%) ~ ~ p=0.001 n=6
Types 134,948 135,423 +475 (+ 0.35%) ~ ~ p=0.001 n=6
Memory used 463,426k (± 0.02%) 463,456k (± 0.02%) ~ 463,367k 463,591k p=0.575 n=6
Parse Time 4.12s (± 0.18%) 4.11s (± 0.30%) ~ 4.09s 4.12s p=0.078 n=6
Bind Time 1.80s (± 1.42%) 1.80s (± 0.77%) ~ 1.78s 1.81s p=0.869 n=6
Check Time 20.46s (± 0.51%) 20.70s (± 0.19%) +0.25s (+ 1.20%) 20.64s 20.75s p=0.008 n=6
Emit Time 0.00s (±244.70%) 0.00s (±244.70%) ~ 0.00s 0.01s p=1.000 n=6
Total Time 26.38s (± 0.41%) 26.61s (± 0.17%) +0.23s (+ 0.85%) 26.53s 26.65s p=0.008 n=6
xstate-main - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 558,554 558,358 -196 (- 0.04%) ~ ~ p=0.001 n=6
Types 188,194 188,511 +317 (+ 0.17%) ~ ~ p=0.001 n=6
Memory used 492,305k (± 0.05%) 492,349k (± 0.04%) ~ 492,140k 492,569k p=0.689 n=6
Parse Time 3.37s (± 0.59%) 3.37s (± 0.55%) ~ 3.35s 3.39s p=0.685 n=6
Bind Time 1.20s (± 0.63%) 1.20s (± 1.11%) ~ 1.18s 1.21s p=1.000 n=6
Check Time 19.77s (± 0.38%) 20.09s (± 0.26%) +0.31s (+ 1.57%) 20.03s 20.17s p=0.005 n=6
Emit Time 0.00s (±244.70%) 0.00s ~ ~ ~ p=0.405 n=6
Total Time 24.34s (± 0.35%) 24.65s (± 0.29%) +0.31s (+ 1.27%) 24.57s 24.77s p=0.005 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 14, 2025

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61420/merge:

Something interesting changed - please have a look.

Details

mui/material-ui

23 of 86 projects failed to build with the old tsc and were ignored

docs/tsconfig.json

  • error TS2322: Type '{ component: ForwardRefExoticComponent<Omit<LinkProps, "ref"> & RefAttributes<HTMLAnchorElement>> | typeof DeadLink; ... 10 more ...; children: (string | ... 3 more ... | undefined)[]; }' is not assignable to type 'IntrinsicAttributes & ItemBaseProps & MUIStyledCommonProps<Theme>'.

@jakebailey
Copy link
Member Author

jakebailey commented Mar 14, 2025

Hm, real perf is worse (duh), but moreso it's interesting that there are more symbols and types in the perf tests.

@jakebailey
Copy link
Member Author

jakebailey commented Jul 1, 2025

Closing; if I want to retest this I'll repick from the tsgo-port branch with both sorting changes.

@jakebailey jakebailey closed this Jul 1, 2025
@jakebailey jakebailey mentioned this pull request Oct 6, 2025
Draft
@jakebailey jakebailey deleted the symbol-order branch November 6, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@jakebailey jakebailey

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jakebailey @typescript-bot