[WIP] Disallow merging of enum declarations

[rbuckton]

This is an experiment to access the impact of disallowing the merging of enum declarations.

[typescript-bot]

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

[rbuckton]

@typescript-bot test top400
@typescript-bot user test this

[typescript-bot]

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
test top400	✅ Started	✅ Results
user test this	✅ Started	✅ Results

[typescript-bot]

@rbuckton Here are the results of running the user tests with tsc comparing main and refs/pull/61262/merge:

Everything looks good!

[typescript-bot]

@rbuckton Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61262/merge:

Everything looks good!

[rbuckton]

@typescript-bot test top10.00

[typescript-bot]

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
test top10.00	✅ Started

[rbuckton]

@typescript-bot test top1000

[typescript-bot]

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
test top1000	✅ Started	✅ Results

[typescript-bot]

@rbuckton Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61262/merge:

Everything looks good!

[rbuckton]

@typescript-bot test top999

[typescript-bot]

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
test top999	✅ Started	👀 Results

[typescript-bot]

@rbuckton Here are the results of running the top 999 repos with tsc comparing main and refs/pull/61262/merge:

Something interesting changed - please have a look.

Details

microsoft/azuredatastudio

16 of 67 projects failed to build with the old tsc and were ignored

extensions/sql-migration/tsconfig.json

• error TS2339: Property 'hyperlink' does not exist on type 'typeof ColumnType'.
  • extensions/sql-migration/src/dashboard/migrationDetailsTableTab.ts#L146
  • extensions/sql-migration/src/dashboard/migrationsListTab.ts#L490
  • extensions/sql-migration/src/dashboard/migrationsListTab.ts#L508
  • extensions/sql-migration/src/wizard/databaseBackupPage.ts#L1860
  • extensions/sql-migration/src/wizard/databaseBackupPage.ts#L1869
  • extensions/sql-migration/src/wizard/loginMigrationStatusPage.ts#L277
  • extensions/sql-migration/src/wizard/loginSelectorPage.ts#L470
  • extensions/sql-migration/src/wizard/loginSelectorPage.ts#L529
• error TS2339: Property 'contextMenu' does not exist on type 'typeof ColumnType'.
  • extensions/sql-migration/src/dashboard/migrationsListTab.ts#L589
• error TS2339: Property 'icon' does not exist on type 'typeof ColumnType'.
  • extensions/sql-migration/src/dialog/generic/multiStepStatusDialog.ts#L259
  • extensions/sql-migration/src/dialog/loginMigration/loginPreMigrationValidationDialog.ts#L311
  • extensions/sql-migration/src/dialog/tdeConfiguration/tdeConfigurationDialog.ts#L536
  • extensions/sql-migration/src/dialog/tdeConfiguration/tdeMigrationDialog.ts#L413
  • extensions/sql-migration/src/dialog/validationResults/validateIrDialog.ts#L369
  • extensions/sql-migration/src/wizard/databaseSelectorPage.ts#L285

extensions/sql-assessment/tsconfig.json

• error TS2339: Property 'icon' does not exist on type 'typeof ColumnType'.
  • extensions/sql-assessment/src/assessmentResultGrid.ts#L67

microsoft/vscode

5 of 55 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

• error TS2322: Type 'LanguageModelChatMessageRole.System' is not assignable to type 'LanguageModelChatMessageRole'.
  • src/vs/workbench/api/common/extHostTypeConverters.ts#L2299
• error TS2322: Type 'LanguageModelChatMessageRole.User' is not assignable to type 'LanguageModelChatMessageRole'.
  • src/vs/workbench/api/common/extHostTypeConverters.ts#L2300
• error TS2322: Type 'LanguageModelChatMessageRole.Assistant' is not assignable to type 'LanguageModelChatMessageRole'.
  • src/vs/workbench/api/common/extHostTypeConverters.ts#L2301
• error TS2678: Type 'LanguageModelChatMessageRole.User' is not comparable to type 'LanguageModelChatMessageRole'.
  • src/vs/workbench/api/common/extHostTypeConverters.ts#L2308
• error TS2678: Type 'LanguageModelChatMessageRole.Assistant' is not comparable to type 'LanguageModelChatMessageRole'.
  • src/vs/workbench/api/common/extHostTypeConverters.ts#L2309
• error TS2345: Argument of type 'LanguageModelChatMessageRole.User' is not assignable to parameter of type 'LanguageModelChatMessageRole'.
  • src/vs/workbench/api/common/extHostTypes.ts#L4807
  • src/vs/workbench/api/common/extHostTypes.ts#L4866
• error TS2345: Argument of type 'LanguageModelChatMessageRole.Assistant' is not assignable to parameter of type 'LanguageModelChatMessageRole'.
  • src/vs/workbench/api/common/extHostTypes.ts#L4811
  • src/vs/workbench/api/common/extHostTypes.ts#L4870