Export executeCommandLine from public API (internal for now) #58057

jakebailey · 2024-04-03T16:19:44Z

This extracts just the executeCommandLine and public API changes from #57703. My intent is that I can make a mini tsc using the public API such that we can long-term perf test changes like #58045 which only affect the public API, without writing all of the code to directly use Program/build mode.

~~I've opted to export the executeCommandLine function in public with a simplified signature, but I could also just leave this all internal.~~

Exporting this increases the package size by 40KB, not that bad.

Overall package size

	Before	After	Diff	Diff (percent)
Packed	3.77 MiB	3.77 MiB	+8.05 KiB	+0.21%
Unpacked	20.38 MiB	20.42 MiB	+40.52 KiB	+0.19%

Files

	Before	After	Diff	Diff (percent)
`lib/typescript.d.ts`	561.75 KiB	561.97 KiB	+228.00 B	+0.04%
`lib/typescript.js`	8.18 MiB	8.22 MiB	+40.30 KiB	+0.48%

typescript-bot · 2024-04-03T16:19:58Z

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

tests/baselines/reference/api/typescript.d.ts

src/typescript/_namespaces/ts.ts

jakebailey · 2024-04-03T18:38:47Z

I've made it internal again, but, I will note that some people do actually want to use this API in public, though. I don't think it's a big deal to leave it internal for the time being in any case.

jakebailey · 2024-04-04T22:13:59Z

@typescript-bot perf test this faster

typescript-bot · 2024-04-04T22:14:01Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-04-04T22:47:52Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,729k (± 0.01%)}	_{295,752k (± 0.01%)}	_~	_295,725k	_295,785k	_{p=0.261 n=6}
_{Parse Time}	_{2.65s (± 0.65%)}	_{2.65s (± 0.46%)}	_~	_2.64s	_2.67s	_{p=1.000 n=6}
_{Bind Time}	_{0.83s (± 0.49%)}	_{0.83s (± 1.00%)}	_~	_0.83s	_0.85s	_{p=0.527 n=6}
_{Check Time}	_{8.24s (± 0.40%)}	_{8.27s (± 0.32%)}	_~	_8.23s	_8.30s	_{p=0.295 n=6}
_{Emit Time}	_{7.03s (± 0.35%)}	_{7.05s (± 0.14%)}	_~	_7.04s	_7.06s	_{p=0.118 n=6}
_{Total Time}	_{18.75s (± 0.32%)}	_{18.80s (± 0.10%)}	_~	_18.78s	_18.82s	_{p=0.195 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,328k (± 0.93%)}	_{192,304k (± 0.08%)}	_~	_192,128k	_192,462k	_{p=1.000 n=6}
_{Parse Time}	_{1.36s (± 1.00%)}	_{1.35s (± 1.11%)}	_~	_1.33s	_1.37s	_{p=0.453 n=6}
_{Bind Time}	_{0.73s (± 0.56%)}	_{0.73s (± 0.00%)}	_~	_0.73s	_0.73s	_{p=0.405 n=6}
_{Check Time}	_{9.51s (± 0.35%)}	_{9.53s (± 0.82%)}	_~	_9.43s	_9.64s	_{p=1.000 n=6}
_{Emit Time}	_{2.60s (± 0.89%)}	_{2.60s (± 0.40%)}	_~	_2.59s	_2.62s	_{p=0.869 n=6}
_{Total Time}	_{14.20s (± 0.39%)}	_{14.21s (± 0.63%)}	_~	_14.12s	_14.34s	_{p=1.000 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,516k (± 0.00%)}	_{347,514k (± 0.01%)}	_~	_347,490k	_347,552k	_{p=0.575 n=6}
_{Parse Time}	_{2.49s (± 0.53%)}	_{2.49s (± 0.49%)}	_~	_2.47s	_2.50s	_{p=0.863 n=6}
_{Bind Time}	_{0.93s (± 0.56%)}	_{0.93s (± 0.56%)}	_~	_0.92s	_0.93s	_{p=1.000 n=6}
_{Check Time}	_{6.97s (± 0.26%)}	_{6.99s (± 0.65%)}	_~	_6.93s	_7.04s	_{p=0.624 n=6}
_{Emit Time}	_{4.07s (± 0.46%)}	_{4.05s (± 0.40%)}	_~	_4.03s	_4.08s	_{p=0.301 n=6}
_{Total Time}	_{14.45s (± 0.22%)}	_{14.45s (± 0.39%)}	_~	_14.37s	_14.51s	_{p=0.872 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,838k (± 0.01%)}	_{302,824k (± 0.01%)}	_~	_302,782k	_302,879k	_{p=0.378 n=6}
_{Parse Time}	_{2.98s (± 0.28%)}	_{2.96s (± 0.78%)}	_~	_2.92s	_2.98s	_{p=0.438 n=6}
_{Bind Time}	_{1.48s (± 0.66%)}	_{1.47s (± 0.37%)}	_~	_1.47s	_1.48s	_{p=0.662 n=6}
_{Check Time}	_{9.27s (± 0.71%)}	_{9.29s (± 0.45%)}	_~	_9.24s	_9.35s	_{p=0.521 n=6}
_{Emit Time}	_{5.30s (± 0.25%)}	_{5.30s (± 0.46%)}	_~	_5.28s	_5.35s	_{p=0.803 n=6}
_{Total Time}	_{19.02s (± 0.35%)}	_{19.03s (± 0.27%)}	_~	_18.98s	_19.11s	_{p=0.809 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{510,063k (± 0.00%)}	_{510,085k (± 0.00%)}	_~	_510,052k	_510,120k	_{p=0.173 n=6}
_{Parse Time}	_{2.67s (± 0.21%)}	_{2.67s (± 0.31%)}	_~	_2.66s	_2.68s	_{p=0.855 n=6}
_{Bind Time}	_{0.98s (± 0.77%)}	_{0.99s (± 0.99%)}	_~	_0.97s	_1.00s	_{p=0.167 n=6}
_{Check Time}	_{17.31s (± 0.33%)}	_{17.34s (± 0.48%)}	_~	_17.24s	_17.48s	_{p=0.744 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.96s (± 0.23%)}	_{20.99s (± 0.41%)}	_~	_20.90s	_21.14s	_{p=0.809 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,744,958k (± 0.00%)}	_{1,744,966k (± 0.00%)}	_~	_1,744,903k	_1,745,006k	_{p=0.748 n=6}
_{Parse Time}	_{9.65s (± 0.28%)}	_{9.66s (± 0.50%)}	_~	_9.57s	_9.71s	_{p=0.334 n=6}
_{Bind Time}	_{3.48s (± 0.66%)}	_{3.47s (± 1.27%)}	_~	_3.41s	_3.53s	_{p=0.572 n=6}
_{Check Time}	_{82.20s (± 0.29%)}	_{82.11s (± 0.21%)}	_~	_81.83s	_82.29s	_{p=0.470 n=6}
_{Emit Time}	_{0.19s (± 2.13%)}	_{0.20s (± 2.62%)}	_~	_0.19s	_0.20s	_{p=0.112 n=6}
_{Total Time}	_{95.52s (± 0.25%)}	_{95.44s (± 0.24%)}	_~	_95.11s	_95.65s	_{p=0.575 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,402,219k (± 0.04%)}	_{2,296,545k (± 0.04%)}	_{🟩-105,674k (- 4.40%)}	_2,295,514k	_2,297,967k	_{p=0.005 n=6}
_{Parse Time}	_{7.44s (± 0.98%)}	_{7.41s (± 0.95%)}	_~	_7.32s	_7.50s	_{p=0.629 n=6}
_{Bind Time}	_{2.71s (± 3.80%)}	_{2.78s (± 1.15%)}	_~	_2.74s	_2.83s	_{p=0.120 n=6}
_{Check Time}	_{49.31s (± 0.47%)}	_{49.14s (± 0.56%)}	_~	_48.85s	_49.44s	_{p=0.575 n=6}
_{Emit Time}	_{3.93s (± 2.01%)}	_{3.98s (± 1.56%)}	_~	_3.90s	_4.08s	_{p=0.378 n=6}
_{Total Time}	_{63.41s (± 0.24%)}	_{63.28s (± 0.38%)}	_~	_62.99s	_63.54s	_{p=0.378 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_{Memory used}	_0k	_{2,259,234k (± 0.03%)}	_~	_2,258,604k	_2,260,637k	_{p=1.000 n=0+6}
_{Parse Time}	_0.00s	_{7.57s (± 1.13%)}	_~	_7.44s	_7.67s	_{p=1.000 n=0+6}
_{Bind Time}	_0.00s	_{2.60s (± 0.75%)}	_~	_2.57s	_2.63s	_{p=1.000 n=0+6}
_{Check Time}	_0.00s	_{52.89s (± 0.24%)}	_~	_52.80s	_53.14s	_{p=1.000 n=0+6}
_{Emit Time}	_0.00s	_{4.16s (± 3.09%)}	_~	_4.01s	_4.32s	_{p=1.000 n=0+6}
_{Total Time}	_0.00s	_{67.23s (± 0.29%)}	_~	_67.01s	_67.51s	_{p=1.000 n=0+6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{416,596k (± 0.01%)}	_{419,453k (± 0.01%)}	_{+2,857k (+ 0.69%)}	_419,425k	_419,481k	_{p=0.005 n=6}
_{Parse Time}	_{3.34s (± 0.56%)}	_{3.36s (± 0.49%)}	_{+0.03s (+ 0.80%)}	_3.34s	_3.38s	_{p=0.035 n=6}
_{Bind Time}	_{1.30s (± 1.05%)}	_{1.31s (± 0.93%)}	_~	_1.29s	_1.32s	_{p=0.303 n=6}
_{Check Time}	_{18.26s (± 0.66%)}	_{18.23s (± 0.28%)}	_~	_18.17s	_18.31s	_{p=1.000 n=6}
_{Emit Time}	_{1.39s (± 1.76%)}	_{1.37s (± 1.19%)}	_~	_1.35s	_1.39s	_{p=0.220 n=6}
_{Total Time}	_{24.28s (± 0.48%)}	_{24.27s (± 0.19%)}	_~	_24.21s	_24.33s	_{p=0.810 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,908,045k (± 0.00%)}	_{2,908,100k (± 0.00%)}	_~	_2,908,040k	_2,908,174k	_{p=0.630 n=6}
_{Parse Time}	_{15.85s (± 0.33%)}	_{15.88s (± 0.34%)}	_~	_15.82s	_15.97s	_{p=0.470 n=6}
_{Bind Time}	_{5.07s (± 0.38%)}	_{5.06s (± 0.54%)}	_~	_5.01s	_5.09s	_{p=0.568 n=6}
_{Check Time}	_{87.45s (± 0.71%)}	_{87.18s (± 0.24%)}	_~	_86.85s	_87.47s	_{p=0.810 n=6}
_{Emit Time}	_{24.39s (± 7.94%)}	_{23.66s (± 0.70%)}	_~	_23.43s	_23.88s	_{p=0.873 n=6}
_{Total Time}	_{132.76s (± 1.38%)}	_{131.77s (± 0.30%)}	_~	_131.19s	_132.23s	_{p=0.298 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{409,049k (± 0.03%)}	_{409,000k (± 0.01%)}	_~	_408,927k	_409,065k	_{p=0.575 n=6}
_{Parse Time}	_{4.81s (± 0.58%)}	_{4.78s (± 0.97%)}	_~	_4.73s	_4.85s	_{p=0.374 n=6}
_{Bind Time}	_{2.06s (± 0.71%)}	_{2.07s (± 0.47%)}	_~	_2.05s	_2.08s	_{p=0.440 n=6}
_{Check Time}	_{20.92s (± 0.23%)}	_{20.88s (± 0.23%)}	_~	_20.81s	_20.93s	_{p=0.169 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{27.79s (± 0.24%)}	_{27.73s (± 0.33%)}	_~	_27.61s	_27.86s	_{p=0.261 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,601k (± 0.02%)}	_{513,531k (± 0.01%)}	_~	_513,480k	_513,663k	_{p=0.229 n=6}
_{Parse Time}	_{4.90s (± 0.52%)}	_{4.91s (± 0.74%)}	_~	_4.86s	_4.95s	_{p=0.748 n=6}
_{Bind Time}	_{2.31s (± 1.31%)}	_{2.32s (± 0.82%)}	_~	_2.30s	_2.34s	_{p=0.251 n=6}
_{Check Time}	_{4.32s (± 0.99%)}	_{4.32s (± 0.45%)}	_~	_4.30s	_4.35s	_{p=0.746 n=6}
_{Emit Time}	_{0.11s (± 0.00%)}	_{0.11s (± 3.65%)}	_~	_0.11s	_0.12s	_{p=0.405 n=6}
_{Total Time}	_{11.64s (± 0.69%)}	_{11.65s (± 0.31%)}	_~	_11.61s	_11.70s	_{p=0.421 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

jakebailey · 2024-04-04T22:48:12Z

Good, it's working.

jakebailey added 2 commits April 3, 2024 09:14

Export executeCommandLine from services for public API

8eebbd8

Export

5f38971

typescript-bot assigned jakebailey Apr 3, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 3, 2024

fix compile

53b1ec5

sheetalkamat reviewed Apr 3, 2024

View reviewed changes

tests/baselines/reference/api/typescript.d.ts Outdated Show resolved Hide resolved

sheetalkamat reviewed Apr 3, 2024

View reviewed changes

src/typescript/_namespaces/ts.ts Outdated Show resolved Hide resolved

jakebailey added 2 commits April 3, 2024 10:55

Move executeCommandLine to compiler

3420a71

Unexport

def150a

weswigham approved these changes Apr 3, 2024

View reviewed changes

sheetalkamat approved these changes Apr 3, 2024

View reviewed changes

jakebailey marked this pull request as draft April 4, 2024 04:42

jakebailey marked this pull request as ready for review April 4, 2024 19:47

jakebailey changed the title ~~Export executeCommandLine from public API~~ Export executeCommandLine from public API (internal for now) Apr 4, 2024

jakebailey mentioned this pull request Apr 4, 2024

Switch benchmarking commands to consistently use builtDir microsoft/typescript-benchmarking#46

Merged

jakebailey merged commit 5144b3e into microsoft:main Apr 4, 2024

jakebailey deleted the export-execute-command-line branch April 4, 2024 22:52

jakebailey mentioned this pull request Feb 20, 2025

Include results from --extendedDiagnostics when using the compiler API #61229

Open

6 tasks

microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Export executeCommandLine from public API (internal for now) #58057

Export executeCommandLine from public API (internal for now) #58057

Uh oh!

jakebailey commented Apr 3, 2024 •

edited

Loading

Uh oh!

typescript-bot commented Apr 3, 2024

Uh oh!

Uh oh!

Uh oh!

jakebailey commented Apr 3, 2024

Uh oh!

jakebailey commented Apr 4, 2024

Uh oh!

typescript-bot commented Apr 4, 2024 •

edited

Loading

Uh oh!

typescript-bot commented Apr 4, 2024

tsc

Uh oh!

jakebailey commented Apr 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Export executeCommandLine from public API (internal for now) #58057

Export executeCommandLine from public API (internal for now) #58057

Uh oh!

Conversation

jakebailey commented Apr 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overall package size

Files

Uh oh!

typescript-bot commented Apr 3, 2024

Uh oh!

Uh oh!

Uh oh!

jakebailey commented Apr 3, 2024

Uh oh!

jakebailey commented Apr 4, 2024

Uh oh!

typescript-bot commented Apr 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 4, 2024

tsc

Uh oh!

jakebailey commented Apr 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jakebailey commented Apr 3, 2024 •

edited

Loading

typescript-bot commented Apr 4, 2024 •

edited

Loading