Allow valid contextual keyword completions even when an auto-import by the same name exists #56001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y the same name exists
typescript-bot
added
Author: Team
For Milestone Bug
jakebailey
reviewed
Oct 5, 2023
| * ``` | ||
| */ | ||
| function isContextualKeywordInAutoImportableExpressionSpace(keyword: string) { | ||
| return keyword === "abstract" || |
There was a problem hiding this comment.
I think canonically we'd use a switch for this (faster at runtime I assume).
There was a problem hiding this comment.
Didn’t we move the visitor API off a switch and onto a lookup table for performance reasons?
There was a problem hiding this comment.
Anyway, this list seems small enough and is unlikely to grow
There was a problem hiding this comment.
No, that was for a different reason IIRC, the function was so big that it didn't optimize with so many cases handled inside of it
gabritto
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See code comment and linked issue comments for description.
Fixes #55607