Add a test for finding all references of same-named imports from two missing modules #55519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
commented
Aug 26, 2023
| // === findAllReferences === | ||
| // === /tests/cases/fourslash/findAllRefsMissingModulesOverlappingSpecifiers.ts === | ||
| // // https://github.com/microsoft/TypeScript/issues/5551 | ||
| // import { resolve/*FIND ALL REFS*/ as resolveUrl } from "idontcare"; |
Contributor
Author
There was a problem hiding this comment.
It's worth noting that this one just doesn't find any references while the other one finds the reference at the location of the request. I think it's fine - the most important thing is that both locations are not treated as references to the same thing.
jakebailey
approved these changes
Aug 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5551
@jakebailey bisected the actual fix to #13643