Skip to content

fix: type key typo #55443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2023
Merged

fix: type key typo #55443

merged 1 commit into from
Sep 7, 2023

Conversation

@0o001
Copy link
Contributor

@0o001 0o001 commented Aug 21, 2023

Fixes #

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 21, 2023
@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 21, 2023

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@MartinJohns
Copy link
Contributor

MartinJohns commented Aug 21, 2023 •
edited
Loading

From the Pull Request template:

** Please don't send typo fixes! **
Please don't send a PR solely for the purpose of fixing a typo, unless that typo truly hurts understanding of the text. Each PR represents work for the maintainers, and that work should provide commensurate value.

Same as last time.

@0o001
Copy link
Contributor Author

0o001 commented Aug 21, 2023 •
edited
Loading

From the Pull Request template:

** Please don't send typo fixes! **
Please don't send a PR solely for the purpose of fixing a typo, unless that typo truly hurts understanding of the text. Each PR represents work for the maintainers, and that work should provide commensurate value.

It's not only a typo fixes because ReadableProgramBuildInfoRoot key name is wrong

@sandersn sandersn merged commit c532603 into microsoft:main Sep 7, 2023
@sandersn
Copy link
Member

sandersn commented Sep 7, 2023 •
edited
Loading

** Please don't send typo fixes! **
Please don't send a PR solely for the purpose of fixing a typo, unless that typo truly hurts understanding of the text. Each PR represents work for the maintainers, and that work should provide commensurate value.

In this case, I've already done the work, so I merged the PR, but this is just a typo fix because these tuple labels are just for documentation.

snovader pushed a commit to EG-A-S/TypeScript that referenced this pull request Sep 23, 2023
@0o001 @snovader
fix: type key typo (microsoft#55443)
132baf8
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@0o001 @typescript-bot @MartinJohns @sandersn