Consider `import.meta` a qualified name/property access #54997

gabritto · 2023-07-12T23:12:16Z

isRightSideOfQualifiedNameOrPropertyAccess is called by getTypeOfSymbolAtLocation to decide if we should consider the location's parent instead, so that if we have a property access/qualified name, e.g. x.y, we look up the whole expression, and not just y. Because import.meta was not considered one of those cases, when getTypeOfSymbolAtLocation was called by completions, we'd end up trying to resolve the name meta, which doesn't resolve to anything, leading to the error.

gabritto · 2023-07-12T23:15:44Z

@typescript-bot test this
@typescript-bot run DT
@typescript-bot user test tsserver
@typescript-bot test top100
@typescript-bot test tsserver top100
@typescript-bot perf test this

typescript-bot · 2023-07-12T23:15:47Z

Heya @gabritto, I've started to run the perf test suite on this PR at 1e2c9ae. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-07-12T23:15:47Z

Heya @gabritto, I've started to run the extended test suite on this PR at 1e2c9ae. You can monitor the build here.

typescript-bot · 2023-07-12T23:15:47Z

Heya @gabritto, I've started to run the diff-based top-repos suite (tsserver) on this PR at 1e2c9ae. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-07-12T23:15:47Z

Heya @gabritto, I've started to run the diff-based user code test suite (tsserver) on this PR at 1e2c9ae. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-07-12T23:15:47Z

Heya @gabritto, I've started to run the parallelized Definitely Typed test suite on this PR at 1e2c9ae. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-07-12T23:15:47Z

Heya @gabritto, I've started to run the diff-based top-repos suite on this PR at 1e2c9ae. You can monitor the build here.

Update: The results are in!

jakebailey · 2023-07-12T23:45:01Z

tests/baselines/reference/plainJSGrammarErrors.types

 >foo : () => void
 >new.targe : () => void
->targe : any
+>targe : () => void


Weird, how is this changing? This doesn't seem to be using meta at all.

new.something is also a MetaProperty node, I'm guessing this is to also support new.target.

Do I even want to know why targe works without the t? 😅

Probably fall-out logic where any meta-property that's not import.meta is assumed to be new.target.

typescript-bot · 2023-07-12T23:48:04Z

@gabritto Here are the results of running the user test suite comparing main and refs/pull/54997/merge:

Everything looks good!

typescript-bot · 2023-07-13T00:12:04Z

@gabritto
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..54997

_Metric	_main	₅₄₉₉₇	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{366,849k (± 0.01%)}	_{366,847k (± 0.01%)}	_~	_366,800k	_366,871k	_{p=0.936 n=6}
_{Parse Time}	_{3.40s (± 0.69%)}	_{3.39s (± 0.63%)}	_~	_3.37s	_3.43s	_{p=0.224 n=6}
_{Bind Time}	_{1.12s (± 0.67%)}	_{1.12s (± 0.36%)}	_~	_1.12s	_1.13s	_{p=0.389 n=6}
_{Check Time}	_{8.87s (± 0.43%)}	_{8.88s (± 0.48%)}	_~	_8.83s	_8.93s	_{p=1.000 n=6}
_{Emit Time}	_{7.52s (± 1.00%)}	_{7.53s (± 0.64%)}	_~	_7.46s	_7.59s	_{p=0.748 n=6}
_{Total Time}	_{20.92s (± 0.48%)}	_{20.92s (± 0.34%)}	_~	_20.79s	_20.99s	_{p=0.574 n=6}
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{192,100k (± 1.19%)}	_{193,970k (± 1.59%)}	_~	_191,119k	_196,838k	_{p=0.521 n=6}
_{Parse Time}	_{1.52s (± 0.65%)}	_{1.52s (± 0.83%)}	_~	_1.50s	_1.53s	_{p=0.799 n=6}
_{Bind Time}	_{0.78s (± 0.97%)}	_{0.78s (± 0.71%)}	_~	_0.77s	_0.78s	_{p=0.476 n=6}
_{Check Time}	_{9.55s (± 0.39%)}	_{9.52s (± 0.72%)}	_~	_9.45s	_9.62s	_{p=0.421 n=6}
_{Emit Time}	_{2.76s (± 0.32%)}	_{2.74s (± 0.55%)}	_~	_2.72s	_2.76s	_{p=0.054 n=6}
_{Total Time}	_{14.61s (± 0.36%)}	_{14.56s (± 0.55%)}	_~	_14.49s	_14.67s	_{p=0.297 n=6}
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{346,877k (± 0.01%)}	_{346,857k (± 0.01%)}	_~	_346,810k	_346,883k	_{p=0.520 n=6}
_{Parse Time}	_{2.64s (± 1.14%)}	_{2.63s (± 1.42%)}	_~	_2.59s	_2.68s	_{p=0.571 n=6}
_{Bind Time}	_{1.01s (± 1.03%)}	_{1.02s (± 0.51%)}	_~	_1.01s	_1.02s	_{p=0.794 n=6}
_{Check Time}	_{7.31s (± 0.67%)}	_{7.30s (± 0.49%)}	_~	_7.24s	_7.34s	_{p=0.686 n=6}
_{Emit Time}	_{4.27s (± 1.04%)}	_{4.24s (± 0.89%)}	_~	_4.20s	_4.31s	_{p=0.226 n=6}
_{Total Time}	_{15.22s (± 0.69%)}	_{15.17s (± 0.51%)}	_~	_15.09s	_15.30s	_{p=0.332 n=6}
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{300,903k (± 0.01%)}	_{300,903k (± 0.01%)}	_~	_300,882k	_300,925k	_{p=0.810 n=6}
_{Parse Time}	_{2.10s (± 1.17%)}	_{2.10s (± 0.97%)}	_~	_2.07s	_2.12s	_{p=0.935 n=6}
_{Bind Time}	_{1.12s (± 0.88%)}	_{1.13s (± 0.79%)}	_~	_1.12s	_1.14s	_{p=0.208 n=6}
_{Check Time}	_{6.63s (± 0.48%)}	_{6.64s (± 0.42%)}	_~	_6.61s	_6.68s	_{p=0.744 n=6}
_{Emit Time}	_{3.87s (± 0.55%)}	_{3.87s (± 0.22%)}	_~	_3.85s	_3.87s	_{p=0.806 n=6}
_{Total Time}	_{13.72s (± 0.45%)}	_{13.73s (± 0.17%)}	_~	_13.70s	_13.76s	_{p=0.629 n=6}
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{482,382k (± 0.01%)}	_{482,390k (± 0.01%)}	_~	_482,342k	_482,518k	_{p=0.689 n=6}
_{Parse Time}	_{3.10s (± 2.36%)}	_{3.10s (± 2.18%)}	_~	_2.97s	_3.15s	_{p=0.625 n=6}
_{Bind Time}	_{0.93s (± 5.61%)}	_{0.95s (± 4.41%)}	_~	_0.92s	_1.03s	_{p=0.084 n=6}
_{Check Time}	_{17.34s (± 0.81%)}	_{17.38s (± 0.39%)}	_~	_17.31s	_17.49s	_{p=0.297 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.37s (± 0.63%)}	_{21.43s (± 0.39%)}	_~	_21.32s	_21.56s	_{p=0.173 n=6}
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{563,658k (± 0.03%)}	_{563,689k (± 0.02%)}	_~	_563,549k	_563,833k	_{p=0.575 n=6}
_{Parse Time}	_{3.84s (± 0.74%)}	_{3.86s (± 0.64%)}	_~	_3.82s	_3.89s	_{p=0.259 n=6}
_{Bind Time}	_{1.65s (± 0.73%)}	_{1.66s (± 0.92%)}	_~	_1.64s	_1.68s	_{p=0.517 n=6}
_{Check Time}	_{2.81s (± 1.13%)}	_{2.82s (± 1.38%)}	_~	_2.75s	_2.86s	_{p=0.469 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{8.38s (± 0.57%)}	_{8.42s (± 0.76%)}	_~	_8.31s	_8.49s	_{p=0.173 n=6}
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{366,269k (± 0.01%)}	_{366,246k (± 0.01%)}	_~	_366,214k	_366,299k	_{p=0.230 n=6}
_{Parse Time}	_{3.56s (± 0.73%)}	_{3.59s (± 0.56%)}	_~	_3.56s	_3.62s	_{p=0.075 n=6}
_{Bind Time}	_{1.19s (± 0.69%)}	_{1.19s (± 0.53%)}	_~	_1.18s	_1.20s	_{p=0.432 n=6}
_{Check Time}	_{9.66s (± 0.37%)}	_{9.73s (± 0.09%)}	_{+0.06s (+ 0.64%)}	_9.71s	_9.73s	_{p=0.006 n=6}
_{Emit Time}	_{7.99s (± 0.50%)}	_{8.02s (± 0.71%)}	_~	_7.94s	_8.09s	_{p=0.170 n=6}
_{Total Time}	_{22.40s (± 0.34%)}	_{22.53s (± 0.30%)}	_{+0.13s (+ 0.58%)}	_22.43s	_22.61s	_{p=0.020 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,928k (± 0.01%)}	_{192,898k (± 0.03%)}	_~	_192,803k	_192,952k	_{p=0.471 n=6}
_{Parse Time}	_{1.60s (± 0.73%)}	_{1.59s (± 1.38%)}	_~	_1.55s	_1.61s	_{p=0.505 n=6}
_{Bind Time}	_{0.83s (± 0.76%)}	_{0.83s (± 0.62%)}	_~	_0.83s	_0.84s	_{p=0.386 n=6}
_{Check Time}	_{10.16s (± 0.21%)}	_{10.18s (± 0.32%)}	_~	_10.14s	_10.22s	_{p=0.571 n=6}
_{Emit Time}	_{3.02s (± 0.93%)}	_{3.02s (± 1.16%)}	_~	_2.96s	_3.05s	_{p=0.936 n=6}
_{Total Time}	_{15.61s (± 0.26%)}	_{15.61s (± 0.30%)}	_~	_15.55s	_15.68s	_{p=1.000 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{346,179k (± 0.01%)}	_{346,188k (± 0.01%)}	_~	_346,170k	_346,244k	_{p=0.936 n=6}
_{Parse Time}	_{2.77s (± 0.63%)}	_{2.78s (± 0.59%)}	_~	_2.75s	_2.80s	_{p=0.368 n=6}
_{Bind Time}	_{1.07s (± 0.48%)}	_{1.07s (± 0.38%)}	_~	_1.07s	_1.08s	_{p=0.595 n=6}
_{Check Time}	_{7.99s (± 0.42%)}	_{7.99s (± 0.18%)}	_~	_7.97s	_8.01s	_{p=0.936 n=6}
_{Emit Time}	_{4.44s (± 0.61%)}	_{4.46s (± 0.61%)}	_~	_4.43s	_4.50s	_{p=0.293 n=6}
_{Total Time}	_{16.27s (± 0.42%)}	_{16.30s (± 0.23%)}	_~	_16.28s	_16.38s	_{p=0.293 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{300,247k (± 0.00%)}	_{300,240k (± 0.01%)}	_~	_300,193k	_300,271k	_{p=0.810 n=6}
_{Parse Time}	_{2.20s (± 0.73%)}	_{2.21s (± 0.53%)}	_~	_2.20s	_2.23s	_{p=0.190 n=6}
_{Bind Time}	_{1.22s (± 1.24%)}	_{1.21s (± 1.32%)}	_~	_1.19s	_1.23s	_{p=0.621 n=6}
_{Check Time}	_{7.31s (± 0.44%)}	_{7.33s (± 0.32%)}	_~	_7.30s	_7.37s	_{p=0.416 n=6}
_{Emit Time}	_{4.35s (± 0.79%)}	_{4.35s (± 0.87%)}	_~	_4.29s	_4.40s	_{p=1.000 n=6}
_{Total Time}	_{15.08s (± 0.28%)}	_{15.09s (± 0.29%)}	_~	_15.04s	_15.13s	_{p=0.401 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{481,721k (± 0.01%)}	_{481,681k (± 0.01%)}	_~	_481,631k	_481,748k	_{p=0.230 n=6}
_{Parse Time}	_{3.26s (± 0.60%)}	_{3.27s (± 0.65%)}	_~	_3.25s	_3.31s	_{p=0.413 n=6}
_{Bind Time}	_{0.96s (± 0.78%)}	_{0.96s (± 0.78%)}	_~	_0.95s	_0.97s	_{p=1.000 n=6}
_{Check Time}	_{18.37s (± 0.84%)}	_{18.33s (± 0.47%)}	_~	_18.24s	_18.47s	_{p=0.630 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.58s (± 0.74%)}	_{22.55s (± 0.45%)}	_~	_22.47s	_22.74s	_{p=0.575 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{561,296k (± 0.01%)}	_{561,177k (± 0.02%)}	_{-118k (- 0.02%)}	_561,114k	_561,368k	_{p=0.045 n=6}
_{Parse Time}	_{4.01s (± 0.30%)}	_{4.03s (± 0.45%)}	_~	_4.02s	_4.06s	_{p=0.104 n=6}
_{Bind Time}	_{1.80s (± 0.45%)}	_{1.72s (± 5.41%)}	_~	_1.59s	_1.80s	_{p=0.119 n=6}
_{Check Time}	_{3.06s (± 0.41%)}	_{3.13s (± 3.37%)}	_~	_3.05s	_3.28s	_{p=0.683 n=6}
_{Emit Time}	_{0.10s (± 5.34%)}	_{0.09s (± 0.00%)}	_{🟩-0.01s (- 6.90%)}	_0.09s	_0.09s	_{p=0.025 n=6}
_{Total Time}	_{8.96s (± 0.23%)}	_{8.96s (± 0.47%)}	_~	_8.90s	_9.03s	_{p=0.569 n=6}
_{Angular - node (v14.21.3, x64)}
_{Memory used}	_{360,175k (± 0.01%)}	_{360,198k (± 0.02%)}	_~	_360,116k	_360,316k	_{p=0.575 n=6}
_{Parse Time}	_{3.74s (± 0.46%)}	_{3.74s (± 0.65%)}	_~	_3.71s	_3.77s	_{p=0.686 n=6}
_{Bind Time}	_{1.22s (± 0.42%)}	_{1.23s (± 0.45%)}	_~	_1.22s	_1.23s	_{p=0.640 n=6}
_{Check Time}	_{10.10s (± 0.41%)}	_{10.15s (± 0.34%)}	_~	_10.11s	_10.20s	_{p=0.090 n=6}
_{Emit Time}	_{8.37s (± 0.66%)}	_{8.36s (± 0.58%)}	_~	_8.31s	_8.42s	_{p=0.747 n=6}
_{Total Time}	_{23.43s (± 0.41%)}	_{23.47s (± 0.25%)}	_~	_23.39s	_23.55s	_{p=0.332 n=6}
_{Compiler-Unions - node (v14.21.3, x64)}
_{Memory used}	_{188,174k (± 0.01%)}	_{188,173k (± 0.02%)}	_~	_188,112k	_188,232k	_{p=1.000 n=6}
_{Parse Time}	_{1.62s (± 0.72%)}	_{1.62s (± 0.93%)}	_~	_1.60s	_1.64s	_{p=1.000 n=6}
_{Bind Time}	_{0.84s (± 0.61%)}	_{0.85s (± 0.61%)}	_~	_0.84s	_0.85s	_{p=0.311 n=6}
_{Check Time}	_{10.26s (± 0.52%)}	_{10.30s (± 0.45%)}	_~	_10.24s	_10.35s	_{p=0.170 n=6}
_{Emit Time}	_{3.13s (± 1.38%)}	_{3.15s (± 0.62%)}	_~	_3.12s	_3.18s	_{p=0.147 n=6}
_{Total Time}	_{15.85s (± 0.36%)}	_{15.91s (± 0.27%)}	_~	_15.85s	_15.95s	_{p=0.090 n=6}
_{Monaco - node (v14.21.3, x64)}
_{Memory used}	_{341,183k (± 0.01%)}	_{341,179k (± 0.01%)}	_~	_341,142k	_341,211k	_{p=1.000 n=6}
_{Parse Time}	_{2.81s (± 0.37%)}	_{2.82s (± 0.85%)}	_~	_2.80s	_2.86s	_{p=0.805 n=6}
_{Bind Time}	_{1.09s (± 0.75%)}	_{1.11s (± 0.95%)}	_~	_1.09s	_1.12s	_{p=0.058 n=6}
_{Check Time}	_{8.29s (± 0.41%)}	_{8.29s (± 0.42%)}	_~	_8.25s	_8.33s	_{p=1.000 n=6}
_{Emit Time}	_{4.68s (± 0.50%)}	_{4.67s (± 0.53%)}	_~	_4.64s	_4.70s	_{p=0.466 n=6}
_{Total Time}	_{16.88s (± 0.26%)}	_{16.89s (± 0.18%)}	_~	_16.87s	_16.95s	_{p=0.627 n=6}
_{TFS - node (v14.21.3, x64)}
_{Memory used}	_{295,334k (± 0.00%)}	_{295,325k (± 0.00%)}	_~	_295,314k	_295,340k	_{p=0.378 n=6}
_{Parse Time}	_{2.43s (± 0.89%)}	_{2.44s (± 0.69%)}	_~	_2.42s	_2.46s	_{p=0.684 n=6}
_{Bind Time}	_{1.08s (± 0.83%)}	_{1.08s (± 0.70%)}	_~	_1.07s	_1.09s	_{p=0.798 n=6}
_{Check Time}	_{7.61s (± 0.45%)}	_{7.65s (± 0.88%)}	_~	_7.57s	_7.76s	_{p=0.375 n=6}
_{Emit Time}	_{4.31s (± 1.20%)}	_{4.30s (± 0.70%)}	_~	_4.27s	_4.36s	_{p=0.744 n=6}
_{Total Time}	_{15.44s (± 0.37%)}	_{15.48s (± 0.54%)}	_~	_15.39s	_15.59s	_{p=0.470 n=6}
_{material-ui - node (v14.21.3, x64)}
_{Memory used}	_{477,171k (± 0.00%)}	_{477,176k (± 0.00%)}	_~	_477,157k	_477,210k	_{p=1.000 n=6}
_{Parse Time}	_{3.31s (± 0.32%)}	_{3.31s (± 0.56%)}	_~	_3.29s	_3.34s	_{p=1.000 n=6}
_{Bind Time}	_{0.99s (± 0.41%)}	_{0.99s (± 0.84%)}	_~	_0.98s	_1.00s	_{p=0.097 n=6}
_{Check Time}	_{19.18s (± 0.46%)}	_{19.15s (± 0.32%)}	_~	_19.07s	_19.23s	_{p=0.470 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{23.48s (± 0.38%)}	_{23.46s (± 0.27%)}	_~	_23.38s	_23.55s	_{p=0.872 n=6}
_{xstate - node (v14.21.3, x64)}
_{Memory used}	_{550,149k (± 0.00%)}	_{550,157k (± 0.00%)}	_~	_550,139k	_550,174k	_{p=0.471 n=6}
_{Parse Time}	_{4.23s (± 0.29%)}	_{4.25s (± 0.46%)}	_~	_4.23s	_4.28s	_{p=0.119 n=6}
_{Bind Time}	_{1.68s (± 0.38%)}	_{1.69s (± 0.61%)}	_{+0.01s (+ 0.79%)}	_1.68s	_1.71s	_{p=0.028 n=6}
_{Check Time}	_{3.13s (± 0.42%)}	_{3.13s (± 0.17%)}	_~	_3.13s	_3.14s	_{p=0.663 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{9.13s (± 0.21%)}	_{9.17s (± 0.31%)}	_~	_9.13s	_9.21s	_{p=0.052 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.21.3, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.21.3, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.21.3, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.21.3, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.21.3, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.21.3, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.21.3, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₉₉₇	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..54997

_Metric	_main	₅₄₉₉₇	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,561ms (± 0.47%)}	_{2,571ms (± 0.41%)}	_~	_2,555ms	_2,585ms	_{p=0.128 n=6}
_{Req 2 - geterr}	_{5,379ms (± 0.67%)}	_{5,392ms (± 0.40%)}	_~	_5,369ms	_5,431ms	_{p=0.810 n=6}
_{Req 3 - references}	_{346ms (± 0.86%)}	_{346ms (± 1.12%)}	_~	_341ms	_350ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{289ms (± 0.47%)}	_{290ms (± 0.29%)}	_~	_289ms	_291ms	_{p=0.170 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{75ms (± 0.54%)}	_{75ms (± 1.08%)}	_~	_75ms	_77ms	_{p=0.218 n=6}
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,636ms (± 0.39%)}	_{2,640ms (± 0.41%)}	_~	_2,631ms	_2,660ms	_{p=0.571 n=6}
_{Req 2 - geterr}	_{4,101ms (± 0.23%)}	_{4,108ms (± 0.47%)}	_~	_4,094ms	_4,134ms	_{p=0.810 n=6}
_{Req 3 - references}	_{350ms (± 0.95%)}	_{351ms (± 0.61%)}	_~	_349ms	_354ms	_{p=0.369 n=6}
_{Req 4 - navto}	_{289ms (± 0.28%)}	_{289ms (± 1.22%)}	_~	_286ms	_296ms	_{p=0.740 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{80ms (± 3.11%)}	_{81ms (± 2.44%)}	_~	_78ms	_83ms	_{p=0.519 n=6}
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,084ms (± 0.25%)}	_{3,096ms (± 0.60%)}	_~	_3,080ms	_3,129ms	_{p=0.149 n=6}
_{Req 2 - geterr}	_{1,601ms (± 0.73%)}	_{1,595ms (± 0.64%)}	_~	_1,575ms	_1,604ms	_{p=0.630 n=6}
_{Req 3 - references}	_{113ms (± 1.44%)}	_{114ms (± 1.47%)}	_~	_112ms	_116ms	_{p=0.615 n=6}
_{Req 4 - navto}	_{369ms (± 0.44%)}	_{371ms (± 0.83%)}	_~	_369ms	_377ms	_{p=0.289 n=6}
_{Req 5 - completionInfo count}	_{2,872 (± 0.00%)}	_{2,872 (± 0.00%)}	_~	_2,872	_2,872	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{377ms (± 2.35%)}	_{381ms (± 1.48%)}	_~	_372ms	_388ms	_{p=0.374 n=6}
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,641ms (± 0.34%)}	_{2,643ms (± 0.86%)}	_~	_2,614ms	_2,676ms	_{p=0.873 n=6}
_{Req 2 - geterr}	_{6,014ms (± 0.49%)}	_{6,025ms (± 0.47%)}	_~	_5,976ms	_6,055ms	_{p=0.296 n=6}
_{Req 3 - references}	_{356ms (± 1.15%)}	_{353ms (± 1.25%)}	_~	_348ms	_359ms	_{p=0.376 n=6}
_{Req 4 - navto}	_{288ms (± 0.67%)}	_{286ms (± 1.00%)}	_~	_283ms	_289ms	_{p=0.287 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{80ms (± 0.51%)}	_{88ms (± 8.96%)}	_{+8ms (+ 9.81%)}	_80ms	_102ms	_{p=0.010 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,825ms (± 0.85%)}	_{2,817ms (± 0.85%)}	_~	_2,796ms	_2,857ms	_{p=0.630 n=6}
_{Req 2 - geterr}	_{4,663ms (± 0.55%)}	_{4,668ms (± 0.56%)}	_~	_4,632ms	_4,703ms	_{p=0.873 n=6}
_{Req 3 - references}	_{363ms (± 0.32%)}	_{364ms (± 0.33%)}	_~	_362ms	_365ms	_{p=0.618 n=6}
_{Req 4 - navto}	_{279ms (± 0.90%)}	_{284ms (± 0.66%)}	_{+4ms (+ 1.55%)}	_280ms	_285ms	_{p=0.017 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{76ms (± 0.99%)}	_{76ms (± 1.18%)}	_~	_75ms	_77ms	_{p=0.798 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,233ms (± 0.56%)}	_{3,246ms (± 0.39%)}	_~	_3,224ms	_3,262ms	_{p=0.172 n=6}
_{Req 2 - geterr}	_{1,748ms (± 1.43%)}	_{1,741ms (± 0.97%)}	_~	_1,718ms	_1,759ms	_{p=0.521 n=6}
_{Req 3 - references}	_{123ms (± 1.34%)}	_{126ms (± 7.21%)}	_~	_120ms	_144ms	_{p=0.868 n=6}
_{Req 4 - navto}	_{353ms (± 1.10%)}	_{355ms (± 0.49%)}	_~	_352ms	_357ms	_{p=0.125 n=6}
_{Req 5 - completionInfo count}	_{2,872 (± 0.00%)}	_{2,872 (± 0.00%)}	_~	_2,872	_2,872	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{415ms (± 1.76%)}	_{415ms (± 0.74%)}	_~	_410ms	_418ms	_{p=0.747 n=6}
_{Compiler-UnionsTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{2,787ms (± 0.25%)}	_{2,807ms (± 0.50%)}	_{+20ms (+ 0.72%)}	_2,787ms	_2,825ms	_{p=0.030 n=6}
_{Req 2 - geterr}	_{6,165ms (± 0.75%)}	_{6,204ms (± 0.29%)}	_~	_6,182ms	_6,230ms	_{p=0.149 n=6}
_{Req 3 - references}	_{362ms (± 1.60%)}	_{364ms (± 1.19%)}	_~	_361ms	_372ms	_{p=0.288 n=6}
_{Req 4 - navto}	_{290ms (± 0.18%)}	_{294ms (± 1.24%)}	_{+4ms (+ 1.32%)}	_290ms	_300ms	_{p=0.024 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{112ms (± 0.80%)}	_{110ms (± 3.76%)}	_~	_102ms	_113ms	_{p=0.363 n=6}
_{CompilerTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{2,957ms (± 0.49%)}	_{2,964ms (± 0.46%)}	_~	_2,954ms	_2,990ms	_{p=0.575 n=6}
_{Req 2 - geterr}	_{4,566ms (± 0.24%)}	_{4,550ms (± 0.20%)}	_{-16ms (- 0.34%)}	_4,534ms	_4,560ms	_{p=0.037 n=6}
_{Req 3 - references}	_{378ms (± 0.40%)}	_{377ms (± 0.34%)}	_~	_375ms	_378ms	_{p=0.681 n=6}
_{Req 4 - navto}	_{298ms (± 0.62%)}	_{299ms (± 0.33%)}	_~	_298ms	_300ms	_{p=0.865 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{83ms (± 1.92%)}	_{84ms (± 0.62%)}	_~	_83ms	_84ms	_{p=0.923 n=6}
_{xstateTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{3,483ms (± 0.27%)}	_{3,498ms (± 0.58%)}	_~	_3,469ms	_3,521ms	_{p=0.261 n=6}
_{Req 2 - geterr}	_{1,836ms (± 0.73%)}	_{1,840ms (± 0.91%)}	_~	_1,820ms	_1,858ms	_{p=1.000 n=6}
_{Req 3 - references}	_{152ms (± 6.30%)}	_{152ms (± 7.47%)}	_~	_137ms	_161ms	_{p=0.808 n=6}
_{Req 4 - navto}	_{386ms (± 0.27%)}	_{389ms (± 1.65%)}	_~	_385ms	_402ms	_{p=0.652 n=6}
_{Req 5 - completionInfo count}	_{2,872 (± 0.00%)}	_{2,872 (± 0.00%)}	_~	_2,872	_2,872	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{440ms (± 0.74%)}	_{442ms (± 0.47%)}	_~	_440ms	_445ms	_{p=0.169 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.21.3, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.21.3, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.21.3, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.21.3, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₉₉₇	₆
_Baseline	_main	₆

Startup

Comparison Report - main..54997

_Metric	_main	₅₄₉₉₇	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{142.58ms (± 0.17%)}	_{142.86ms (± 0.17%)}	_{+0.28ms (+ 0.19%)}	_142.20ms	_145.29ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{223.55ms (± 0.45%)}	_{222.59ms (± 0.17%)}	_{-0.96ms (- 0.43%)}	_221.68ms	_228.22ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{223.81ms (± 0.23%)}	_{223.96ms (± 0.17%)}	_{+0.15ms (+ 0.07%)}	_223.07ms	_229.97ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{206.42ms (± 0.33%)}	_{205.93ms (± 0.15%)}	_{-0.49ms (- 0.24%)}	_205.01ms	_209.03ms	_{p=0.000 n=600}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₉₉₇	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

typescript-bot · 2023-07-13T00:53:31Z

@gabritto Here are the results of running the top-repos suite comparing main and refs/pull/54997/merge:

Everything looks good!

typescript-bot · 2023-07-13T01:28:08Z

Hey @gabritto, it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

typescript-bot · 2023-07-13T02:07:28Z

@gabritto Here are the results of running the top-repos suite comparing main and refs/pull/54997/merge:

Everything looks good!

andrewbranch · 2023-07-13T14:21:53Z

tests/baselines/reference/plainJSGrammarErrors.types

 >foo : () => void
 >new.targe : () => void
->targe : any
+>targe : () => void


Do I even want to know why targe works without the t? 😅

gabritto · 2023-07-13T17:21:08Z

@typescript-bot run DT

typescript-bot · 2023-07-13T17:21:11Z

Heya @gabritto, I've started to run the parallelized Definitely Typed test suite on this PR at 1e2c9ae. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-07-13T19:32:29Z

Hey @gabritto, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

gabritto added 2 commits July 12, 2023 15:02

add test

ace09cc

import.meta is right side of qualified name or property access

1e2c9ae

typescript-bot assigned gabritto Jul 12, 2023

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Jul 12, 2023

gabritto requested review from andrewbranch and jakebailey July 12, 2023 23:39

jakebailey reviewed Jul 12, 2023

View reviewed changes

andrewbranch approved these changes Jul 13, 2023

View reviewed changes

gabritto merged commit 3b6e35c into main Jul 13, 2023

gabritto deleted the gabritto/issue54590 branch July 13, 2023 20:12

microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025

Consider import.meta a qualified name/property access #54997

Consider import.meta a qualified name/property access #54997

Uh oh!

Conversation

gabritto commented Jul 12, 2023

Uh oh!

gabritto commented Jul 12, 2023

Uh oh!

typescript-bot commented Jul 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jul 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jul 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jul 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jul 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jul 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakebailey Jul 12, 2023

Choose a reason for hiding this comment

Uh oh!

gabritto Jul 12, 2023

Choose a reason for hiding this comment

Uh oh!

andrewbranch Jul 13, 2023

Choose a reason for hiding this comment

Uh oh!

DanielRosenwasser Jul 13, 2023

Choose a reason for hiding this comment

Uh oh!

typescript-bot commented Jul 12, 2023

Uh oh!

typescript-bot commented Jul 13, 2023

Compiler

TSServer

Startup

Uh oh!

typescript-bot commented Jul 13, 2023

Uh oh!

typescript-bot commented Jul 13, 2023

Uh oh!

typescript-bot commented Jul 13, 2023

Uh oh!

andrewbranch Jul 13, 2023

Choose a reason for hiding this comment

Uh oh!

gabritto commented Jul 13, 2023

Uh oh!

typescript-bot commented Jul 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jul 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Consider `import.meta` a qualified name/property access #54997

Consider `import.meta` a qualified name/property access #54997

typescript-bot commented Jul 12, 2023 •

edited

Loading

typescript-bot commented Jul 12, 2023 •

edited

Loading

typescript-bot commented Jul 12, 2023 •

edited

Loading

typescript-bot commented Jul 12, 2023 •

edited

Loading

typescript-bot commented Jul 12, 2023 •

edited

Loading

typescript-bot commented Jul 12, 2023 •

edited

Loading

typescript-bot commented Jul 13, 2023 •

edited

Loading