Add test case for intersection/constraint bug fixed in 4.9 #54972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
requested changes
Jul 13, 2023
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
The test shouldn't have unrelated errors.
| const myFirstFunction = <T extends FirstInterface | SecondInterface>(param1: T) => { | ||
| const newParam: T & { otherProperty: number } = Object.assign(param1, { otherProperty: 3 }) | ||
| ~~~~~~ | ||
| !!! error TS2550: Property 'assign' does not exist on type 'ObjectConstructor'. Do you need to change your target library? Try changing the 'lib' compiler option to 'es2015' or later. |
Member
There was a problem hiding this comment.
it would be nice to have 0 errors by switching to es2015 or higher, or else by moving newParam to being a parameter so it doesn't have an initialiser.
sandersn
approved these changes
Jul 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24688