Fix incorrect 'this' substitution in decorated static 'accessor' fields #54474
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue occurs because substitution assumes a
thisin a staticPropertyDeclarationcan only occur in an initializer, and part of performing this check includes looking at theoriginalnode for the declaration containing thethis. However, anaccessoris also transformed into aget/setpair that containsthis, and those generatedgetandsetmethods will also have theiroriginalnode set to the samePropertyDeclarationas the initializer, which results in overzealous substitution.This PR changes the behavior to prevent substitution of the
thiskeyword in the generated calls to__classPrivateFieldGetand__classPrivateFieldSetin the generatedgetandsetmethods.Fixes #54473