runtests-watch: Don't try to listen for SIGKILL #54114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not possible (because a SIGKILL ends the process immediately, before the process can do anything to respond to it), and in current versions of Node attempting to will throw `Error: uv_signal_start EINVAL`. Thus, removing this "listener" removes no actual functionality; it only stops the task from immediately erroring on newer versions of Node. See also: https://stackoverflow.com/questions/16311347/node-script-throws-uv-signal-start-einval
typescript-bot
added
the
For Uncommitted Bug
Member
|
@rbuckton Do you know if this handler is still needed? I suspect it isn't, but I'm trying to think as to whether or not this is needed for Windows or something. |
Contributor
The specific handler being removed? Probably not. |
Member
|
Thanks. I think I'll just merge this; I think that if it's crashing, that's not good, and this mode is somewhat experimental, but SIGKILL definitely can't be listened to. |
jakebailey
approved these changes
May 3, 2023
Contributor
Author
|
Thanks, all! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not possible (because a SIGKILL ends the process immediately, before the process can do anything to respond to it), and in current versions of Node attempting to will throw
Error: uv_signal_start EINVAL. Thus, removing this "listener" removes no actual functionality; it only stops the task from immediately erroring on newer versions of Node.See also: https://stackoverflow.com/questions/16311347/node-script-throws-uv-signal-start-einval
Fixes #54113
(I've ignored a bunch of PR process that didn't seem to apply to a tooling fix like this, but please let me know if there's anything I should do differently.)