Skip to content

Revert "Defer type comparability check for assertions" #53879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "Defer type comparability check for assertions" #53879

wants to merge 1 commit into from

Conversation

DanielRosenwasser
Copy link
Member

Do not merge - experiment to revert #53261

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 17, 2023
@DanielRosenwasser
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 17, 2023 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at dd00a34. You can monitor the build here.

Update: The results are in!

@armanio123
Copy link
Contributor

@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 17, 2023 •
edited
Loading

Heya @armanio123, I've started to run the diff-based user code test suite on this PR at dd00a34. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@armanio123 Here are the results of running the user test suite comparing main and refs/pull/53879/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Package install failed"

Otherwise...

Everything looks good!

@typescript-bot
Copy link
Collaborator

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..53879
Metric main 53879 Delta Best Worst p-value
Angular - node (v18.10.0, x64)
Memory used 365,166k (± 0.01%) 365,176k (± 0.01%) ~ 365,149k 365,210k p=0.575 n=6
Parse Time 3.36s (± 0.88%) 3.37s (± 0.55%) ~ 3.34s 3.39s p=0.569 n=6
Bind Time 1.12s (± 0.46%) 1.12s (± 0.46%) ~ 1.11s 1.12s p=1.000 n=6
Check Time 8.70s (± 0.50%) 8.69s (± 0.55%) ~ 8.64s 8.78s p=0.810 n=6
Emit Time 7.43s (± 0.75%) 7.45s (± 0.91%) ~ 7.40s 7.58s p=1.000 n=6
Total Time 20.61s (± 0.59%) 20.62s (± 0.39%) ~ 20.54s 20.77s p=1.000 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used 191,847k (± 1.18%) 191,805k (± 1.18%) ~ 190,778k 196,414k p=0.689 n=6
Parse Time 1.50s (± 0.56%) 1.51s (± 0.97%) ~ 1.49s 1.53s p=0.094 n=6
Bind Time 0.78s (± 0.71%) 0.77s (± 1.05%) ~ 0.76s 0.78s p=0.859 n=6
Check Time 9.56s (± 0.40%) 9.42s (± 0.38%) -0.14s (- 1.50%) 9.38s 9.47s p=0.005 n=6
Emit Time 2.72s (± 0.50%) 2.73s (± 0.85%) ~ 2.70s 2.76s p=0.512 n=6
Total Time 14.55s (± 0.23%) 14.43s (± 0.29%) -0.13s (- 0.86%) 14.39s 14.50s p=0.006 n=6
Monaco - node (v18.10.0, x64)
Memory used 346,470k (± 0.01%) 346,378k (± 0.01%) -92k (- 0.03%) 346,331k 346,459k p=0.013 n=6
Parse Time 2.59s (± 0.94%) 2.58s (± 0.72%) ~ 2.56s 2.60s p=0.804 n=6
Bind Time 1.01s (± 1.75%) 1.00s (± 0.81%) ~ 1.00s 1.02s p=0.753 n=6
Check Time 7.13s (± 0.60%) 7.08s (± 0.29%) ~ 7.06s 7.11s p=0.052 n=6
Emit Time 4.23s (± 0.70%) 4.23s (± 0.93%) ~ 4.19s 4.29s p=1.000 n=6
Total Time 14.95s (± 0.38%) 14.90s (± 0.22%) ~ 14.86s 14.95s p=0.171 n=6
TFS - node (v18.10.0, x64)
Memory used 300,719k (± 0.01%) 300,485k (± 0.01%) -233k (- 0.08%) 300,462k 300,521k p=0.005 n=6
Parse Time 2.05s (± 0.86%) 2.06s (± 1.52%) ~ 2.02s 2.11s p=0.746 n=6
Bind Time 1.14s (± 0.45%) 1.14s (± 1.06%) ~ 1.13s 1.16s p=1.000 n=6
Check Time 6.55s (± 1.02%) 6.49s (± 0.44%) ~ 6.46s 6.54s p=0.075 n=6
Emit Time 3.88s (± 0.68%) 3.89s (± 0.54%) ~ 3.86s 3.91s p=0.460 n=6
Total Time 13.62s (± 0.61%) 13.59s (± 0.59%) ~ 13.51s 13.70s p=0.575 n=6
material-ui - node (v18.10.0, x64)
Memory used 481,860k (± 0.01%) 481,846k (± 0.01%) ~ 481,815k 481,894k p=0.689 n=6
Parse Time 3.08s (± 0.61%) 3.10s (± 1.01%) ~ 3.06s 3.15s p=0.225 n=6
Bind Time 0.90s (± 0.83%) 0.90s (± 0.92%) ~ 0.90s 0.92s p=0.652 n=6
Check Time 16.77s (± 0.68%) 16.80s (± 0.43%) ~ 16.73s 16.89s p=0.377 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 20.76s (± 0.47%) 20.81s (± 0.42%) ~ 20.69s 20.91s p=0.336 n=6
xstate - node (v18.10.0, x64)
Memory used 561,887k (± 0.02%) 561,696k (± 0.01%) -191k (- 0.03%) 561,595k 561,801k p=0.045 n=6
Parse Time 3.83s (± 0.62%) 3.84s (± 0.77%) ~ 3.79s 3.88s p=0.809 n=6
Bind Time 1.67s (± 0.31%) 1.66s (± 0.59%) ~ 1.65s 1.67s p=0.140 n=6
Check Time 2.82s (± 0.70%) 2.77s (± 1.05%) -0.04s (- 1.60%) 2.74s 2.81s p=0.029 n=6
Emit Time 0.08s (± 0.00%) 0.08s (± 0.00%) ~ 0.08s 0.08s p=1.000 n=6
Total Time 8.39s (± 0.39%) 8.35s (± 0.60%) ~ 8.28s 8.40s p=0.336 n=6
Angular - node (v16.17.1, x64)
Memory used 364,629k (± 0.01%) 364,623k (± 0.01%) ~ 364,567k 364,654k p=0.936 n=6
Parse Time 3.52s (± 0.39%) 3.53s (± 0.55%) ~ 3.50s 3.55s p=0.681 n=6
Bind Time 1.19s (± 0.43%) 1.18s (± 0.00%) -0.01s (- 0.56%) 1.18s 1.18s p=0.025 n=6
Check Time 9.53s (± 0.70%) 9.50s (± 0.28%) ~ 9.46s 9.54s p=0.468 n=6
Emit Time 7.95s (± 1.26%) 7.89s (± 0.47%) ~ 7.84s 7.95s p=0.261 n=6
Total Time 22.19s (± 0.60%) 22.10s (± 0.14%) ~ 22.06s 22.14s p=0.108 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 192,593k (± 0.02%) 192,594k (± 0.04%) ~ 192,451k 192,688k p=0.936 n=6
Parse Time 1.59s (± 1.04%) 1.59s (± 1.40%) ~ 1.55s 1.61s p=0.366 n=6
Bind Time 0.82s (± 0.00%) 0.83s (± 1.01%) ~ 0.82s 0.84s p=0.176 n=6
Check Time 10.22s (± 0.43%) 10.03s (± 0.79%) -0.19s (- 1.86%) 9.93s 10.13s p=0.005 n=6
Emit Time 2.99s (± 1.05%) 2.99s (± 0.49%) ~ 2.96s 3.00s p=0.934 n=6
Total Time 15.62s (± 0.35%) 15.44s (± 0.51%) -0.18s (- 1.17%) 15.36s 15.56s p=0.008 n=6
Monaco - node (v16.17.1, x64)
Memory used 345,777k (± 0.01%) 345,626k (± 0.01%) -151k (- 0.04%) 345,597k 345,707k p=0.005 n=6
Parse Time 2.72s (± 0.70%) 2.73s (± 0.45%) ~ 2.72s 2.75s p=0.157 n=6
Bind Time 1.08s (± 0.70%) 1.09s (± 0.58%) ~ 1.08s 1.10s p=0.081 n=6
Check Time 7.82s (± 0.46%) 7.76s (± 0.70%) -0.07s (- 0.87%) 7.68s 7.82s p=0.037 n=6
Emit Time 4.42s (± 0.56%) 4.44s (± 0.72%) ~ 4.39s 4.47s p=0.416 n=6
Total Time 16.05s (± 0.33%) 16.02s (± 0.28%) ~ 15.97s 16.08s p=0.423 n=6
TFS - node (v16.17.1, x64)
Memory used 300,065k (± 0.01%) 299,825k (± 0.01%) -240k (- 0.08%) 299,789k 299,880k p=0.005 n=6
Parse Time 2.14s (± 0.19%) 2.16s (± 0.63%) +0.02s (+ 1.01%) 2.14s 2.18s p=0.016 n=6
Bind Time 1.24s (± 0.83%) 1.24s (± 0.85%) ~ 1.22s 1.25s p=0.241 n=6
Check Time 7.21s (± 0.53%) 7.15s (± 0.45%) ~ 7.12s 7.19s p=0.052 n=6
Emit Time 4.36s (± 0.51%) 4.38s (± 0.67%) ~ 4.33s 4.42s p=0.462 n=6
Total Time 14.95s (± 0.29%) 14.92s (± 0.38%) ~ 14.87s 15.01s p=0.199 n=6
material-ui - node (v16.17.1, x64)
Memory used 481,123k (± 0.01%) 481,111k (± 0.02%) ~ 481,065k 481,261k p=0.689 n=6
Parse Time 3.24s (± 0.52%) 3.26s (± 0.68%) ~ 3.23s 3.30s p=0.139 n=6
Bind Time 0.95s (± 0.43%) 0.95s (± 0.54%) ~ 0.95s 0.96s p=0.595 n=6
Check Time 17.83s (± 0.22%) 17.82s (± 0.79%) ~ 17.65s 18.03s p=0.873 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.02s (± 0.17%) 22.04s (± 0.64%) ~ 21.87s 22.26s p=0.936 n=6
xstate - node (v16.17.1, x64)
Memory used 559,477k (± 0.03%) 559,387k (± 0.01%) ~ 559,271k 559,504k p=0.298 n=6
Parse Time 3.99s (± 0.35%) 4.00s (± 0.29%) ~ 3.99s 4.02s p=0.105 n=6
Bind Time 1.77s (± 0.59%) 1.78s (± 0.61%) ~ 1.77s 1.80s p=0.554 n=6
Check Time 3.03s (± 0.75%) 2.99s (± 0.46%) -0.03s (- 0.99%) 2.97s 3.01s p=0.004 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 4.62%) ~ 0.08s 0.09s p=0.405 n=6
Total Time 8.88s (± 0.36%) 8.87s (± 0.33%) ~ 8.83s 8.92s p=0.374 n=6
Angular - node (v14.21.3, x64)
Memory used 358,569k (± 0.01%) 358,587k (± 0.01%) ~ 358,565k 358,637k p=0.378 n=6
Parse Time 3.64s (± 0.57%) 3.65s (± 0.45%) ~ 3.62s 3.67s p=0.565 n=6
Bind Time 1.22s (± 0.96%) 1.22s (± 0.80%) ~ 1.21s 1.23s p=1.000 n=6
Check Time 9.91s (± 0.22%) 10.00s (± 0.35%) +0.09s (+ 0.93%) 9.96s 10.05s p=0.005 n=6
Emit Time 8.22s (± 0.85%) 8.37s (± 0.63%) +0.15s (+ 1.76%) 8.30s 8.44s p=0.013 n=6
Total Time 23.00s (± 0.38%) 23.24s (± 0.27%) +0.24s (+ 1.05%) 23.16s 23.31s p=0.005 n=6
Compiler-Unions - node (v14.21.3, x64)
Memory used 187,690k (± 0.01%) 187,629k (± 0.02%) -61k (- 0.03%) 187,560k 187,690k p=0.020 n=6
Parse Time 1.60s (± 0.47%) 1.60s (± 0.68%) ~ 1.59s 1.62s p=1.000 n=6
Bind Time 0.84s (± 0.65%) 0.85s (± 0.65%) ~ 0.84s 0.85s p=1.000 n=6
Check Time 10.30s (± 0.50%) 10.10s (± 0.30%) -0.20s (- 1.99%) 10.05s 10.13s p=0.005 n=6
Emit Time 3.44s (± 1.18%) 3.46s (± 0.80%) ~ 3.43s 3.49s p=0.464 n=6
Total Time 16.19s (± 0.50%) 16.01s (± 0.21%) -0.18s (- 1.14%) 15.95s 16.05s p=0.008 n=6
Monaco - node (v14.21.3, x64)
Memory used 340,829k (± 0.00%) 340,794k (± 0.01%) -35k (- 0.01%) 340,750k 340,816k p=0.008 n=6
Parse Time 2.81s (± 1.30%) 2.80s (± 0.59%) ~ 2.78s 2.83s p=0.625 n=6
Bind Time 1.12s (± 0.75%) 1.11s (± 0.88%) ~ 1.10s 1.13s p=0.445 n=6
Check Time 8.15s (± 0.26%) 8.12s (± 0.39%) ~ 8.09s 8.18s p=0.052 n=6
Emit Time 4.67s (± 1.07%) 4.67s (± 1.15%) ~ 4.62s 4.74s p=0.936 n=6
Total Time 16.74s (± 0.36%) 16.70s (± 0.52%) ~ 16.59s 16.84s p=0.295 n=6
TFS - node (v14.21.3, x64)
Memory used 295,226k (± 0.00%) 295,034k (± 0.01%) -193k (- 0.07%) 295,006k 295,053k p=0.005 n=6
Parse Time 2.40s (± 0.78%) 2.39s (± 0.98%) ~ 2.36s 2.42s p=1.000 n=6
Bind Time 1.07s (± 0.48%) 1.07s (± 0.38%) ~ 1.06s 1.07s p=0.595 n=6
Check Time 7.52s (± 0.63%) 7.56s (± 0.83%) ~ 7.49s 7.64s p=0.335 n=6
Emit Time 4.31s (± 0.50%) 4.29s (± 0.45%) ~ 4.27s 4.32s p=0.256 n=6
Total Time 15.28s (± 0.38%) 15.31s (± 0.50%) ~ 15.21s 15.40s p=0.629 n=6
material-ui - node (v14.21.3, x64)
Memory used 476,757k (± 0.00%) 476,728k (± 0.00%) -29k (- 0.01%) 476,704k 476,741k p=0.031 n=6
Parse Time 3.32s (± 0.33%) 3.32s (± 0.30%) ~ 3.31s 3.34s p=0.718 n=6
Bind Time 0.99s (± 0.41%) 0.99s (± 0.76%) ~ 0.98s 1.00s p=0.389 n=6
Check Time 18.76s (± 0.63%) 18.67s (± 0.60%) ~ 18.52s 18.86s p=0.199 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 23.07s (± 0.48%) 22.98s (± 0.49%) ~ 22.84s 23.18s p=0.128 n=6
xstate - node (v14.21.3, x64)
Memory used 548,399k (± 0.00%) 548,435k (± 0.00%) +37k (+ 0.01%) 548,410k 548,463k p=0.016 n=6
Parse Time 4.21s (± 0.61%) 4.22s (± 0.41%) ~ 4.19s 4.24s p=1.000 n=6
Bind Time 1.67s (± 0.49%) 1.68s (± 0.31%) ~ 1.67s 1.68s p=0.523 n=6
Check Time 3.17s (± 0.95%) 3.14s (± 0.69%) ~ 3.11s 3.17s p=0.086 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 9.14s (± 0.59%) 9.12s (± 0.33%) ~ 9.08s 9.16s p=0.377 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.21.3, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.21.3, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.21.3, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.21.3, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.21.3, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.21.3, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.21.3, x64)
Benchmark Name Iterations
Current 53879 6
Baseline main 6

TSServer

Comparison Report - main..53879
Metric main 53879 Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,403ms (± 0.30%) 2,420ms (± 0.78%) +17ms (+ 0.71%) 2,403ms 2,456ms p=0.037 n=6
Req 2 - geterr 5,662ms (± 0.36%) 5,510ms (± 1.15%) -152ms (- 2.68%) 5,382ms 5,548ms p=0.005 n=6
Req 3 - references 338ms (± 0.49%) 338ms (± 0.41%) ~ 335ms 339ms p=0.869 n=6
Req 4 - navto 285ms (± 0.34%) 289ms (± 1.66%) ~ 283ms 294ms p=0.134 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 85ms (± 0.61%) 83ms (± 5.07%) ~ 74ms 85ms p=0.091 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,515ms (± 0.40%) 2,529ms (± 0.66%) ~ 2,510ms 2,554ms p=0.109 n=6
Req 2 - geterr 4,269ms (± 0.37%) 4,197ms (± 0.37%) -72ms (- 1.68%) 4,178ms 4,217ms p=0.005 n=6
Req 3 - references 347ms (± 0.80%) 344ms (± 0.87%) ~ 341ms 348ms p=0.148 n=6
Req 4 - navto 289ms (± 0.67%) 293ms (± 0.77%) +4ms (+ 1.27%) 291ms 297ms p=0.022 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 64ms (± 5.41%) 66ms (± 5.35%) ~ 63ms 70ms p=0.230 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,037ms (± 0.52%) 3,046ms (± 0.38%) ~ 3,028ms 3,057ms p=0.298 n=6
Req 2 - geterr 1,610ms (± 0.49%) 1,511ms (± 0.77%) 🟩-100ms (- 6.18%) 1,488ms 1,518ms p=0.005 n=6
Req 3 - references 107ms (± 1.24%) 113ms (± 1.03%) +6ms (+ 5.93%) 112ms 115ms p=0.005 n=6
Req 4 - navto 362ms (± 0.51%) 360ms (± 0.51%) ~ 359ms 363ms p=0.180 n=6
Req 5 - completionInfo count 2,862 (± 0.00%) 2,862 (± 0.00%) ~ 2,862 2,862 p=1.000 n=6
Req 5 - completionInfo 371ms (± 1.45%) 375ms (± 2.29%) ~ 359ms 383ms p=0.261 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,529ms (± 0.54%) 2,518ms (± 0.67%) ~ 2,499ms 2,541ms p=0.261 n=6
Req 2 - geterr 6,067ms (± 0.42%) 6,002ms (± 0.83%) -65ms (- 1.07%) 5,954ms 6,067ms p=0.045 n=6
Req 3 - references 352ms (± 0.60%) 355ms (± 0.86%) +3ms (+ 0.90%) 352ms 361ms p=0.042 n=6
Req 4 - navto 284ms (± 0.77%) 289ms (± 0.57%) +5ms (+ 1.64%) 287ms 291ms p=0.008 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 88ms (± 5.52%) 72ms (± 0.88%) 🟩-16ms (-18.49%) 71ms 73ms p=0.004 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,696ms (± 0.61%) 2,674ms (± 0.26%) -22ms (- 0.81%) 2,662ms 2,681ms p=0.013 n=6
Req 2 - geterr 4,624ms (± 0.49%) 4,556ms (± 0.39%) -68ms (- 1.46%) 4,530ms 4,577ms p=0.005 n=6
Req 3 - references 361ms (± 0.62%) 361ms (± 0.72%) ~ 357ms 364ms p=0.571 n=6
Req 4 - navto 283ms (± 0.43%) 285ms (± 0.78%) ~ 281ms 287ms p=0.089 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 68ms (± 0.00%) 67ms (± 1.63%) -1ms (- 1.47%) 66ms 69ms p=0.047 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,164ms (± 0.40%) 3,162ms (± 0.68%) ~ 3,133ms 3,193ms p=0.810 n=6
Req 2 - geterr 1,764ms (± 1.13%) 1,690ms (± 1.34%) 🟩-75ms (- 4.22%) 1,653ms 1,712ms p=0.005 n=6
Req 3 - references 119ms (± 1.68%) 121ms (± 1.14%) ~ 119ms 123ms p=0.139 n=6
Req 4 - navto 341ms (± 0.68%) 341ms (± 0.71%) ~ 339ms 346ms p=1.000 n=6
Req 5 - completionInfo count 2,862 (± 0.00%) 2,862 (± 0.00%) ~ 2,862 2,862 p=1.000 n=6
Req 5 - completionInfo 394ms (± 0.86%) 407ms (± 0.46%) +13ms (+ 3.17%) 404ms 409ms p=0.005 n=6
Compiler-UnionsTSServer - node (v14.21.3, x64)
Req 1 - updateOpen 2,619ms (± 0.45%) 2,627ms (± 0.51%) ~ 2,614ms 2,653ms p=0.295 n=6
Req 2 - geterr 6,253ms (± 0.42%) 6,151ms (± 0.49%) -102ms (- 1.64%) 6,100ms 6,181ms p=0.005 n=6
Req 3 - references 362ms (± 0.83%) 367ms (± 0.58%) +5ms (+ 1.48%) 365ms 370ms p=0.009 n=6
Req 4 - navto 286ms (± 1.14%) 281ms (± 0.27%) -6ms (- 1.92%) 280ms 282ms p=0.006 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 98ms (± 5.65%) 104ms (± 0.72%) +6ms (+ 6.13%) 103ms 105ms p=0.007 n=6
CompilerTSServer - node (v14.21.3, x64)
Req 1 - updateOpen 2,783ms (± 0.85%) 2,784ms (± 0.57%) ~ 2,769ms 2,809ms p=0.748 n=6
Req 2 - geterr 4,519ms (± 0.39%) 4,464ms (± 0.28%) -56ms (- 1.23%) 4,447ms 4,480ms p=0.005 n=6
Req 3 - references 372ms (± 0.45%) 381ms (± 0.48%) +9ms (+ 2.37%) 379ms 384ms p=0.004 n=6
Req 4 - navto 298ms (± 0.25%) 300ms (± 0.54%) +2ms (+ 0.62%) 298ms 302ms p=0.046 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 76ms (± 1.58%) 77ms (± 1.05%) ~ 76ms 78ms p=0.157 n=6
xstateTSServer - node (v14.21.3, x64)
Req 1 - updateOpen 3,399ms (± 1.18%) 3,406ms (± 1.17%) ~ 3,349ms 3,443ms p=0.748 n=6
Req 2 - geterr 1,868ms (± 1.41%) 1,858ms (± 1.16%) ~ 1,818ms 1,882ms p=0.378 n=6
Req 3 - references 128ms (± 2.70%) 130ms (± 0.90%) ~ 128ms 131ms p=0.368 n=6
Req 4 - navto 396ms (± 0.64%) 392ms (± 1.40%) ~ 386ms 401ms p=0.158 n=6
Req 5 - completionInfo count 2,862 (± 0.00%) 2,862 (± 0.00%) ~ 2,862 2,862 p=1.000 n=6
Req 5 - completionInfo 425ms (± 3.08%) 429ms (± 1.89%) ~ 416ms 436ms p=0.520 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.21.3, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.21.3, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.21.3, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.21.3, x64)
Benchmark Name Iterations
Current 53879 6
Baseline main 6

Startup

Comparison Report - main..53879
Metric main 53879 Delta Best Worst p-value
tsc-startup - node (v16.17.1, x64)
Execution time 141.51ms (± 0.17%) 142.37ms (± 0.20%) +0.86ms (+ 0.60%) 141.43ms 145.81ms p=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time 219.81ms (± 0.17%) 221.25ms (± 0.23%) +1.44ms (+ 0.65%) 219.91ms 226.94ms p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 221.86ms (± 0.23%) 222.15ms (± 0.17%) +0.29ms (+ 0.13%) 221.35ms 229.40ms p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time 203.41ms (± 0.21%) 204.32ms (± 0.21%) +0.91ms (+ 0.44%) 203.19ms 210.43ms p=0.000 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 53879 6
Baseline main 6

Developer Information:

Download Benchmark

@DanielRosenwasser DanielRosenwasser mentioned this pull request May 12, 2023
Closed
@DanielRosenwasser
Copy link
Member Author

Closing in favor of #54224

@DanielRosenwasser DanielRosenwasser deleted the revert-53261-gabritto/issue52813 branch October 2, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@DanielRosenwasser DanielRosenwasser

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielRosenwasser @typescript-bot @armanio123