Filtered out types from import suggestions in JS files #53619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
commented
Apr 1, 2023
Co-authored-by: Ryan Cavanaugh <[email protected]>
Andarist
reviewed
Apr 7, 2023
Andarist
reviewed
Apr 8, 2023
JoshuaKGoldberg
force-pushed
the
no-types-in-esm-imports
branch
from
1a16619 to
dd9ff9b
Compare
JoshuaKGoldberg
commented
Apr 13, 2023
JoshuaKGoldberg
commented
Apr 13, 2023
Andarist
reviewed
Apr 17, 2023
sandersn
requested changes
Oct 20, 2023
sandersn
requested changes
Oct 26, 2023
sandersn
approved these changes
Nov 16, 2023
This was referenced Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in a JS file (with the exception of JSDoc type imports), type-only declarations (interfaces and type aliases) are filtered out of completion entries.
Fixes #53339
Co-authored-by: Mateusz Burzyński [email protected]