perf: ensure compiler options affecting semantic diagnostics get included in build info #53423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uded in build info
typescript-bot
added
the
For Uncommitted Bug
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
sheetalkamat
requested changes
Mar 21, 2023
src/compiler/builder.ts
Outdated
| const optionInfo = optionsNameMap.get(name.toLowerCase()); | ||
| if (optionInfo?.affectsBuildInfo) { | ||
| // all semantic diagnostics affect build info | ||
| if (optionInfo && (optionInfo.affectsBuildInfo || optionInfo.affectsSemanticDiagnostics)) { |
Member
There was a problem hiding this comment.
Lets not change this. You can assert instead that if option.affectsBuildInfo is not true then affectsSemanticDiagnostics is not true either
Contributor
Author
There was a problem hiding this comment.
Reverted and moved this to an assertion in a unit test.
dsherret
requested review from
sheetalkamat
and removed request for
andrewbranch
Contributor
Author
|
(Side note: The removal of Andrew as a reviewer was unintentional. I'm not sure if GH automatically did that) |
sheetalkamat
approved these changes
Mar 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
--allowImportingTsExtensionsit was never using the build info because it wouldn't store "allowImportingTsExtensions" in the buildinfo file.I'm not sure how to write a test for this as it doesn't seem easily unit testable. Some guidance would be helpful if you'd like a test.