More complete check in isConstTypeVariable #53341

ahejlsberg · 2023-03-18T15:36:16Z

This PR improves the logic introduced in #51865 for determining whether a contextual type implies a const context. With this PR, a contextual type implies a const context when the type is

a type parameter that includes a const modifier,
a union type with at least one constituent type that implies a const context,
an indexed access type T[K] where T implies a const context,
a conditional type A extends B ? X : Y where X or Y imply a const context, or
a tuple type containing at least one variadic element ...T where T implies a const context.

Fixes #53307.

ahejlsberg · 2023-03-18T15:37:15Z

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster
@typescript-bot test top100

typescript-bot · 2023-03-18T15:37:18Z

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at 9eb3d5a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-18T15:37:18Z

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 9eb3d5a. You can monitor the build here.

typescript-bot · 2023-03-18T15:37:18Z

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at 9eb3d5a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-18T15:37:18Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 9eb3d5a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-18T15:37:18Z

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at 9eb3d5a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-18T15:50:46Z

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/53341/merge:

Everything looks good!

typescript-bot · 2023-03-18T15:52:29Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53341

_Metric	_main	₅₃₃₄₁	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{360,896k (± 0.01%)}	_{360,891k (± 0.01%)}	_~	_360,856k	_360,922k	_{p=0.936 n=6}
_{Parse Time}	_{3.52s (± 0.69%)}	_{3.53s (± 0.90%)}	_~	_3.48s	_3.57s	_{p=0.871 n=6}
_{Bind Time}	_{1.18s (± 0.69%)}	_{1.18s (± 0.44%)}	_~	_1.18s	_1.19s	_{p=0.929 n=6}
_{Check Time}	_{9.46s (± 0.52%)}	_{9.47s (± 0.53%)}	_~	_9.42s	_9.56s	_{p=0.746 n=6}
_{Emit Time}	_{7.93s (± 0.68%)}	_{7.89s (± 0.41%)}	_~	_7.84s	_7.92s	_{p=0.195 n=6}
_{Total Time}	_{22.10s (± 0.38%)}	_{22.07s (± 0.44%)}	_~	_21.97s	_22.23s	_{p=0.630 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,531k (± 0.04%)}	_{192,548k (± 0.03%)}	_~	_192,460k	_192,633k	_{p=0.810 n=6}
_{Parse Time}	_{1.57s (± 1.64%)}	_{1.58s (± 0.93%)}	_~	_1.56s	_1.60s	_{p=0.870 n=6}
_{Bind Time}	_{0.82s (± 0.77%)}	_{0.82s (± 0.50%)}	_~	_0.81s	_0.82s	_{p=0.673 n=6}
_{Check Time}	_{10.08s (± 0.62%)}	_{10.05s (± 0.68%)}	_~	_10.01s	_10.19s	_{p=0.574 n=6}
_{Emit Time}	_{2.99s (± 0.63%)}	_{2.98s (± 0.68%)}	_~	_2.95s	_3.01s	_{p=0.411 n=6}
_{Total Time}	_{15.47s (± 0.30%)}	_{15.43s (± 0.48%)}	_~	_15.38s	_15.58s	_{p=0.127 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,434k (± 0.01%)}	_{345,439k (± 0.01%)}	_~	_345,412k	_345,485k	_{p=1.000 n=6}
_{Parse Time}	_{2.72s (± 0.36%)}	_{2.72s (± 0.36%)}	_~	_2.71s	_2.74s	_{p=1.000 n=6}
_{Bind Time}	_{1.09s (± 0.50%)}	_{1.08s (± 0.97%)}	_~	_1.07s	_1.10s	_{p=1.000 n=6}
_{Check Time}	_{7.66s (± 0.32%)}	_{7.66s (± 0.48%)}	_~	_7.62s	_7.72s	_{p=0.872 n=6}
_{Emit Time}	_{4.42s (± 0.57%)}	_{4.43s (± 0.67%)}	_~	_4.40s	_4.48s	_{p=0.627 n=6}
_{Total Time}	_{15.89s (± 0.19%)}	_{15.90s (± 0.44%)}	_~	_15.82s	_16.03s	_{p=0.624 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,792k (± 0.01%)}	_{299,789k (± 0.01%)}	_~	_299,738k	_299,852k	_{p=0.748 n=6}
_{Parse Time}	_{2.17s (± 0.48%)}	_{2.17s (± 0.48%)}	_~	_2.16s	_2.19s	_{p=0.160 n=6}
_{Bind Time}	_{1.24s (± 0.88%)}	_{1.24s (± 0.97%)}	_~	_1.23s	_1.26s	_{p=0.739 n=6}
_{Check Time}	_{7.17s (± 0.57%)}	_{7.18s (± 0.30%)}	_~	_7.15s	_7.21s	_{p=0.872 n=6}
_{Emit Time}	_{4.31s (± 0.70%)}	_{4.36s (± 0.45%)}	_{+0.05s (+ 1.16%)}	_4.32s	_4.37s	_{p=0.019 n=6}
_{Total Time}	_{14.88s (± 0.33%)}	_{14.95s (± 0.23%)}	_{+0.07s (+ 0.50%)}	_14.89s	_14.99s	_{p=0.029 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{477,460k (± 0.02%)}	_{477,484k (± 0.01%)}	_~	_477,419k	_477,560k	_{p=0.688 n=6}
_{Parse Time}	_{3.21s (± 0.36%)}	_{3.23s (± 0.41%)}	_~	_3.21s	_3.24s	_{p=0.077 n=6}
_{Bind Time}	_{0.95s (± 0.54%)}	_{0.96s (± 0.54%)}	_~	_0.95s	_0.96s	_{p=0.311 n=6}
_{Check Time}	_{17.96s (± 0.49%)}	_{17.97s (± 0.51%)}	_~	_17.87s	_18.11s	_{p=0.873 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.12s (± 0.45%)}	_{22.16s (± 0.43%)}	_~	_22.04s	_22.30s	_{p=0.521 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{550,802k (± 0.02%)}	_{550,748k (± 0.02%)}	_~	_550,639k	_550,966k	_{p=0.378 n=6}
_{Parse Time}	_{3.94s (± 0.35%)}	_{3.94s (± 0.58%)}	_~	_3.90s	_3.97s	_{p=0.517 n=6}
_{Bind Time}	_{1.80s (± 0.30%)}	_{1.79s (± 0.77%)}	_~	_1.76s	_1.80s	_{p=0.138 n=6}
_{Check Time}	_{3.03s (± 0.39%)}	_{3.03s (± 0.88%)}	_~	_3.00s	_3.07s	_{p=1.000 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.86s (± 0.27%)}	_{8.85s (± 0.25%)}	_~	_8.82s	_8.88s	_{p=0.746 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₃₄₁	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

typescript-bot · 2023-03-18T17:12:11Z

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/53341/merge:

Everything looks good!

typescript-bot · 2023-03-18T17:28:45Z

Hey @ahejlsberg, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

ahejlsberg · 2023-03-21T14:59:09Z

Tests and performance all look good.

sandersn · 2023-03-27T18:33:12Z

@ahejlsberg Is this ready to merge now?

ahejlsberg added 2 commits March 18, 2023 08:22

More complete check in isConstTypeVariable

30d044e

Add tests

9eb3d5a

typescript-bot assigned ahejlsberg Mar 18, 2023

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Mar 18, 2023

ahejlsberg requested review from DanielRosenwasser and RyanCavanaugh March 21, 2023 14:59

weswigham approved these changes Mar 24, 2023

View reviewed changes

ahejlsberg merged commit 3f675b6 into main Apr 1, 2023

ahejlsberg deleted the fix53307 branch April 1, 2023 21:45

arcanis mentioned this pull request Jun 12, 2023

isConstTypeVariable stack overflow #54610

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

More complete check in isConstTypeVariable #53341

More complete check in isConstTypeVariable #53341

Uh oh!

ahejlsberg commented Mar 18, 2023 •

edited

Loading

Uh oh!

ahejlsberg commented Mar 18, 2023

Uh oh!

typescript-bot commented Mar 18, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Mar 18, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Mar 18, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Mar 18, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Mar 18, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Mar 18, 2023

Uh oh!

typescript-bot commented Mar 18, 2023

Uh oh!

typescript-bot commented Mar 18, 2023

Uh oh!

typescript-bot commented Mar 18, 2023

Uh oh!

ahejlsberg commented Mar 21, 2023

Uh oh!

sandersn commented Mar 27, 2023

Uh oh!

Uh oh!

More complete check in isConstTypeVariable #53341

More complete check in isConstTypeVariable #53341

Uh oh!

Conversation

ahejlsberg commented Mar 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahejlsberg commented Mar 18, 2023

Uh oh!

typescript-bot commented Mar 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 18, 2023

Uh oh!

typescript-bot commented Mar 18, 2023

Uh oh!

typescript-bot commented Mar 18, 2023

Uh oh!

typescript-bot commented Mar 18, 2023

Uh oh!

ahejlsberg commented Mar 21, 2023

Uh oh!

sandersn commented Mar 27, 2023

Uh oh!

Uh oh!

ahejlsberg commented Mar 18, 2023 •

edited

Loading

typescript-bot commented Mar 18, 2023 •

edited

Loading

typescript-bot commented Mar 18, 2023 •

edited

Loading

typescript-bot commented Mar 18, 2023 •

edited

Loading

typescript-bot commented Mar 18, 2023 •

edited

Loading

typescript-bot commented Mar 18, 2023 •

edited

Loading