🤖 Pick PR #53207 (Fixed symbol declarations for gener...) into release-5.0 #53271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
Comment on lines
+13183
to
+13184
| const nameType = getNameTypeFromMappedType(mappedType); | ||
| const shouldLinkPropDeclarations = !nameType || isFilteringMappedType(mappedType); |
There was a problem hiding this comment.
Why wasn't nameType just passed in?
There was a problem hiding this comment.
Trying to balance the reusability of this helper since it’s now used in two (?) places and i have a PR that wants to use it in another one: 10a9bb6
Not every call site has independent access to this
drivron
pushed a commit
to scenari/typescript
that referenced
this pull request
Sep 14, 2023
…to release-5.0 (microsoft#53271) Co-authored-by: Mateusz Burzyński <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-pick was triggered by a request on #53207
Please review the diff and merge if no changes are unexpected.
You can view the cherry-pick log here.
cc @jakebailey