Skip to content

Conversation

@Andarist
Copy link
Contributor

No description provided.

@sandersn
Copy link
Member

@Andarist is there a bug associated with this?

@gabritto
Copy link
Member

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 27, 2023

Heya @gabritto, I've started to run the tarball bundle task on this PR at 149c034. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 27, 2023

Hey @gabritto, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/151136/artifacts?artifactName=tgz&fileId=5C01B27804EF9ED1A87C8E64E9736B00B8F32C3EA893F76592E97911545C7E0F02&fileName=/typescript-5.1.0-insiders.20230327.tgz"
    }
}

and then running npm install.


There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

@sandersn sandersn added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Mar 27, 2023
@gabritto
Copy link
Member

@typescript-bot user test tsserver
@typescript-bot test tsserver top100

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 28, 2023

Heya @gabritto, I've started to run the diff-based top-repos suite (tsserver) on this PR at 149c034. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 28, 2023

Heya @gabritto, I've started to run the diff-based user code test suite (tsserver) on this PR at 149c034. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@gabritto Here are the results of running the user test suite comparing main and refs/pull/53225/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

@gabritto Here are the results of running the top-repos suite comparing main and refs/pull/53225/merge:

Everything looks good!

@gabritto gabritto merged commit ae2b4af into microsoft:main Mar 29, 2023
@Andarist Andarist deleted the fix/string-completions-indexed-access-union branch March 29, 2023 17:17
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants