Improve class member snippet completions and keyword completions interaction #52525

gabritto · 2023-01-30T22:42:00Z

This PR changes how class member snippet completions are sorted and filtered, and how they interact with class member modifiers.
The problem, as presented in the linked issue, is that class member snippet completions are currently sorted after keyword completions (via sortText), and this is not ideal when you manually request completions inside a class without having typed anything (in other words, when you'd likely want to see the overridable class members first). However, this was done so that member completions that have modifiers do not show up before the modifier keywords when you are typing the modifier.

With this PR, class member completions are sorted before keywords. But a class member protected foo() will have a filter text of foo, meaning that, as you're typing, that member completion will only show up if you're typing a substring of foo (i.e. the editor will match what you're typing to foo, whereas previously it would match what you're typing to the full insert text), so the member completion won't show up as you're typing protected.

I think in general this approach roughly matches what I've seen in other editors/languages (VS+C#, WebStorm+TS, xcode+Swift), and it makes sense to how I'd use it, but I'm looking for feedback on the UX and whether this is the best approach.

Case not supported:

async modifier is not inserted/allowed. This has been the case since the initial implementation of class member snippet completions. It's not clear to me if/when we should insert async or allow it to be inserted, open for opinions on that. I vaguely recall that, regarding object method completions, the sentiment around async was that we shouldn't insert it and people could add it after accepting the completion if they wanted.

Not ideal:

if one of the class member completions has a class member modifier as its prefix (e.g. a property called publicProperty), it will be sorted before the modifier keyword. I'm hoping that's not common enough to be disruptive, but I might be wrong.
if you type modifiers in the wrong order (or the wrong modifiers) for a certain class member, the class member completion will not be displayed. Again, don't know how disruptive that would be, because if your intent is to override a certain class member, you could start by typing its name (or part of its name), instead of starting by typing the member's modifiers.

How to test this in vscode:

Use the packaged version of TS corresponding to this PR: Improve class member snippet completions and keyword completions interaction #52525 (comment)
Use the vscode version from my fork or this PR, otherwise the completions won't work properly because a completion entry's filterText is currently modified by vscode and not respected.

typescript-bot · 2023-01-30T22:42:04Z

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @mjbvz, @zkat, and @joj for you. Feel free to loop in other consumers/maintainers if necessary

gabritto · 2023-01-30T22:52:53Z

@typescript-bot pack this

typescript-bot · 2023-01-30T22:52:55Z

Heya @gabritto, I've started to run the tarball bundle task on this PR at 2bdf846. You can monitor the build here.

typescript-bot · 2023-01-30T22:54:55Z

Hey @gabritto, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/144719/artifacts?artifactName=tgz&fileId=33086ECEE8FC0158FB1B0E9CF6A9EAD7049CF0A2FFB3EEBCECEE942010B8C1F402&fileName=/typescript-5.0.0-insiders.20230130.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

andrewbranch · 2023-01-31T19:23:21Z

if you type modifiers in the wrong order (or the wrong modifiers) for a certain class member, the class member completion will not be displayed. Again, don't know how disruptive that would be, because if your intent is to override a certain class member, you could start by typing its name (or part of its name), instead of starting by typing the member's modifiers.

I know we talked about this before, but can you explain again why this is the case? Suppose you type wrong modifiers, and then trigger completions again after the modifiers. The filterText shouldn’t prevent the completion from showing up—I think I remember you saying the issue is something to do with the replacement span? What if, once you’ve already typed modifiers, both the replacement span and the insert text of the snippet dropped the modifiers? That way, if you type the modifiers incorrectly, you can still get the snippet completion, but your incorrect modifiers will remain, and you may have to fix them—but you also might not, if it’s just a (syntactically legal) order mismatch.

gabritto · 2023-01-31T21:21:33Z

if you type modifiers in the wrong order (or the wrong modifiers) for a certain class member, the class member completion will not be displayed. Again, don't know how disruptive that would be, because if your intent is to override a certain class member, you could start by typing its name (or part of its name), instead of starting by typing the member's modifiers.

I know we talked about this before, but can you explain again why this is the case? Suppose you type wrong modifiers, and then trigger completions again after the modifiers. The filterText shouldn’t prevent the completion from showing up—I think I remember you saying the issue is something to do with the replacement span? What if, once you’ve already typed modifiers, both the replacement span and the insert text of the snippet dropped the modifiers? That way, if you type the modifiers incorrectly, you can still get the snippet completion, but your incorrect modifiers will remain, and you may have to fix them—but you also might not, if it’s just a (syntactically legal) order mismatch.

I can't point to all the exact places in vscode where this happens, but from debugging, what I've seen happen is that vscode tries to match filterText to the content in the replacementSpan. So if the replacementSpan contains the wrong modifiers that you already typed, it won't match the filterText (that would be just the name of the property). e.g. if you already have protected override |, and the replacement span includes protected override, it won't match a property named foo whose completion filter text would be just foo with the change in this PR.

We could allow the wrong modifiers, or maybe just the wrong order, but if the restriction I described above is true and there's no way around it, then we can't fix the existing wrong modifiers.

DanielRosenwasser · 2023-01-31T21:30:38Z

Sounds like an editor change that could be made? @mjbvz

gabritto · 2023-02-11T01:27:31Z

@typescript-bot run DT

typescript-bot · 2023-02-11T01:27:58Z

Heya @gabritto, I've started to run the parallelized Definitely Typed test suite on this PR at 2bdf846. You can monitor the build here.

sheetalkamat · 2023-02-22T21:41:58Z

src/services/completions.ts

    let isSnippet: true | undefined;
-    let replacementSpan: TextSpan | undefined;
    let insertText: string = name;
+    const filterText: string = name;


If filter text is name why cant editors use name itself to sort.. may need to considerkind along with that but it feels like we are returning same data.

The editor doesn't know that it should use name as the filterText, because in theory filterText could be anything. We could change the TS vscode extension to use the name as the filterText for class member snippet completions, but then that change would be restricted to vscode, and other editors would potentially run into the problem this PR is trying to fix.

gabritto · 2023-02-22T23:37:58Z

Ok, so I tried making the class member completions fix the existing modifiers with a code action. It doesn't look good because of the delay in applying the code action after the completion is inserted, so I'm not going to pursue that approach.

So the options are, considering how vscode currently works with regards to filterText/replacementSpan, if the user has already typed some modifiers:

Only offer the completion if the already present modifiers match the modifiers the completion would insert (this is the current behavior of the PR).
Always offer the completion regardless of the present modifiers, and let the user fix them afterwards.

gabritto · 2023-05-17T18:01:31Z

@typescript-bot test this
@typescript-bot run DT
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test top100
@typescript-bot test tsserver top100
@typescript-bot perf test this

typescript-bot · 2023-05-17T18:01:35Z

Heya @gabritto, I've started to run the perf test suite on this PR at cc95bfc. You can monitor the build here.

typescript-bot · 2023-05-17T18:01:35Z

Heya @gabritto, I've started to run the extended test suite on this PR at cc95bfc. You can monitor the build here.

typescript-bot · 2023-05-17T18:01:35Z

Heya @gabritto, I've started to run the diff-based user code test suite on this PR at cc95bfc. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-05-17T18:01:35Z

Heya @gabritto, I've started to run the diff-based top-repos suite (tsserver) on this PR at cc95bfc. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-05-17T18:01:35Z

Heya @gabritto, I've started to run the diff-based user code test suite (tsserver) on this PR at cc95bfc. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-05-17T18:01:35Z

Heya @gabritto, I've started to run the parallelized Definitely Typed test suite on this PR at cc95bfc. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-05-17T18:01:35Z

Heya @gabritto, I've started to run the diff-based top-repos suite on this PR at cc95bfc. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-05-17T18:21:16Z

@gabritto Here are the results of running the user test suite comparing main and refs/pull/52525/merge:

Everything looks good!

typescript-bot · 2023-05-17T18:30:28Z

@gabritto Here are the results of running the user test suite comparing main and refs/pull/52525/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
1 instance of "Package install failed"

Otherwise...

Everything looks good!

typescript-bot · 2023-05-17T20:01:03Z

@gabritto Here are the results of running the top-repos suite comparing main and refs/pull/52525/merge:

Everything looks good!

typescript-bot · 2023-05-17T20:04:02Z

Hey @gabritto, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

gabritto · 2023-05-17T20:55:47Z

@typescript-bot perf test this

typescript-bot · 2023-05-17T20:56:05Z

Heya @gabritto, I've started to run the perf test suite on this PR at cc95bfc. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-05-17T20:58:34Z

@gabritto Here are the results of running the top-repos suite comparing main and refs/pull/52525/merge:

Everything looks good!

typescript-bot · 2023-05-17T21:51:44Z

@gabritto
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52525

_Metric	_main	₅₂₅₂₅	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{365,601k (± 0.01%)}	_{365,597k (± 0.00%)}	_~	_365,577k	_365,611k	_{p=0.810 n=6}
_{Parse Time}	_{3.41s (± 0.63%)}	_{3.42s (± 0.92%)}	_~	_3.39s	_3.48s	_{p=0.625 n=6}
_{Bind Time}	_{1.12s (± 0.36%)}	_{1.11s (± 0.68%)}	_~	_1.10s	_1.12s	_{p=0.100 n=6}
_{Check Time}	_{8.76s (± 0.51%)}	_{8.74s (± 0.29%)}	_~	_8.70s	_8.77s	_{p=0.568 n=6}
_{Emit Time}	_{7.47s (± 0.95%)}	_{7.42s (± 0.30%)}	_~	_7.39s	_7.44s	_{p=0.163 n=6}
_{Total Time}	_{20.76s (± 0.49%)}	_{20.69s (± 0.06%)}	_~	_20.68s	_20.71s	_{p=0.377 n=6}
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{191,112k (± 0.01%)}	_{191,153k (± 0.02%)}	_~	_191,108k	_191,222k	_{p=0.199 n=6}
_{Parse Time}	_{1.51s (± 1.06%)}	_{1.51s (± 0.68%)}	_~	_1.49s	_1.52s	_{p=0.735 n=6}
_{Bind Time}	_{0.77s (± 0.67%)}	_{0.77s (± 0.67%)}	_~	_0.76s	_0.77s	_{p=0.069 n=6}
_{Check Time}	_{9.49s (± 0.74%)}	_{9.45s (± 0.35%)}	_~	_9.39s	_9.47s	_{p=0.228 n=6}
_{Emit Time}	_{2.73s (± 1.44%)}	_{2.76s (± 1.64%)}	_~	_2.71s	_2.82s	_{p=0.572 n=6}
_{Total Time}	_{14.51s (± 0.41%)}	_{14.48s (± 0.39%)}	_~	_14.40s	_14.57s	_{p=0.422 n=6}
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{346,612k (± 0.01%)}	_{346,611k (± 0.01%)}	_~	_346,583k	_346,653k	_{p=0.810 n=6}
_{Parse Time}	_{2.59s (± 1.08%)}	_{2.60s (± 0.80%)}	_~	_2.57s	_2.63s	_{p=0.517 n=6}
_{Bind Time}	_{1.00s (± 0.83%)}	_{1.00s (± 0.00%)}	_~	_1.00s	_1.00s	_{p=0.176 n=6}
_{Check Time}	_{7.14s (± 0.64%)}	_{7.11s (± 0.52%)}	_~	_7.06s	_7.17s	_{p=0.198 n=6}
_{Emit Time}	_{4.30s (± 1.27%)}	_{4.24s (± 0.77%)}	_{-0.07s (- 1.55%)}	_4.20s	_4.29s	_{p=0.024 n=6}
_{Total Time}	_{15.04s (± 0.64%)}	_{14.96s (± 0.31%)}	_{-0.09s (- 0.58%)}	_14.90s	_15.04s	_{p=0.043 n=6}
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{300,606k (± 0.00%)}	_{300,624k (± 0.00%)}	_{+18k (+ 0.01%)}	_300,608k	_300,635k	_{p=0.045 n=6}
_{Parse Time}	_{2.06s (± 1.18%)}	_{2.05s (± 1.00%)}	_~	_2.03s	_2.08s	_{p=0.517 n=6}
_{Bind Time}	_{1.14s (± 0.55%)}	_{1.14s (± 0.92%)}	_~	_1.12s	_1.15s	_{p=0.388 n=6}
_{Check Time}	_{6.62s (± 0.34%)}	_{6.61s (± 0.65%)}	_~	_6.53s	_6.66s	_{p=0.572 n=6}
_{Emit Time}	_{3.85s (± 0.88%)}	_{3.85s (± 0.51%)}	_~	_3.82s	_3.87s	_{p=0.747 n=6}
_{Total Time}	_{13.67s (± 0.33%)}	_{13.64s (± 0.51%)}	_~	_13.52s	_13.70s	_{p=0.375 n=6}
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{481,676k (± 0.01%)}	_{481,694k (± 0.01%)}	_~	_481,627k	_481,740k	_{p=0.336 n=6}
_{Parse Time}	_{3.10s (± 0.80%)}	_{3.10s (± 0.75%)}	_~	_3.07s	_3.13s	_{p=0.871 n=6}
_{Bind Time}	_{0.92s (± 0.82%)}	_{0.91s (± 1.79%)}	_~	_0.89s	_0.93s	_{p=0.741 n=6}
_{Check Time}	_{16.79s (± 0.18%)}	_{16.77s (± 0.58%)}	_~	_16.68s	_16.92s	_{p=0.378 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.81s (± 0.13%)}	_{20.79s (± 0.40%)}	_~	_20.70s	_20.92s	_{p=0.295 n=6}
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{562,843k (± 0.01%)}	_{562,873k (± 0.02%)}	_~	_562,684k	_563,019k	_{p=0.471 n=6}
_{Parse Time}	_{3.82s (± 0.66%)}	_{3.82s (± 0.52%)}	_~	_3.80s	_3.85s	_{p=0.936 n=6}
_{Bind Time}	_{1.63s (± 0.67%)}	_{1.64s (± 0.50%)}	_~	_1.63s	_1.65s	_{p=0.198 n=6}
_{Check Time}	_{2.81s (± 0.99%)}	_{2.81s (± 0.95%)}	_~	_2.77s	_2.84s	_{p=0.807 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{8.35s (± 0.58%)}	_{8.34s (± 0.27%)}	_~	_8.31s	_8.36s	_{p=1.000 n=6}
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{365,043k (± 0.00%)}	_{365,046k (± 0.01%)}	_~	_365,008k	_365,071k	_{p=0.689 n=6}
_{Parse Time}	_{3.55s (± 0.52%)}	_{3.56s (± 0.46%)}	_~	_3.54s	_3.58s	_{p=0.548 n=6}
_{Bind Time}	_{1.18s (± 0.69%)}	_{1.19s (± 0.69%)}	_~	_1.18s	_1.20s	_{p=0.666 n=6}
_{Check Time}	_{9.60s (± 0.44%)}	_{9.56s (± 0.40%)}	_~	_9.48s	_9.58s	_{p=0.172 n=6}
_{Emit Time}	_{7.93s (± 0.93%)}	_{7.89s (± 0.40%)}	_~	_7.84s	_7.94s	_{p=0.126 n=6}
_{Total Time}	_{22.27s (± 0.47%)}	_{22.18s (± 0.34%)}	_~	_22.06s	_22.29s	_{p=0.148 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,916k (± 0.02%)}	_{192,885k (± 0.02%)}	_~	_192,850k	_192,952k	_{p=0.173 n=6}
_{Parse Time}	_{1.58s (± 0.76%)}	_{1.61s (± 1.07%)}	_{+0.02s (+ 1.58%)}	_1.58s	_1.63s	_{p=0.029 n=6}
_{Bind Time}	_{0.83s (± 0.49%)}	_{0.83s (± 0.66%)}	_~	_0.82s	_0.83s	_{p=0.282 n=6}
_{Check Time}	_{10.25s (± 0.66%)}	_{10.19s (± 0.60%)}	_~	_10.11s	_10.28s	_{p=0.196 n=6}
_{Emit Time}	_{3.01s (± 0.62%)}	_{2.99s (± 0.69%)}	_~	_2.96s	_3.01s	_{p=0.463 n=6}
_{Total Time}	_{15.67s (± 0.52%)}	_{15.62s (± 0.34%)}	_~	_15.54s	_15.68s	_{p=0.520 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,876k (± 0.00%)}	_{345,873k (± 0.01%)}	_~	_345,829k	_345,893k	_{p=0.936 n=6}
_{Parse Time}	_{2.73s (± 0.49%)}	_{2.74s (± 0.52%)}	_~	_2.72s	_2.76s	_{p=0.190 n=6}
_{Bind Time}	_{1.08s (± 0.95%)}	_{1.09s (± 1.26%)}	_~	_1.07s	_1.11s	_{p=0.931 n=6}
_{Check Time}	_{7.81s (± 0.41%)}	_{7.82s (± 0.43%)}	_~	_7.78s	_7.88s	_{p=0.462 n=6}
_{Emit Time}	_{4.49s (± 0.23%)}	_{4.46s (± 0.51%)}	_{-0.02s (- 0.45%)}	_4.42s	_4.48s	_{p=0.046 n=6}
_{Total Time}	_{16.10s (± 0.23%)}	_{16.11s (± 0.38%)}	_~	_16.04s	_16.22s	_{p=0.629 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,948k (± 0.01%)}	_{299,946k (± 0.00%)}	_~	_299,925k	_299,958k	_{p=0.629 n=6}
_{Parse Time}	_{2.17s (± 0.57%)}	_{2.16s (± 0.62%)}	_~	_2.14s	_2.18s	_{p=0.413 n=6}
_{Bind Time}	_{1.23s (± 0.66%)}	_{1.22s (± 0.42%)}	_{-0.01s (- 0.81%)}	_1.22s	_1.23s	_{p=0.050 n=6}
_{Check Time}	_{7.27s (± 0.52%)}	_{7.25s (± 0.63%)}	_~	_7.17s	_7.29s	_{p=0.628 n=6}
_{Emit Time}	_{4.35s (± 1.26%)}	_{4.32s (± 0.54%)}	_~	_4.29s	_4.35s	_{p=0.228 n=6}
_{Total Time}	_{15.02s (± 0.57%)}	_{14.95s (± 0.41%)}	_~	_14.86s	_15.05s	_{p=0.261 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{480,949k (± 0.01%)}	_{480,933k (± 0.01%)}	_~	_480,884k	_480,967k	_{p=0.471 n=6}
_{Parse Time}	_{3.25s (± 0.57%)}	_{3.25s (± 0.32%)}	_~	_3.23s	_3.26s	_{p=0.806 n=6}
_{Bind Time}	_{0.94s (± 0.80%)}	_{0.94s (± 0.67%)}	_~	_0.93s	_0.95s	_{p=0.718 n=6}
_{Check Time}	_{17.83s (± 0.50%)}	_{17.88s (± 1.11%)}	_~	_17.73s	_18.28s	_{p=0.683 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.02s (± 0.39%)}	_{22.07s (± 0.88%)}	_~	_21.91s	_22.45s	_{p=0.872 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{560,465k (± 0.02%)}	_{560,546k (± 0.02%)}	_~	_560,405k	_560,662k	_{p=0.230 n=6}
_{Parse Time}	_{4.00s (± 0.35%)}	_{4.01s (± 0.35%)}	_~	_3.99s	_4.03s	_{p=0.289 n=6}
_{Bind Time}	_{1.76s (± 0.36%)}	_{1.75s (± 0.59%)}	_~	_1.74s	_1.77s	_{p=0.203 n=6}
_{Check Time}	_{3.06s (± 0.56%)}	_{3.05s (± 0.53%)}	_~	_3.03s	_3.07s	_{p=0.569 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 4.62%)}	_~	_0.08s	_0.09s	_{p=0.405 n=6}
_{Total Time}	_{8.91s (± 0.24%)}	_{8.91s (± 0.22%)}	_~	_8.89s	_8.94s	_{p=0.684 n=6}
_{Angular - node (v14.21.3, x64)}
_{Memory used}	_{359,012k (± 0.01%)}	_{359,032k (± 0.01%)}	_~	_358,993k	_359,078k	_{p=0.230 n=6}
_{Parse Time}	_{3.67s (± 0.14%)}	_{3.68s (± 0.34%)}	_{+0.01s (+ 0.36%)}	_3.66s	_3.70s	_{p=0.037 n=6}
_{Bind Time}	_{1.22s (± 0.42%)}	_{1.22s (± 0.00%)}	_~	_1.22s	_1.22s	_{p=0.174 n=6}
_{Check Time}	_{10.04s (± 0.60%)}	_{9.98s (± 0.55%)}	_~	_9.91s	_10.05s	_{p=0.128 n=6}
_{Emit Time}	_{8.38s (± 0.57%)}	_{8.29s (± 0.56%)}	_{-0.08s (- 0.99%)}	_8.22s	_8.35s	_{p=0.025 n=6}
_{Total Time}	_{23.30s (± 0.26%)}	_{23.18s (± 0.20%)}	_{-0.12s (- 0.52%)}	_23.11s	_23.25s	_{p=0.008 n=6}
_{Compiler-Unions - node (v14.21.3, x64)}
_{Memory used}	_{188,284k (± 0.02%)}	_{188,269k (± 0.01%)}	_~	_188,248k	_188,299k	_{p=0.298 n=6}
_{Parse Time}	_{1.61s (± 0.51%)}	_{1.60s (± 0.52%)}	_~	_1.60s	_1.62s	_{p=0.718 n=6}
_{Bind Time}	_{0.85s (± 0.48%)}	_{0.85s (± 1.05%)}	_~	_0.84s	_0.86s	_{p=0.787 n=6}
_{Check Time}	_{10.32s (± 0.42%)}	_{10.30s (± 0.53%)}	_~	_10.24s	_10.38s	_{p=0.466 n=6}
_{Emit Time}	_{3.11s (± 0.39%)}	_{3.12s (± 0.85%)}	_~	_3.09s	_3.16s	_{p=0.867 n=6}
_{Total Time}	_{15.88s (± 0.31%)}	_{15.88s (± 0.51%)}	_~	_15.79s	_15.98s	_{p=0.873 n=6}
_{Monaco - node (v14.21.3, x64)}
_{Memory used}	_{341,035k (± 0.00%)}	_{341,025k (± 0.00%)}	_~	_341,007k	_341,049k	_{p=0.296 n=6}
_{Parse Time}	_{2.80s (± 0.61%)}	_{2.81s (± 0.73%)}	_~	_2.79s	_2.85s	_{p=0.366 n=6}
_{Bind Time}	_{1.10s (± 1.87%)}	_{1.12s (± 0.46%)}	_~	_1.11s	_1.12s	_{p=0.276 n=6}
_{Check Time}	_{8.21s (± 0.56%)}	_{8.18s (± 0.44%)}	_~	_8.15s	_8.23s	_{p=0.221 n=6}
_{Emit Time}	_{4.73s (± 0.63%)}	_{4.69s (± 0.89%)}	_~	_4.65s	_4.76s	_{p=0.077 n=6}
_{Total Time}	_{16.85s (± 0.51%)}	_{16.79s (± 0.16%)}	_~	_16.75s	_16.83s	_{p=0.630 n=6}
_{TFS - node (v14.21.3, x64)}
_{Memory used}	_{295,134k (± 0.00%)}	_{295,130k (± 0.00%)}	_~	_295,125k	_295,137k	_{p=0.229 n=6}
_{Parse Time}	_{2.38s (± 0.68%)}	_{2.40s (± 0.51%)}	_~	_2.38s	_2.41s	_{p=0.241 n=6}
_{Bind Time}	_{1.06s (± 0.49%)}	_{1.07s (± 0.76%)}	_~	_1.06s	_1.08s	_{p=0.523 n=6}
_{Check Time}	_{7.60s (± 0.39%)}	_{7.56s (± 0.49%)}	_~	_7.52s	_7.61s	_{p=0.076 n=6}
_{Emit Time}	_{4.34s (± 0.93%)}	_{4.30s (± 0.64%)}	_{-0.05s (- 1.07%)}	_4.27s	_4.35s	_{p=0.033 n=6}
_{Total Time}	_{15.39s (± 0.35%)}	_{15.32s (± 0.41%)}	_{-0.07s (- 0.44%)}	_15.27s	_15.44s	_{p=0.030 n=6}
_{material-ui - node (v14.21.3, x64)}
_{Memory used}	_{476,485k (± 0.00%)}	_{476,527k (± 0.01%)}	_~	_476,444k	_476,565k	_{p=0.066 n=6}
_{Parse Time}	_{3.33s (± 0.35%)}	_{3.34s (± 0.60%)}	_~	_3.31s	_3.37s	_{p=0.415 n=6}
_{Bind Time}	_{1.00s (± 0.63%)}	_{1.00s (± 0.54%)}	_~	_1.00s	_1.01s	_{p=0.201 n=6}
_{Check Time}	_{18.81s (± 0.47%)}	_{18.71s (± 0.17%)}	_{-0.10s (- 0.54%)}	_18.66s	_18.75s	_{p=0.036 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{23.15s (± 0.35%)}	_{23.05s (± 0.14%)}	_{-0.09s (- 0.41%)}	_23.02s	_23.11s	_{p=0.020 n=6}
_{xstate - node (v14.21.3, x64)}
_{Memory used}	_{549,431k (± 0.00%)}	_{549,444k (± 0.00%)}	_~	_549,415k	_549,471k	_{p=0.378 n=6}
_{Parse Time}	_{4.25s (± 0.75%)}	_{4.24s (± 0.66%)}	_~	_4.20s	_4.28s	_{p=0.572 n=6}
_{Bind Time}	_{1.59s (± 0.77%)}	_{1.62s (± 2.57%)}	_~	_1.58s	_1.69s	_{p=0.288 n=6}
_{Check Time}	_{3.18s (± 0.92%)}	_{3.19s (± 0.74%)}	_~	_3.16s	_3.22s	_{p=0.420 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{9.11s (± 0.39%)}	_{9.14s (± 0.47%)}	_~	_9.10s	_9.21s	_{p=0.170 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.21.3, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.21.3, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.21.3, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.21.3, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.21.3, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.21.3, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.21.3, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₅₂₅	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..52525

_Metric	_main	₅₂₅₂₅	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,534ms (± 0.30%)}	_{2,539ms (± 0.37%)}	_~	_2,527ms	_2,549ms	_{p=0.334 n=6}
_{Req 2 - geterr}	_{5,571ms (± 0.47%)}	_{5,530ms (± 0.34%)}	_{-41ms (- 0.73%)}	_5,507ms	_5,559ms	_{p=0.031 n=6}
_{Req 3 - references}	_{336ms (± 0.24%)}	_{338ms (± 0.72%)}	_~	_335ms	_341ms	_{p=0.070 n=6}
_{Req 4 - navto}	_{286ms (± 0.54%)}	_{287ms (± 0.48%)}	_~	_285ms	_289ms	_{p=0.800 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{85ms (± 1.16%)}	_{85ms (± 0.89%)}	_~	_84ms	_86ms	_{p=1.000 n=6}
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,656ms (± 0.61%)}	_{2,640ms (± 0.68%)}	_~	_2,618ms	_2,660ms	_{p=0.230 n=6}
_{Req 2 - geterr}	_{4,287ms (± 0.63%)}	_{4,284ms (± 0.46%)}	_~	_4,257ms	_4,309ms	_{p=0.688 n=6}
_{Req 3 - references}	_{349ms (± 0.81%)}	_{349ms (± 0.46%)}	_~	_347ms	_351ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{292ms (± 0.88%)}	_{291ms (± 0.64%)}	_~	_288ms	_293ms	_{p=0.515 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{62ms (± 0.83%)}	_{64ms (± 3.99%)}	_~	_62ms	_69ms	_{p=0.070 n=6}
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,066ms (± 0.43%)}	_{3,087ms (± 0.40%)}	_{+21ms (+ 0.69%)}	_3,074ms	_3,106ms	_{p=0.031 n=6}
_{Req 2 - geterr}	_{1,591ms (± 0.71%)}	_{1,588ms (± 0.62%)}	_~	_1,571ms	_1,599ms	_{p=0.748 n=6}
_{Req 3 - references}	_{114ms (± 1.40%)}	_{114ms (± 1.17%)}	_~	_112ms	_116ms	_{p=0.801 n=6}
_{Req 4 - navto}	_{366ms (± 0.45%)}	_{363ms (± 0.21%)}	_{-2ms (- 0.64%)}	_362ms	_364ms	_{p=0.022 n=6}
_{Req 5 - completionInfo count}	_{2,862 (± 0.00%)}	_{2,862 (± 0.00%)}	_~	_2,862	_2,862	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{381ms (± 1.60%)}	_{388ms (± 2.16%)}	_~	_375ms	_399ms	_{p=0.173 n=6}
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,654ms (± 0.83%)}	_{2,661ms (± 0.77%)}	_~	_2,638ms	_2,697ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{6,046ms (± 0.31%)}	_{5,997ms (± 0.19%)}	_{-50ms (- 0.82%)}	_5,977ms	_6,011ms	_{p=0.005 n=6}
_{Req 3 - references}	_{351ms (± 0.53%)}	_{353ms (± 0.53%)}	_~	_350ms	_355ms	_{p=0.416 n=6}
_{Req 4 - navto}	_{290ms (± 1.66%)}	_{291ms (± 1.39%)}	_~	_287ms	_295ms	_{p=0.415 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{92ms (± 1.50%)}	_{93ms (± 0.81%)}	_~	_92ms	_94ms	_{p=0.063 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,838ms (± 0.80%)}	_{2,834ms (± 0.43%)}	_~	_2,819ms	_2,854ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{4,665ms (± 0.52%)}	_{4,644ms (± 0.31%)}	_~	_4,624ms	_4,662ms	_{p=0.230 n=6}
_{Req 3 - references}	_{365ms (± 0.48%)}	_{364ms (± 0.30%)}	_~	_362ms	_365ms	_{p=0.503 n=6}
_{Req 4 - navto}	_{288ms (± 0.92%)}	_{289ms (± 0.18%)}	_~	_288ms	_289ms	_{p=0.437 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{68ms (± 0.76%)}	_{68ms (± 1.55%)}	_~	_66ms	_69ms	_{p=0.794 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,213ms (± 0.53%)}	_{3,218ms (± 0.40%)}	_~	_3,203ms	_3,234ms	_{p=0.748 n=6}
_{Req 2 - geterr}	_{1,741ms (± 0.79%)}	_{1,749ms (± 1.35%)}	_~	_1,725ms	_1,789ms	_{p=0.575 n=6}
_{Req 3 - references}	_{129ms (± 8.75%)}	_{124ms (± 0.33%)}	_~	_123ms	_124ms	_{p=0.405 n=6}
_{Req 4 - navto}	_{345ms (± 1.18%)}	_{343ms (± 0.60%)}	_~	_340ms	_346ms	_{p=0.255 n=6}
_{Req 5 - completionInfo count}	_{2,862 (± 0.00%)}	_{2,862 (± 0.00%)}	_~	_2,862	_2,862	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{409ms (± 2.22%)}	_{406ms (± 1.20%)}	_~	_401ms	_411ms	_{p=0.627 n=6}
_{Compiler-UnionsTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{2,806ms (± 0.52%)}	_{2,783ms (± 0.30%)}	_{-24ms (- 0.85%)}	_2,767ms	_2,791ms	_{p=0.045 n=6}
_{Req 2 - geterr}	_{6,238ms (± 0.68%)}	_{6,154ms (± 0.36%)}	_{-84ms (- 1.35%)}	_6,123ms	_6,184ms	_{p=0.008 n=6}
_{Req 3 - references}	_{362ms (± 1.50%)}	_{361ms (± 1.09%)}	_~	_356ms	_366ms	_{p=0.936 n=6}
_{Req 4 - navto}	_{291ms (± 0.49%)}	_{290ms (± 1.06%)}	_~	_287ms	_294ms	_{p=0.872 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{96ms (± 6.10%)}	_{95ms (± 8.28%)}	_~	_83ms	_103ms	_{p=0.747 n=6}
_{CompilerTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{2,969ms (± 0.51%)}	_{2,961ms (± 0.14%)}	_~	_2,955ms	_2,967ms	_{p=0.295 n=6}
_{Req 2 - geterr}	_{4,560ms (± 1.81%)}	_{4,508ms (± 0.38%)}	_~	_4,480ms	_4,526ms	_{p=0.128 n=6}
_{Req 3 - references}	_{375ms (± 0.28%)}	_{375ms (± 0.55%)}	_~	_372ms	_377ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{298ms (± 0.50%)}	_{298ms (± 0.18%)}	_~	_297ms	_298ms	_{p=0.247 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{79ms (± 6.97%)}	_{76ms (± 0.54%)}	_~	_76ms	_77ms	_{p=0.849 n=6}
_{xstateTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{3,513ms (± 1.10%)}	_{3,493ms (± 0.83%)}	_~	_3,466ms	_3,547ms	_{p=0.261 n=6}
_{Req 2 - geterr}	_{1,856ms (± 0.97%)}	_{1,853ms (± 0.44%)}	_~	_1,839ms	_1,861ms	_{p=1.000 n=6}
_{Req 3 - references}	_{148ms (± 8.67%)}	_{152ms (± 8.54%)}	_~	_135ms	_165ms	_{p=0.748 n=6}
_{Req 4 - navto}	_{395ms (± 1.55%)}	_{401ms (± 2.39%)}	_~	_395ms	_420ms	_{p=0.377 n=6}
_{Req 5 - completionInfo count}	_{2,862 (± 0.00%)}	_{2,862 (± 0.00%)}	_~	_2,862	_2,862	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{428ms (± 1.46%)}	_{435ms (± 0.28%)}	_{+8ms (+ 1.79%)}	_433ms	_436ms	_{p=0.009 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.21.3, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.21.3, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.21.3, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.21.3, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₅₂₅	₆
_Baseline	_main	₆

Startup

Comparison Report - main..52525

_Metric	_main	₅₂₅₂₅	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{144.30ms (± 0.33%)}	_{141.52ms (± 0.16%)}	_{-2.79ms (- 1.93%)}	_140.91ms	_144.00ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{220.61ms (± 0.28%)}	_{220.72ms (± 0.16%)}	_{+0.11ms (+ 0.05%)}	_219.82ms	_225.36ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{223.11ms (± 0.35%)}	_{222.05ms (± 0.14%)}	_{-1.05ms (- 0.47%)}	_221.23ms	_226.96ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{205.15ms (± 0.34%)}	_{203.78ms (± 0.15%)}	_{-1.37ms (- 0.67%)}	_203.09ms	_207.29ms	_{p=0.000 n=600}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₅₂₅	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

gabritto added 4 commits January 12, 2023 16:00

WIP: add filter text

a0bf28a

Merge branch 'main' into gabritto/issue52121

4747280

use filter text & deal with already present modifiers

8a812f2

update and fix tests

960cfb9

typescript-bot assigned gabritto Jan 30, 2023

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Jan 30, 2023

fix spaces

2bdf846

gabritto mentioned this pull request Jan 30, 2023

[typescript-language-features] Use original filterText if present microsoft/vscode#172866

Merged

gabritto requested review from DanielRosenwasser and andrewbranch January 30, 2023 23:00

WIP

81983b2

accept modifiers in any order, always add them, but erase existing ones

5f7b4a1

sheetalkamat reviewed Feb 22, 2023

View reviewed changes

gabritto added 2 commits May 12, 2023 14:26

Merge branch 'main' into gabritto/issue52121

4a1cf73

fix tests

0ba5951

gabritto requested review from andrewbranch and removed request for andrewbranch May 16, 2023 23:01

fix lint errors

cc95bfc

andrewbranch approved these changes May 17, 2023

View reviewed changes

gabritto merged commit 24ac9e7 into main May 17, 2023

gabritto deleted the gabritto/issue52121 branch May 17, 2023 22:14

This was referenced Mar 5, 2024

Properly set hasAction for erasing modifiers in class member completions #57643

Merged

Include replacementSpan in member completions #57480

Closed

microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025

Improve class member snippet completions and keyword completions interaction #52525

Improve class member snippet completions and keyword completions interaction #52525

Uh oh!

Conversation

gabritto commented Jan 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 30, 2023

Uh oh!

gabritto commented Jan 30, 2023

Uh oh!

typescript-bot commented Jan 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrewbranch commented Jan 31, 2023

Uh oh!

gabritto commented Jan 31, 2023

Uh oh!

DanielRosenwasser commented Jan 31, 2023

Uh oh!

gabritto commented Feb 11, 2023

Uh oh!

typescript-bot commented Feb 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sheetalkamat Feb 22, 2023

Choose a reason for hiding this comment

Uh oh!

gabritto Feb 22, 2023

Choose a reason for hiding this comment

Uh oh!

gabritto commented Feb 22, 2023

Uh oh!

gabritto commented May 17, 2023

Uh oh!

typescript-bot commented May 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 17, 2023

Uh oh!

typescript-bot commented May 17, 2023

Uh oh!

typescript-bot commented May 17, 2023

Uh oh!

typescript-bot commented May 17, 2023

Uh oh!

gabritto commented May 17, 2023

Uh oh!

typescript-bot commented May 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 17, 2023

Uh oh!

typescript-bot commented May 17, 2023

Compiler

TSServer

Startup

Uh oh!

Reviewers

gabritto commented Jan 30, 2023 •

edited

Loading

typescript-bot commented Jan 30, 2023 •

edited

Loading

typescript-bot commented Jan 30, 2023 •

edited

Loading

typescript-bot commented Feb 11, 2023 •

edited

Loading

typescript-bot commented May 17, 2023 •

edited

Loading

typescript-bot commented May 17, 2023 •

edited

Loading

typescript-bot commented May 17, 2023 •

edited

Loading

typescript-bot commented May 17, 2023 •

edited

Loading

typescript-bot commented May 17, 2023 •

edited

Loading

typescript-bot commented May 17, 2023 •

edited

Loading

typescript-bot commented May 17, 2023 •

edited

Loading

typescript-bot commented May 17, 2023 •

edited

Loading