Skip to content

Dont calculate version paths proactively as they may not be needed #51593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 29, 2022
Merged

Dont calculate version paths proactively as they may not be needed #51593

merged 2 commits into from
Nov 29, 2022

Conversation

sheetalkamat
Copy link
Member

Noticed this while working on caching module resolution that the trace shows types version not present even though it is not used at all.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 19, 2022
@andrewbranch
Copy link
Member

@typescript-bot perf test this faster

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 29, 2022 •
edited
Loading

Heya @andrewbranch, I've started to run the abridged perf test suite on this PR at 768660c. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@andrewbranch
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..51593

Metric main 51593 Delta Best Worst
Angular - node (v16.17.1, x64)
Memory used 340,655k (± 0.02%) 340,632k (± 0.02%) -24k (- 0.01%) 340,353k 340,692k
Parse Time 1.90s (± 0.38%) 1.88s (± 0.52%) -0.02s (- 1.05%) 1.86s 1.90s
Bind Time 0.65s (± 0.80%) 0.65s (± 0.73%) -0.00s (- 0.61%) 0.64s 0.66s
Check Time 5.18s (± 0.31%) 5.14s (± 0.63%) -0.05s (- 0.93%) 5.07s 5.21s
Emit Time 5.18s (± 0.90%) 5.06s (± 0.84%) -0.12s (- 2.28%) 4.99s 5.18s
Total Time 12.91s (± 0.28%) 12.72s (± 0.52%) -0.19s (- 1.49%) 12.61s 12.92s
Compiler-Unions - node (v16.17.1, x64)
Memory used 187,364k (± 0.54%) 188,668k (± 0.65%) +1,304k (+ 0.70%) 186,594k 190,137k
Parse Time 0.79s (± 0.94%) 0.78s (± 0.61%) -0.01s (- 1.26%) 0.77s 0.79s
Bind Time 0.42s (± 0.95%) 0.42s (± 1.37%) -0.00s (- 0.24%) 0.41s 0.43s
Check Time 6.09s (± 0.47%) 6.06s (± 0.67%) -0.03s (- 0.46%) 5.97s 6.17s
Emit Time 1.94s (± 0.60%) 1.93s (± 0.85%) -0.02s (- 0.82%) 1.89s 1.96s
Total Time 9.25s (± 0.42%) 9.19s (± 0.53%) -0.06s (- 0.64%) 9.09s 9.35s
Monaco - node (v16.17.1, x64)
Memory used 319,833k (± 0.01%) 319,793k (± 0.02%) -40k (- 0.01%) 319,664k 319,905k
Parse Time 1.42s (± 0.47%) 1.41s (± 0.67%) -0.01s (- 0.92%) 1.38s 1.43s
Bind Time 0.59s (± 1.26%) 0.59s (± 0.56%) 0.00s ( 0.00%) 0.58s 0.60s
Check Time 4.87s (± 0.27%) 4.87s (± 0.45%) -0.00s (- 0.06%) 4.83s 4.92s
Emit Time 2.73s (± 0.83%) 2.71s (± 0.77%) -0.02s (- 0.70%) 2.67s 2.74s
Total Time 9.61s (± 0.34%) 9.58s (± 0.53%) -0.03s (- 0.35%) 9.48s 9.67s
TFS - node (v16.17.1, x64)
Memory used 282,290k (± 0.01%) 282,302k (± 0.01%) +12k (+ 0.00%) 282,250k 282,336k
Parse Time 1.17s (± 1.28%) 1.16s (± 0.85%) -0.01s (- 1.11%) 1.14s 1.18s
Bind Time 0.65s (± 3.26%) 0.66s (± 4.13%) +0.00s (+ 0.31%) 0.57s 0.69s
Check Time 4.75s (± 0.31%) 4.75s (± 0.53%) 0.00s ( 0.00%) 4.70s 4.81s
Emit Time 2.83s (± 2.05%) 2.78s (± 2.34%) -0.05s (- 1.63%) 2.67s 2.90s
Total Time 9.40s (± 0.86%) 9.35s (± 0.79%) -0.05s (- 0.55%) 9.22s 9.52s
material-ui - node (v16.17.1, x64)
Memory used 435,271k (± 0.00%) 435,272k (± 0.00%) +1k (+ 0.00%) 435,218k 435,301k
Parse Time 1.64s (± 0.54%) 1.63s (± 0.51%) -0.02s (- 1.16%) 1.61s 1.64s
Bind Time 0.50s (± 1.18%) 0.50s (± 0.80%) -0.00s (- 0.99%) 0.49s 0.51s
Check Time 11.97s (± 0.58%) 11.76s (± 1.01%) -0.21s (- 1.78%) 11.60s 12.07s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 14.12s (± 0.54%) 13.88s (± 0.88%) -0.24s (- 1.70%) 13.72s 14.20s
xstate - node (v16.17.1, x64)
Memory used 516,021k (± 0.02%) 516,048k (± 0.01%) +27k (+ 0.01%) 515,986k 516,193k
Parse Time 2.31s (± 0.56%) 2.29s (± 0.57%) -0.02s (- 0.78%) 2.27s 2.32s
Bind Time 0.83s (± 0.82%) 0.82s (± 0.72%) -0.01s (- 1.20%) 0.81s 0.84s
Check Time 1.36s (± 0.70%) 1.35s (± 0.78%) -0.01s (- 0.66%) 1.33s 1.37s
Emit Time 0.06s (± 0.00%) 0.06s (± 0.00%) 0.00s ( 0.00%) 0.06s 0.06s
Total Time 4.57s (± 0.48%) 4.53s (± 0.35%) -0.04s (- 0.92%) 4.49s 4.56s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-131-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • Angular - node (v16.17.1, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Monaco - node (v16.17.1, x64)
  • TFS - node (v16.17.1, x64)
  • material-ui - node (v16.17.1, x64)
  • xstate - node (v16.17.1, x64)
Benchmark Name Iterations
Current 51593 10
Baseline main 10

Developer Information:

Download Benchmark

@andrewbranch
Copy link
Member

Is program time being reported as part of parse time? If the numbers are to be believed, looks like the impact might actually be visible. We are talking about 1/100th of a second though, so it’s hard to say 😁

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 29, 2022 •
edited
Loading

Heya @andrewbranch, I've started to run the perf test suite on this PR at 768660c. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@andrewbranch
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..51593
Metric main 51593 Delta Best Worst
Angular - node (v18.10.0, x64)
Memory used 341,204k (± 0.02%) 341,209k (± 0.02%) +5k (+ 0.00%) 341,048k 341,331k
Parse Time 1.55s (± 0.54%) 1.56s (± 0.69%) +0.01s (+ 0.64%) 1.54s 1.58s
Bind Time 0.53s (± 1.04%) 0.54s (± 0.83%) +0.01s (+ 1.13%) 0.53s 0.55s
Check Time 4.01s (± 0.77%) 3.99s (± 0.75%) -0.02s (- 0.42%) 3.93s 4.07s
Emit Time 4.27s (± 1.07%) 4.26s (± 0.97%) -0.02s (- 0.44%) 4.15s 4.34s
Total Time 10.37s (± 0.58%) 10.35s (± 0.61%) -0.02s (- 0.21%) 10.22s 10.54s
Compiler-Unions - node (v18.10.0, x64)
Memory used 185,081k (± 0.02%) 187,899k (± 1.11%) +2,818k (+ 1.52%) 184,974k 190,790k
Parse Time 0.61s (± 0.66%) 0.62s (± 1.46%) +0.01s (+ 1.64%) 0.60s 0.64s
Bind Time 0.33s (± 1.21%) 0.33s (± 0.67%) +0.00s (+ 0.00%) 0.33s 0.34s
Check Time 5.06s (± 0.75%) 5.05s (± 0.59%) -0.01s (- 0.12%) 4.96s 5.11s
Emit Time 1.55s (± 0.65%) 1.55s (± 0.87%) +0.00s (+ 0.26%) 1.52s 1.59s
Total Time 7.54s (± 0.59%) 7.55s (± 0.63%) +0.01s (+ 0.11%) 7.44s 7.68s
Monaco - node (v18.10.0, x64)
Memory used 320,575k (± 0.05%) 320,474k (± 0.01%) -101k (- 0.03%) 320,407k 320,591k
Parse Time 1.16s (± 1.34%) 1.16s (± 1.82%) -0.00s (- 0.34%) 1.13s 1.22s
Bind Time 0.48s (± 1.41%) 0.49s (± 1.13%) +0.01s (+ 1.65%) 0.48s 0.50s
Check Time 3.84s (± 0.59%) 3.85s (± 0.58%) +0.01s (+ 0.18%) 3.80s 3.89s
Emit Time 2.25s (± 0.56%) 2.25s (± 0.98%) +0.00s (+ 0.00%) 2.22s 2.32s
Total Time 7.74s (± 0.51%) 7.75s (± 0.63%) +0.01s (+ 0.17%) 7.68s 7.90s
TFS - node (v18.10.0, x64)
Memory used 283,743k (± 0.26%) 283,455k (± 0.24%) -288k (- 0.10%) 282,649k 284,851k
Parse Time 0.96s (± 1.12%) 0.97s (± 1.09%) +0.01s (+ 0.62%) 0.94s 0.98s
Bind Time 0.44s (± 1.74%) 0.44s (± 1.53%) +0.01s (+ 1.83%) 0.43s 0.46s
Check Time 3.78s (± 0.71%) 3.79s (± 0.44%) +0.01s (+ 0.29%) 3.74s 3.82s
Emit Time 2.21s (± 0.86%) 2.21s (± 0.78%) +0.00s (+ 0.09%) 2.17s 2.25s
Total Time 7.38s (± 0.54%) 7.41s (± 0.47%) +0.03s (+ 0.34%) 7.29s 7.47s
material-ui - node (v18.10.0, x64)
Memory used 435,967k (± 0.02%) 435,941k (± 0.01%) -26k (- 0.01%) 435,881k 436,107k
Parse Time 1.33s (± 0.62%) 1.33s (± 0.80%) +0.01s (+ 0.60%) 1.31s 1.36s
Bind Time 0.49s (± 2.48%) 0.48s (± 3.37%) -0.00s (- 0.62%) 0.44s 0.50s
Check Time 10.27s (± 0.77%) 10.32s (± 0.74%) +0.05s (+ 0.48%) 10.09s 10.45s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 12.08s (± 0.70%) 12.13s (± 0.59%) +0.05s (+ 0.42%) 11.92s 12.28s
xstate - node (v18.10.0, x64)
Memory used 518,404k (± 0.01%) 518,390k (± 0.01%) -14k (- 0.00%) 518,300k 518,585k
Parse Time 1.91s (± 0.60%) 1.92s (± 0.59%) +0.01s (+ 0.68%) 1.90s 1.95s
Bind Time 0.76s (± 3.75%) 0.75s (± 4.25%) -0.01s (- 1.57%) 0.70s 0.84s
Check Time 1.04s (± 0.87%) 1.04s (± 1.02%) +0.01s (+ 0.48%) 1.02s 1.06s
Emit Time 0.05s (± 0.00%) 0.05s (± 0.00%) 0.00s ( 0.00%) 0.05s 0.05s
Total Time 3.76s (± 0.95%) 3.76s (± 0.90%) +0.00s (+ 0.03%) 3.72s 3.85s
Angular - node (v16.17.1, x64)
Memory used 340,655k (± 0.02%) 340,610k (± 0.03%) -46k (- 0.01%) 340,349k 340,749k
Parse Time 1.90s (± 0.38%) 1.90s (± 0.64%) +0.00s (+ 0.05%) 1.87s 1.92s
Bind Time 0.65s (± 0.80%) 0.65s (± 0.85%) +0.00s (+ 0.15%) 0.64s 0.66s
Check Time 5.18s (± 0.31%) 5.18s (± 0.19%) -0.01s (- 0.14%) 5.16s 5.20s
Emit Time 5.18s (± 0.90%) 5.16s (± 0.94%) -0.02s (- 0.31%) 5.07s 5.25s
Total Time 12.91s (± 0.28%) 12.89s (± 0.42%) -0.02s (- 0.17%) 12.79s 13.02s
Compiler-Unions - node (v16.17.1, x64)
Memory used 187,364k (± 0.54%) 186,950k (± 0.40%) -414k (- 0.22%) 186,313k 189,933k
Parse Time 0.79s (± 0.94%) 0.79s (± 0.47%) +0.00s (+ 0.25%) 0.79s 0.80s
Bind Time 0.42s (± 0.95%) 0.42s (± 0.80%) +0.00s (+ 0.48%) 0.42s 0.43s
Check Time 6.09s (± 0.47%) 6.08s (± 0.41%) -0.01s (- 0.11%) 6.03s 6.13s
Emit Time 1.94s (± 0.60%) 1.94s (± 0.48%) +0.00s (+ 0.10%) 1.93s 1.97s
Total Time 9.25s (± 0.42%) 9.25s (± 0.31%) 0.00s ( 0.00%) 9.18s 9.31s
Monaco - node (v16.17.1, x64)
Memory used 319,833k (± 0.01%) 319,812k (± 0.01%) -22k (- 0.01%) 319,734k 319,894k
Parse Time 1.42s (± 0.47%) 1.43s (± 0.71%) +0.01s (+ 0.42%) 1.41s 1.45s
Bind Time 0.59s (± 1.26%) 0.59s (± 0.75%) +0.00s (+ 0.34%) 0.58s 0.60s
Check Time 4.87s (± 0.27%) 4.88s (± 0.47%) +0.01s (+ 0.16%) 4.83s 4.94s
Emit Time 2.73s (± 0.83%) 2.73s (± 0.73%) +0.00s (+ 0.11%) 2.69s 2.77s
Total Time 9.61s (± 0.34%) 9.63s (± 0.44%) +0.02s (+ 0.19%) 9.53s 9.72s
TFS - node (v16.17.1, x64)
Memory used 282,290k (± 0.01%) 282,297k (± 0.02%) +7k (+ 0.00%) 282,111k 282,368k
Parse Time 1.17s (± 1.28%) 1.17s (± 0.87%) 0.00s ( 0.00%) 1.15s 1.20s
Bind Time 0.65s (± 3.26%) 0.67s (± 2.54%) +0.01s (+ 2.14%) 0.61s 0.70s
Check Time 4.75s (± 0.31%) 4.75s (± 0.25%) -0.01s (- 0.13%) 4.72s 4.78s
Emit Time 2.83s (± 2.05%) 2.81s (± 2.18%) -0.02s (- 0.67%) 2.70s 2.92s
Total Time 9.40s (± 0.86%) 9.40s (± 0.76%) -0.01s (- 0.07%) 9.27s 9.51s
material-ui - node (v16.17.1, x64)
Memory used 435,271k (± 0.00%) 435,276k (± 0.00%) +5k (+ 0.00%) 435,248k 435,333k
Parse Time 1.64s (± 0.54%) 1.64s (± 0.54%) -0.00s (- 0.06%) 1.63s 1.67s
Bind Time 0.50s (± 1.18%) 0.50s (± 1.15%) -0.00s (- 0.20%) 0.49s 0.52s
Check Time 11.97s (± 0.58%) 11.84s (± 1.27%) -0.13s (- 1.09%) 11.65s 12.36s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 14.12s (± 0.54%) 13.99s (± 1.08%) -0.14s (- 0.98%) 13.79s 14.50s
xstate - node (v16.17.1, x64)
Memory used 516,021k (± 0.02%) 515,980k (± 0.01%) -41k (- 0.01%) 515,907k 516,139k
Parse Time 2.31s (± 0.56%) 2.31s (± 0.19%) -0.00s (- 0.04%) 2.30s 2.32s
Bind Time 0.83s (± 0.82%) 0.84s (± 1.81%) +0.01s (+ 0.72%) 0.83s 0.90s
Check Time 1.36s (± 0.70%) 1.36s (± 0.60%) +0.01s (+ 0.52%) 1.34s 1.38s
Emit Time 0.06s (± 0.00%) 0.06s (± 0.00%) 0.00s ( 0.00%) 0.06s 0.06s
Total Time 4.57s (± 0.48%) 4.58s (± 0.43%) +0.01s (+ 0.22%) 4.55s 4.65s
Angular - node (v14.15.1, x64)
Memory used 334,078k (± 0.01%) 334,103k (± 0.01%) +25k (+ 0.01%) 334,034k 334,165k
Parse Time 2.04s (± 0.47%) 2.05s (± 0.82%) +0.01s (+ 0.34%) 2.03s 2.10s
Bind Time 0.70s (± 0.49%) 0.70s (± 0.64%) +0.00s (+ 0.14%) 0.69s 0.71s
Check Time 5.50s (± 0.47%) 5.52s (± 0.52%) +0.02s (+ 0.33%) 5.45s 5.58s
Emit Time 5.35s (± 1.17%) 5.40s (± 1.38%) +0.04s (+ 0.84%) 5.27s 5.62s
Total Time 13.60s (± 0.48%) 13.67s (± 0.59%) +0.07s (+ 0.49%) 13.53s 13.91s
Compiler-Unions - node (v14.15.1, x64)
Memory used 182,945k (± 0.63%) 183,688k (± 0.67%) +742k (+ 0.41%) 181,562k 185,101k
Parse Time 0.89s (± 0.69%) 0.90s (± 0.81%) +0.01s (+ 0.79%) 0.89s 0.92s
Bind Time 0.46s (± 1.09%) 0.46s (± 0.97%) +0.00s (+ 0.66%) 0.45s 0.47s
Check Time 6.34s (± 0.50%) 6.37s (± 0.73%) +0.03s (+ 0.49%) 6.27s 6.45s
Emit Time 2.05s (± 1.40%) 2.05s (± 0.73%) -0.00s (- 0.24%) 2.01s 2.08s
Total Time 9.74s (± 0.56%) 9.77s (± 0.52%) +0.04s (+ 0.36%) 9.68s 9.86s
Monaco - node (v14.15.1, x64)
Memory used 314,622k (± 0.01%) 314,609k (± 0.01%) -13k (- 0.00%) 314,560k 314,670k
Parse Time 1.58s (± 0.95%) 1.57s (± 0.54%) -0.01s (- 0.63%) 1.55s 1.59s
Bind Time 0.63s (± 0.63%) 0.63s (± 0.57%) +0.00s (+ 0.48%) 0.63s 0.64s
Check Time 5.20s (± 0.25%) 5.17s (± 0.47%) -0.03s (- 0.58%) 5.11s 5.24s
Emit Time 2.88s (± 1.17%) 2.91s (± 0.79%) +0.03s (+ 1.04%) 2.87s 2.97s
Total Time 10.29s (± 0.32%) 10.28s (± 0.41%) -0.01s (- 0.10%) 10.20s 10.40s
TFS - node (v14.15.1, x64)
Memory used 279,354k (± 0.01%) 279,370k (± 0.00%) +16k (+ 0.01%) 279,347k 279,400k
Parse Time 1.33s (± 1.24%) 1.34s (± 1.22%) +0.01s (+ 0.68%) 1.31s 1.37s
Bind Time 0.59s (± 0.58%) 0.59s (± 0.76%) +0.00s (+ 0.17%) 0.58s 0.60s
Check Time 5.08s (± 0.35%) 5.05s (± 0.27%) -0.03s (- 0.59%) 5.01s 5.07s
Emit Time 3.09s (± 1.34%) 3.07s (± 0.70%) -0.02s (- 0.61%) 3.03s 3.13s
Total Time 10.10s (± 0.50%) 10.06s (± 0.37%) -0.04s (- 0.38%) 9.96s 10.14s
material-ui - node (v14.15.1, x64)
Memory used 430,743k (± 0.01%) 430,733k (± 0.01%) -10k (- 0.00%) 430,668k 430,789k
Parse Time 1.87s (± 0.48%) 1.87s (± 0.57%) +0.00s (+ 0.16%) 1.85s 1.90s
Bind Time 0.53s (± 0.63%) 0.54s (± 1.42%) +0.01s (+ 0.94%) 0.53s 0.56s
Check Time 12.32s (± 0.82%) 12.34s (± 0.81%) +0.02s (+ 0.15%) 12.16s 12.55s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 14.72s (± 0.70%) 14.75s (± 0.71%) +0.03s (+ 0.20%) 14.56s 14.99s
xstate - node (v14.15.1, x64)
Memory used 504,217k (± 0.01%) 504,236k (± 0.01%) +19k (+ 0.00%) 504,189k 504,339k
Parse Time 2.62s (± 1.03%) 2.63s (± 0.54%) +0.01s (+ 0.42%) 2.60s 2.66s
Bind Time 0.84s (± 0.95%) 0.83s (± 0.91%) -0.01s (- 0.83%) 0.82s 0.85s
Check Time 1.47s (± 0.60%) 1.47s (± 0.40%) +0.00s (+ 0.27%) 1.46s 1.49s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.00s (± 0.52%) 5.01s (± 0.24%) +0.01s (+ 0.28%) 4.98s 5.03s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-131-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 51593 10
Baseline main 10

TSServer

Comparison Report - main..51593
Metric main 51593 Delta Best Worst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,053ms (± 0.70%) 1,058ms (± 1.06%) +5ms (+ 0.45%) 1,034ms 1,089ms
Req 2 - geterr 2,590ms (± 0.95%) 2,594ms (± 1.01%) +5ms (+ 0.17%) 2,539ms 2,652ms
Req 3 - references 165ms (± 0.82%) 165ms (± 0.76%) 0ms ( 0.00%) 162ms 167ms
Req 4 - navto 138ms (± 0.83%) 139ms (± 0.65%) +1ms (+ 0.43%) 137ms 141ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 60ms (± 2.69%) 61ms (± 1.73%) +1ms (+ 1.99%) 59ms 64ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,105ms (± 0.82%) 1,111ms (± 0.53%) +6ms (+ 0.56%) 1,102ms 1,125ms
Req 2 - geterr 1,599ms (± 0.69%) 1,598ms (± 0.60%) -0ms (- 0.01%) 1,583ms 1,631ms
Req 3 - references 168ms (± 0.73%) 169ms (± 0.98%) +1ms (+ 0.54%) 167ms 175ms
Req 4 - navto 151ms (± 0.55%) 153ms (± 0.54%) +2ms (+ 1.33%) 151ms 155ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 53ms (± 1.38%) 54ms (± 2.26%) +1ms (+ 2.08%) 52ms 58ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,505ms (± 0.69%) 1,518ms (± 1.16%) +13ms (+ 0.84%) 1,493ms 1,574ms
Req 2 - geterr 555ms (± 0.80%) 555ms (± 0.94%) +0ms (+ 0.02%) 544ms 570ms
Req 3 - references 58ms (± 1.76%) 59ms (± 2.58%) +1ms (+ 1.20%) 57ms 63ms
Req 4 - navto 197ms (± 0.65%) 196ms (± 0.74%) -1ms (- 0.41%) 194ms 199ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 212ms (± 1.52%) 216ms (± 1.34%) +3ms (+ 1.56%) 209ms 220ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,305ms (± 0.67%) 1,313ms (± 0.54%) +8ms (+ 0.63%) 1,291ms 1,326ms
Req 2 - geterr 3,218ms (± 0.89%) 3,218ms (± 1.11%) +0ms (+ 0.00%) 3,109ms 3,274ms
Req 3 - references 191ms (± 1.01%) 190ms (± 0.89%) -1ms (- 0.37%) 187ms 195ms
Req 4 - navto 151ms (± 0.96%) 152ms (± 0.78%) +0ms (+ 0.26%) 149ms 154ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 60ms (± 4.92%) 63ms (± 6.47%) +3ms (+ 5.50%) 57ms 72ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,386ms (± 0.91%) 1,399ms (± 0.61%) +13ms (+ 0.93%) 1,381ms 1,415ms
Req 2 - geterr 2,103ms (± 0.52%) 2,104ms (± 0.56%) +1ms (+ 0.06%) 2,066ms 2,128ms
Req 3 - references 200ms (± 0.90%) 200ms (± 0.50%) +0ms (+ 0.10%) 198ms 203ms
Req 4 - navto 166ms (± 1.72%) 167ms (± 1.51%) +2ms (+ 1.09%) 162ms 174ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 57ms (± 2.14%) 56ms (± 1.88%) -1ms (- 0.88%) 55ms 60ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,829ms (± 0.34%) 1,830ms (± 0.47%) +1ms (+ 0.03%) 1,816ms 1,851ms
Req 2 - geterr 727ms (± 0.56%) 722ms (± 0.62%) -5ms (- 0.67%) 707ms 729ms
Req 3 - references 68ms (± 1.29%) 68ms (± 1.85%) -0ms (- 0.59%) 64ms 70ms
Req 4 - navto 199ms (± 0.68%) 199ms (± 0.98%) -0ms (- 0.15%) 193ms 201ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 255ms (± 0.90%) 255ms (± 0.93%) -1ms (- 0.20%) 247ms 259ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,451ms (± 0.65%) 1,459ms (± 0.71%) +9ms (+ 0.59%) 1,438ms 1,483ms
Req 2 - geterr 3,420ms (± 0.55%) 3,425ms (± 0.62%) +5ms (+ 0.13%) 3,390ms 3,477ms
Req 3 - references 205ms (± 0.90%) 205ms (± 0.52%) 0ms ( 0.00%) 204ms 209ms
Req 4 - navto 161ms (± 0.87%) 162ms (± 0.90%) +1ms (+ 0.68%) 160ms 166ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 58ms (± 1.44%) 58ms (± 1.21%) +1ms (+ 0.87%) 57ms 60ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,528ms (± 0.60%) 1,559ms (± 2.36%) +31ms (+ 2.03%) 1,516ms 1,663ms
Req 2 - geterr 2,280ms (± 0.58%) 2,307ms (± 1.85%) +26ms (+ 1.15%) 2,258ms 2,420ms
Req 3 - references 216ms (± 0.81%) 221ms (± 1.60%) +5ms (+ 2.13%) 214ms 228ms
Req 4 - navto 175ms (± 0.92%) 178ms (± 2.34%) +3ms (+ 1.78%) 169ms 188ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 57ms (± 1.32%) 57ms (± 2.58%) +1ms (+ 0.88%) 55ms 60ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,005ms (± 0.66%) 2,012ms (± 0.57%) +7ms (+ 0.35%) 1,979ms 2,030ms
Req 2 - geterr 745ms (± 0.49%) 748ms (± 0.61%) +4ms (+ 0.47%) 738ms 757ms
Req 3 - references 72ms (± 0.82%) 73ms (± 1.11%) +1ms (+ 0.83%) 71ms 75ms
Req 4 - navto 218ms (± 0.90%) 220ms (± 0.68%) +2ms (+ 0.78%) 217ms 224ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 275ms (± 2.18%) 273ms (± 1.63%) -2ms (- 0.62%) 267ms 286ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-131-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 51593 10
Baseline main 10

Startup

Comparison Report - main..51593
Metric main 51593 Delta Best Worst
tsc-startup - node (v16.17.1, x64)
Execution time 117.68ms (± 0.38%) 119.59ms (± 0.58%) +1.91ms (+ 1.62%) 116.07ms 125.04ms
tsserver-startup - node (v16.17.1, x64)
Execution time 198.48ms (± 0.31%) 200.01ms (± 0.48%) +1.54ms (+ 0.77%) 195.43ms 211.17ms
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 192.03ms (± 0.31%) 193.69ms (± 0.44%) +1.66ms (+ 0.86%) 189.28ms 202.48ms
typescript-startup - node (v16.17.1, x64)
Execution time 177.72ms (± 0.36%) 180.77ms (± 0.38%) +3.05ms (+ 1.71%) 175.15ms 186.66ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-131-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 51593 10
Baseline main 10

Developer Information:

Download Benchmark

@andrewbranch
Copy link
Member

looks like the impact might actually be visible

It was probably just a coincidence in the noise.

@sheetalkamat sheetalkamat merged commit 9f93c67 into main Nov 29, 2022
@sheetalkamat sheetalkamat deleted the delayedVersionPaths branch November 29, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

@weswigham weswigham Awaiting requested review from weswigham

Assignees

@sheetalkamat sheetalkamat

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sheetalkamat @andrewbranch @typescript-bot