Skip to content

Assert if a node has been bound more than once #50069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Assert if a node has been bound more than once #50069

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
500e4ad
Assert if a node has been bound more than once
jakebailey Jul 27, 2022
33845c7
Do not bind children early in JSDocClassTag
jakebailey Oct 6, 2022
24a7f73
Merge branch 'main' into assert-on-double-bind
jakebailey Nov 9, 2022
d2a18c2
Merge branch 'main' into assert-on-double-bind
jakebailey Mar 9, 2023
59d9b13
Fix bad merge
jakebailey Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/compiler/binder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,6 +547,7 @@ function createBinder(): (file: SourceFile, options: CompilerOptions) => void {
var unreachableFlow: FlowNode = { flags: FlowFlags.Unreachable };
var reportedUnreachableFlow: FlowNode = { flags: FlowFlags.Unreachable };
var bindBinaryExpressionFlow = createBindBinaryExpressionFlow();
var alreadyBound: Set<Node>;
/* eslint-enable no-var */

return bindSourceFile;
Expand All @@ -567,6 +568,7 @@ function createBinder(): (file: SourceFile, options: CompilerOptions) => void {
inStrictMode = bindInStrictMode(file, opts);
classifiableNames = new Set();
symbolCount = 0;
alreadyBound = new Set();

Symbol = objectAllocator.getSymbolConstructor();

Expand Down Expand Up @@ -604,6 +606,7 @@ function createBinder(): (file: SourceFile, options: CompilerOptions) => void {
hasExplicitReturn = false;
inAssignmentPattern = false;
emitFlags = NodeFlags.None;
alreadyBound = undefined!;
}

function bindInStrictMode(file: SourceFile, opts: CompilerOptions): boolean {
Expand Down Expand Up @@ -2027,7 +2030,7 @@ function createBinder(): (file: SourceFile, options: CompilerOptions) => void {
}

function bindJSDocClassTag(node: JSDocClassTag) {
bindEachChild(node);
// bindEachChild(node);
const host = getHostSignatureFromJSDoc(node);
if (host && host.kind !== SyntaxKind.MethodDeclaration) {
addDeclarationToSymbol(host.symbol, host, SymbolFlags.Class);
Expand Down Expand Up @@ -2640,6 +2643,10 @@ function createBinder(): (file: SourceFile, options: CompilerOptions) => void {
if (!node) {
return;
}

Debug.assert(!alreadyBound.has(node), "This node has already been bound.");
alreadyBound.add(node);

setParent(node, parent);
if (tracing) (node as TracingNode).tracingPath = file.path;
const saveInStrictMode = inStrictMode;
Expand Down