Copy type parameters to function with @type tag #49960
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, type references to generic types would fail to copy type parameters from type references in an
@typetag. Now the typeparameter is copied.
Note that I left 3 places in the checker unchanged, even though they should technically also get type parameters from type references:
thiscorrectly in a typedef, as far as I can tell.I'm experimenting with (1) but this fix makes it usable from the call site at least, and fixes the original bug.
Fixes #49039