Skip to content

Unify default import resolution across specifier target codepaths #49814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 19, 2022
Merged

Unify default import resolution across specifier target codepaths #49814

merged 3 commits into from
Aug 19, 2022

Conversation

@weswigham
Copy link
Member

@weswigham weswigham commented Jul 6, 2022

Fixes #49567

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 6, 2022
andrewbranch
andrewbranch reviewed Jul 7, 2022
View reviewed changes
@chentsulin
Copy link

chentsulin commented Aug 18, 2022 •
edited
Loading

@weswigham Is there any chance to move this PR forward? The behavior confused a lot of people who are trying to use TS with ESM. Love to see if there are any updates 😁

@weswigham weswigham merged commit 05d7d6b into microsoft:main Aug 19, 2022
@chentsulin
Copy link

chentsulin commented Aug 30, 2022

How about cherry-picking this fix into the 4.8 branch? I found it still a problem in new released 4.8.2.

@RyanCavanaugh
Copy link
Member

RyanCavanaugh commented Aug 30, 2022

@typescript-bot cherry-pick this to release-4.8

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 30, 2022 •
edited
Loading

Heya @RyanCavanaugh, I've started to run the task to cherry-pick this into release-4.8 on this PR at cf010b5. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 30, 2022

Hey @RyanCavanaugh, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.8 manually.

@weswigham weswigham mentioned this pull request Aug 31, 2022
Merged
@weswigham
Copy link
Member Author

weswigham commented Sep 1, 2022

@typescript-bot cherry-pick this to release-4.8

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 1, 2022 •
edited
Loading

Heya @weswigham, I've started to run the task to cherry-pick this into release-4.8 on this PR at cf010b5. You can monitor the build here.

@typescript-bot typescript-bot mentioned this pull request Sep 1, 2022
Merged
@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 1, 2022

Hey @weswigham, I've opened #50578 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Sep 1, 2022
@weswigham @typescript-bot
Cherry-pick PR microsoft#49814 into release-4.8
13280de 
Component commits:
e2d22fa Unify default import resolution across specifier target codepaths

b341699 Merge main into branch

cf010b5 Use differing type aliases, per request
weswigham added a commit that referenced this pull request Sep 1, 2022
@weswigham
Cherry-pick PR #49814 into release-4.8 (#50578)
4b7a7b5 
Component commits:
e2d22fa Unify default import resolution across specifier target codepaths

b341699 Merge main into branch

cf010b5 Use differing type aliases, per request

Co-authored-by: Wesley Wigham <[email protected]>
@andrewbranch andrewbranch added this to the TypeScript 4.8.3 milestone Sep 1, 2022
@andrewbranch andrewbranch mentioned this pull request Dec 13, 2022
Closed
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewbranch andrewbranch andrewbranch left review comments

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

@sheetalkamat sheetalkamat sheetalkamat approved these changes

Assignees

@weswigham weswigham

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

PR Backlog
Archived in project

Milestone

TypeScript 4.8.3

Development

Successfully merging this pull request may close these issues.

Import named default is typed differently than default import (with moduleResolution: node16)

6 participants

@weswigham @chentsulin @RyanCavanaugh @typescript-bot @andrewbranch @sheetalkamat