Skip to content

Fix parser TODO #49679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2022
Merged

Fix parser TODO #49679

merged 1 commit into from
Jun 27, 2022

Conversation

@andrewbranch
Copy link
Member

@andrewbranch andrewbranch commented Jun 24, 2022

No description provided.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 24, 2022
@andrewbranch
Copy link
Member Author

andrewbranch commented Jun 24, 2022

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 24, 2022 •
edited
Loading

Heya @andrewbranch, I've started to run the perf test suite on this PR at 8e5e765. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 24, 2022

@andrewbranch
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..49679

Metric main 49679 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 359,599k (± 0.03%) 359,652k (± 0.02%) +53k (+ 0.01%) 359,499k 359,769k
Parse Time 2.12s (± 0.59%) 2.09s (± 0.43%) -0.03s (- 1.42%) 2.07s 2.11s
Bind Time 0.90s (± 0.78%) 0.89s (± 0.62%) -0.01s (- 1.00%) 0.88s 0.90s
Check Time 5.94s (± 0.47%) 5.96s (± 0.46%) +0.02s (+ 0.27%) 5.91s 6.05s
Emit Time 6.13s (± 0.82%) 6.09s (± 0.47%) -0.04s (- 0.62%) 6.04s 6.16s
Total Time 15.09s (± 0.51%) 15.04s (± 0.39%) -0.06s (- 0.38%) 14.95s 15.22s
Compiler-Unions - node (v10.16.3, x64)
Memory used 206,412k (± 0.04%) 206,392k (± 0.03%) -20k (- 0.01%) 206,247k 206,515k
Parse Time 0.84s (± 0.77%) 0.83s (± 0.89%) -0.01s (- 1.43%) 0.81s 0.85s
Bind Time 0.52s (± 1.34%) 0.53s (± 1.29%) +0.00s (+ 0.96%) 0.51s 0.54s
Check Time 8.08s (± 0.52%) 8.03s (± 0.55%) -0.05s (- 0.58%) 7.96s 8.12s
Emit Time 2.50s (± 1.37%) 2.49s (± 1.10%) -0.01s (- 0.20%) 2.44s 2.56s
Total Time 11.95s (± 0.41%) 11.88s (± 0.38%) -0.06s (- 0.52%) 11.77s 11.97s
Monaco - node (v10.16.3, x64)
Memory used 343,938k (± 0.02%) 343,882k (± 0.02%) -57k (- 0.02%) 343,762k 344,021k
Parse Time 1.60s (± 0.57%) 1.58s (± 0.43%) -0.01s (- 0.88%) 1.57s 1.60s
Bind Time 0.77s (± 0.75%) 0.77s (± 0.64%) -0.00s (- 0.52%) 0.76s 0.78s
Check Time 5.93s (± 0.56%) 5.94s (± 0.53%) +0.00s (+ 0.05%) 5.86s 6.02s
Emit Time 3.26s (± 0.56%) 3.24s (± 0.39%) -0.02s (- 0.52%) 3.22s 3.27s
Total Time 11.56s (± 0.37%) 11.53s (± 0.34%) -0.04s (- 0.30%) 11.46s 11.63s
TFS - node (v10.16.3, x64)
Memory used 305,150k (± 0.02%) 305,115k (± 0.02%) -35k (- 0.01%) 304,917k 305,218k
Parse Time 1.29s (± 0.45%) 1.28s (± 0.55%) -0.01s (- 0.62%) 1.26s 1.29s
Bind Time 0.72s (± 0.68%) 0.72s (± 0.83%) +0.00s (+ 0.14%) 0.72s 0.74s
Check Time 5.41s (± 0.48%) 5.39s (± 0.50%) -0.02s (- 0.43%) 5.34s 5.45s
Emit Time 3.42s (± 1.47%) 3.44s (± 1.45%) +0.01s (+ 0.29%) 3.35s 3.57s
Total Time 10.85s (± 0.60%) 10.82s (± 0.63%) -0.02s (- 0.21%) 10.71s 11.03s
material-ui - node (v10.16.3, x64)
Memory used 469,019k (± 0.01%) 469,067k (± 0.01%) +48k (+ 0.01%) 468,939k 469,187k
Parse Time 1.85s (± 0.51%) 1.82s (± 0.73%) -0.03s (- 1.73%) 1.80s 1.86s
Bind Time 0.69s (± 1.12%) 0.69s (± 1.50%) +0.00s (+ 0.14%) 0.66s 0.70s
Check Time 14.57s (± 0.80%) 14.42s (± 0.34%) -0.15s (- 1.00%) 14.33s 14.54s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 17.11s (± 0.72%) 16.94s (± 0.31%) -0.18s (- 1.04%) 16.84s 17.07s
xstate - node (v10.16.3, x64)
Memory used 577,833k (± 0.02%) 581,072k (± 1.25%) +3,240k (+ 0.56%) 577,684k 610,460k
Parse Time 2.63s (± 0.47%) 2.59s (± 0.39%) -0.04s (- 1.44%) 2.57s 2.62s
Bind Time 1.04s (± 1.16%) 1.02s (± 0.66%) -0.01s (- 1.16%) 1.01s 1.04s
Check Time 1.55s (± 0.80%) 1.54s (± 0.62%) -0.02s (- 1.09%) 1.51s 1.56s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.29s (± 0.51%) 5.22s (± 0.34%) -0.07s (- 1.29%) 5.19s 5.27s
Angular - node (v12.1.0, x64)
Memory used 337,139k (± 0.05%) 337,069k (± 0.02%) -70k (- 0.02%) 336,887k 337,195k
Parse Time 2.11s (± 1.11%) 2.08s (± 0.45%) -0.03s (- 1.47%) 2.06s 2.11s
Bind Time 0.86s (± 0.57%) 0.86s (± 0.60%) -0.00s (- 0.35%) 0.85s 0.87s
Check Time 5.80s (± 0.48%) 5.77s (± 0.40%) -0.03s (- 0.59%) 5.72s 5.81s
Emit Time 6.41s (± 0.84%) 6.31s (± 0.51%) -0.10s (- 1.59%) 6.24s 6.38s
Total Time 15.19s (± 0.48%) 15.02s (± 0.27%) -0.17s (- 1.15%) 14.95s 15.13s
Compiler-Unions - node (v12.1.0, x64)
Memory used 193,784k (± 0.13%) 194,083k (± 0.08%) +299k (+ 0.15%) 193,657k 194,350k
Parse Time 0.84s (± 0.91%) 0.83s (± 0.98%) -0.01s (- 0.72%) 0.81s 0.85s
Bind Time 0.54s (± 0.96%) 0.55s (± 0.91%) +0.00s (+ 0.74%) 0.54s 0.56s
Check Time 7.55s (± 0.76%) 7.53s (± 0.55%) -0.02s (- 0.25%) 7.47s 7.64s
Emit Time 2.52s (± 1.16%) 2.52s (± 0.93%) +0.00s (+ 0.04%) 2.48s 2.59s
Total Time 11.45s (± 0.64%) 11.43s (± 0.48%) -0.02s (- 0.21%) 11.33s 11.56s
Monaco - node (v12.1.0, x64)
Memory used 326,867k (± 0.02%) 326,872k (± 0.01%) +5k (+ 0.00%) 326,751k 326,952k
Parse Time 1.59s (± 0.89%) 1.56s (± 0.88%) -0.02s (- 1.45%) 1.54s 1.59s
Bind Time 0.76s (± 0.53%) 0.75s (± 0.40%) -0.01s (- 1.18%) 0.75s 0.76s
Check Time 5.80s (± 0.52%) 5.76s (± 0.41%) -0.05s (- 0.78%) 5.71s 5.82s
Emit Time 3.31s (± 0.95%) 3.28s (± 0.70%) -0.03s (- 1.00%) 3.22s 3.32s
Total Time 11.46s (± 0.48%) 11.35s (± 0.37%) -0.12s (- 1.00%) 11.24s 11.46s
TFS - node (v12.1.0, x64)
Memory used 289,712k (± 0.01%) 289,712k (± 0.01%) -0k (- 0.00%) 289,636k 289,788k
Parse Time 1.31s (± 0.57%) 1.29s (± 0.78%) -0.02s (- 1.76%) 1.27s 1.31s
Bind Time 0.73s (± 0.89%) 0.72s (± 0.92%) -0.00s (- 0.69%) 0.71s 0.74s
Check Time 5.32s (± 0.37%) 5.31s (± 0.32%) -0.00s (- 0.08%) 5.26s 5.35s
Emit Time 3.51s (± 0.93%) 3.50s (± 0.85%) -0.01s (- 0.26%) 3.44s 3.57s
Total Time 10.87s (± 0.33%) 10.83s (± 0.37%) -0.04s (- 0.36%) 10.70s 10.89s
material-ui - node (v12.1.0, x64)
Memory used 448,023k (± 0.06%) 448,163k (± 0.01%) +140k (+ 0.03%) 448,054k 448,267k
Parse Time 1.86s (± 0.51%) 1.82s (± 0.48%) -0.04s (- 2.05%) 1.80s 1.84s
Bind Time 0.68s (± 1.00%) 0.68s (± 0.66%) -0.01s (- 0.88%) 0.67s 0.69s
Check Time 13.12s (± 1.00%) 12.94s (± 0.52%) -0.18s (- 1.35%) 12.81s 13.10s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.66s (± 0.87%) 15.44s (± 0.42%) -0.22s (- 1.42%) 15.29s 15.58s
xstate - node (v12.1.0, x64)
Memory used 543,334k (± 0.02%) 546,492k (± 1.31%) +3,158k (+ 0.58%) 543,145k 575,426k
Parse Time 2.60s (± 0.47%) 2.54s (± 0.49%) -0.06s (- 2.16%) 2.52s 2.57s
Bind Time 1.04s (± 0.73%) 1.03s (± 1.41%) -0.01s (- 0.96%) 1.00s 1.07s
Check Time 1.50s (± 0.78%) 1.48s (± 0.72%) -0.01s (- 0.94%) 1.46s 1.51s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.21s (± 0.42%) 5.13s (± 0.36%) -0.08s (- 1.48%) 5.09s 5.17s
Angular - node (v14.15.1, x64)
Memory used 335,332k (± 0.01%) 335,244k (± 0.01%) -88k (- 0.03%) 335,186k 335,294k
Parse Time 2.09s (± 0.48%) 2.05s (± 0.33%) -0.03s (- 1.58%) 2.04s 2.07s
Bind Time 0.90s (± 0.54%) 0.90s (± 0.50%) -0.01s (- 0.66%) 0.89s 0.91s
Check Time 5.76s (± 0.46%) 5.73s (± 0.39%) -0.03s (- 0.54%) 5.68s 5.78s
Emit Time 6.43s (± 0.60%) 6.36s (± 0.35%) -0.07s (- 1.07%) 6.29s 6.40s
Total Time 15.18s (± 0.31%) 15.04s (± 0.23%) -0.14s (- 0.94%) 14.94s 15.11s
Compiler-Unions - node (v14.15.1, x64)
Memory used 193,341k (± 0.51%) 192,647k (± 0.01%) -694k (- 0.36%) 192,578k 192,705k
Parse Time 0.85s (± 0.68%) 0.85s (± 0.80%) -0.00s (- 0.12%) 0.83s 0.86s
Bind Time 0.57s (± 0.78%) 0.57s (± 0.78%) +0.00s (+ 0.00%) 0.56s 0.58s
Check Time 7.69s (± 0.77%) 7.63s (± 0.28%) -0.06s (- 0.81%) 7.58s 7.66s
Emit Time 2.51s (± 0.55%) 2.50s (± 0.90%) -0.01s (- 0.36%) 2.46s 2.55s
Total Time 11.62s (± 0.55%) 11.55s (± 0.33%) -0.07s (- 0.59%) 11.47s 11.62s
Monaco - node (v14.15.1, x64)
Memory used 325,613k (± 0.01%) 325,620k (± 0.00%) +8k (+ 0.00%) 325,578k 325,649k
Parse Time 1.58s (± 0.66%) 1.58s (± 0.71%) +0.00s (+ 0.19%) 1.56s 1.61s
Bind Time 0.80s (± 0.91%) 0.79s (± 0.84%) -0.01s (- 1.00%) 0.78s 0.81s
Check Time 5.70s (± 0.53%) 5.68s (± 0.45%) -0.02s (- 0.35%) 5.64s 5.75s
Emit Time 3.37s (± 0.98%) 3.34s (± 0.41%) -0.03s (- 0.83%) 3.31s 3.37s
Total Time 11.45s (± 0.51%) 11.40s (± 0.33%) -0.05s (- 0.46%) 11.33s 11.47s
TFS - node (v14.15.1, x64)
Memory used 288,761k (± 0.01%) 288,768k (± 0.01%) +7k (+ 0.00%) 288,735k 288,824k
Parse Time 1.33s (± 0.61%) 1.32s (± 1.39%) -0.01s (- 0.60%) 1.28s 1.36s
Bind Time 0.75s (± 0.97%) 0.76s (± 1.82%) +0.00s (+ 0.53%) 0.74s 0.80s
Check Time 5.35s (± 0.57%) 5.31s (± 0.51%) -0.04s (- 0.71%) 5.26s 5.38s
Emit Time 3.60s (± 2.32%) 3.57s (± 2.09%) -0.03s (- 0.92%) 3.42s 3.71s
Total Time 11.04s (± 0.89%) 10.96s (± 0.74%) -0.07s (- 0.64%) 10.79s 11.12s
material-ui - node (v14.15.1, x64)
Memory used 446,348k (± 0.01%) 446,211k (± 0.06%) -137k (- 0.03%) 445,208k 446,357k
Parse Time 1.89s (± 0.31%) 1.87s (± 0.36%) -0.03s (- 1.37%) 1.86s 1.88s
Bind Time 0.72s (± 0.69%) 0.73s (± 1.06%) +0.00s (+ 0.55%) 0.70s 0.74s
Check Time 13.20s (± 0.74%) 13.07s (± 0.48%) -0.12s (- 0.93%) 12.98s 13.23s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.82s (± 0.63%) 15.67s (± 0.42%) -0.15s (- 0.93%) 15.56s 15.83s
xstate - node (v14.15.1, x64)
Memory used 541,061k (± 0.00%) 541,000k (± 0.00%) -61k (- 0.01%) 540,938k 541,061k
Parse Time 2.64s (± 0.48%) 2.59s (± 0.47%) -0.05s (- 1.89%) 2.57s 2.62s
Bind Time 1.17s (± 0.86%) 1.15s (± 0.67%) -0.01s (- 1.29%) 1.14s 1.17s
Check Time 1.54s (± 0.34%) 1.53s (± 0.34%) -0.01s (- 0.65%) 1.52s 1.54s
Emit Time 0.07s (± 3.14%) 0.07s (± 3.14%) 0.00s ( 0.00%) 0.07s 0.08s
Total Time 5.42s (± 0.36%) 5.35s (± 0.29%) -0.08s (- 1.44%) 5.31s 5.38s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v10.16.3, x64)
  • xstate - node (v12.1.0, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 49679 10
Baseline main 10

Developer Information:

Download Benchmark

@andrewbranch
Copy link
Member Author

andrewbranch commented Jun 24, 2022

A little disappointed because I saw better results locally, but this is still worth taking, in my opinion.

@andrewbranch andrewbranch marked this pull request as ready for review June 24, 2022 23:17
jakebailey
jakebailey approved these changes Jun 25, 2022
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@andrewbranch andrewbranch merged commit 2bc91a6 into microsoft:main Jun 27, 2022
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakebailey jakebailey jakebailey approved these changes

+1 more reviewer

@rbuckton rbuckton rbuckton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@andrewbranch andrewbranch

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewbranch @typescript-bot @rbuckton @jakebailey