When source file is redirected, set the prototype correctly in node factory #48862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
| libReferences: readonly FileReference[] | ||
| ) { | ||
| const node = baseFactory.createBaseSourceFileNode(SyntaxKind.SourceFile) as Mutable<SourceFile>; | ||
| const node = (source.redirectInfo ? Object.create(source.redirectInfo.redirectTarget) : baseFactory.createBaseSourceFileNode(SyntaxKind.SourceFile)) as Mutable<SourceFile>; |
Member
There was a problem hiding this comment.
Is setting the prototype pretty typical in factory functions and whatnot @rbuckton?
Contributor
There was a problem hiding this comment.
We generally don't, but apparently we use Object.create in program.ts for redirected source files.
rbuckton
approved these changes
May 4, 2022
Contributor
rbuckton
left a comment
rbuckton
left a comment
There was a problem hiding this comment.
I'm concerned with the fact redirection uses Object.create to wrap an existing source file because its easily overlooked. However, since this is already an existing behavior this change seems fine.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48039