Try making the apparent type of unknown be unknown #47517
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
jakebailey
commented
Jan 19, 2022
| @@ -9,7 +9,7 @@ tests/cases/compiler/genericConditionalConstrainedToUnknownNotAssignableToConcre | |||
| Type 'unknown' is not assignable to type 'A'. | |||
| Type 'ReturnType<FunctionsObj<T>[string]>' is not assignable to type 'A'. | |||
| Type 'unknown' is not assignable to type 'A'. | |||
| Property 'x' is missing in type '{}' but required in type 'A'. | |||
| Type 'unknown' is not assignable to type 'A'. | |||
There was a problem hiding this comment.
It's very odd that this prints out twice.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test PR to show the effect of the change proposed in #47494.
Most of this is okay (especially the removal of errors complaining about specific fields), but there are a couple concerning things that I'll leave a comment on, specifically:
Type 'unknown' is not assignable to ...being printed twicetoStringon things.