Skip to content

Properly support scoped package self name lookups #46212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2021
Merged

Properly support scoped package self name lookups #46212

merged 1 commit into from
Oct 5, 2021

Conversation

weswigham
Copy link
Member

Fixes #46175

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Oct 4, 2021
andrewbranch
andrewbranch approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔭 🔬

@weswigham weswigham merged commit 1cee973 into microsoft:main Oct 5, 2021
@sandersn sandersn deleted the scoped-package-self-names branch October 8, 2021 22:39
@benjie benjie mentioned this pull request Nov 10, 2021
Closed
@andrewbranch andrewbranch mentioned this pull request Nov 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

@sandersn sandersn Awaiting requested review from sandersn

Assignees

@weswigham weswigham

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unrecognized self-referencing @scope/package
3 participants
@weswigham @andrewbranch @typescript-bot