Better error spans for object literal excess properties #4552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
There was a problem hiding this comment.
I suppose I have some reservations about this, but what would fix this is to change the topmost message to "The type argument for type parameter 'T' cannot be inferred from the usage _of 'foo'_."
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
Member
|
Awesome 👍 |
DanielRosenwasser
added a commit
that referenced
this pull request
Sep 3, 2015
…ExcessProperties Better error spans for object literal excess properties
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to redirect the error message span for an excess property error from the usual target of the assignment to the invalid property itself. I believe this is a positive change in that the resulting error span is actually helpful for users.