Skip to content

Fix(DeprecationWarning): Work around in testRunner #44925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix(DeprecationWarning): Work around in testRunner #44925

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a978c9
Fix(DeprecationWarning): Work around in testRunner
Luxcium Jul 7, 2021
030e573
style(fix): remove extra formatting
Luxcium Jul 7, 2021
b75020f
style(fix): add extra newline at end of file
Luxcium Jul 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/testRunner/parallel/worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,14 @@ namespace Harness.Parallel.Worker {
const errors: ErrorInfo[] = [];
const passes: TestInfo[] = [];
const start = +new Date();
const runner = new Mocha.Runner(suite, /*delay*/ false);
/* DeprecationWarning: "Runner(suite: Suite, delay: boolean)" is deprecated. Use "Runner(suite: Suite, {delay: boolean})" instead.*/
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary work around because Mocha Type Definition is not up to date

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I ran npm i @types/mocha@latest locally and it was updated to a version that has RunnerOptions | boolean. So this workaround shouldn't be necessary anymore @Luxcium 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll close this then.

const runner = new Mocha.Runner(
suite,
// TODO: Remove `as any as boolean` when @types/mocha is version 9.x
{
delay: false,
} as any as boolean /* Because Mocha is out of sync with is definition 9.0.2/8.2 */
);

runner
.on("start", () => {
Expand Down