Skip to content

Make files safe for Windows #44651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 18, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions src/testRunner/unittests/tscWatch/emitAndErrorUpdates.ts
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ console.log(b.c.d);`
],
});
}

describe("updates errors when deep import file changes", () => {
const bFile: File = {
path: `${projectRoot}/b.ts`,
Expand All @@ -144,12 +143,11 @@ export class B
}`
};
verifyDeepImportChange(
"updates errors when deep import file changes",
"errors for .ts change",
bFile,
cFile
);
});

describe("updates errors when deep import through declaration file changes", () => {
const bFile: File = {
path: `${projectRoot}/b.d.ts`,
Expand All @@ -167,7 +165,7 @@ export class B
}`
};
verifyDeepImportChange(
"updates errors when deep import through declaration file changes",
"errors for .d.ts change",
bFile,
cFile
);
Expand Down Expand Up @@ -236,7 +234,6 @@ getPoint().c.x;`
]
});
});

describe("updates errors when file transitively exported file changes", () => {
const config: File = {
path: `${projectRoot}/tsconfig.json`,
Expand Down Expand Up @@ -287,7 +284,7 @@ export class Data {

function verifyTransitiveExports(subScenario: string, files: readonly File[]) {
verifyEmitAndErrorUpdates({
subScenario: `updates errors when file transitively exported file changes/${subScenario}`,
subScenario: `transitive exports/${subScenario}`,
files: () => [lib1ToolsInterface, lib1ToolsPublic, app, lib2Public, lib1Public, ...files],
configFile: () => config,
changes: [
Expand All @@ -311,11 +308,10 @@ export class Data {
}
describe("when there are no circular import and exports", () => {
verifyTransitiveExports(
"when there are no circular import and exports",
"no circular import/export",
[lib2Data]
);
});

describe("when there are circular import and exports", () => {
const lib2Data: File = {
path: `${projectRoot}/lib2/data.ts`,
Expand All @@ -337,7 +333,7 @@ export class Data2 {
}`
};
verifyTransitiveExports(
"when there are circular import and exports",
"yes circular import/exports",
[lib2Data, lib2Data2]
);
});
Expand Down
Loading