Reenable Fourslash tests after they have been accidentlly disabled #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This is why whenever you are making automation changes you should start by editing a few tests of relevant kinds to be failing :) Alternatively we need tests for our automation. |
Contributor
|
👍 |
… any requests with fullTypeCheck=false and we cache any result
mhegazy
added a commit
that referenced
this pull request
Aug 13, 2014
Reenable Fourslash tests after they have been accidentlly disabled
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were compiling fourslah tests without --out flag, and executing the output of the last file "fourslash.ts", for all tests, effectively disabling the tests.. re-enabling and fixing issues that running the tests uncovered.