Loosen up the first argument type for String.raw
#43610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [String.raw spec](https://tc39.es/ecma262/#sec-string.raw) uses just the `raw` property of its first argument, which is a useful way of using it in user-defined tag functions to do the work of interleaving strings and values as well as converting the values to strings. Fixes microsoft#43609.
typescript-bot
added
Author: Team
For Uncommitted Bug
| * @param template A well-formed template string call site representation. | ||
| * @param substitutions A set of substitution values. | ||
| */ | ||
| raw(template: TemplateStringsArray, ...substitutions: any[]): string; | ||
| raw(template: { raw: readonly string[] | ArrayLike<string>}, ...substitutions: any[]): string; |
There was a problem hiding this comment.
I wouldn't necessarily include ArrayLike - I'd keep it simple here personally
There was a problem hiding this comment.
@DanielRosenwasser: I agree that it would be better (like many other places), but I followed what the language is doing
> String.raw({raw: {1: "y", 0: "x", length: 2}}, [3])
"x3y"
|
@DanielRosenwasser: ping |
DanielRosenwasser
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The String.raw spec uses just
the
rawproperty of its first argument, which is a useful way of usingit in user-defined tag functions to do the work of interleaving strings
and values as well as converting the values to strings.
Fixes #43609.