Skip to content

Add a reusable '0' literal for the module transform #43543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add a reusable '0' literal for the module transform #43543

wants to merge 1 commit into from

Conversation

rbuckton
Copy link
Contributor

@rbuckton rbuckton commented Apr 6, 2021

Investigating improving performance of #35877

Related #43486

@rbuckton
Copy link
Contributor Author

rbuckton commented Apr 6, 2021

@typescript-bot perf test

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Apr 6, 2021
@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 6, 2021 •
edited
Loading

Heya @rbuckton, I've started to run the perf test suite on this PR at f0ae577. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@rbuckton
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..43543

Metric master 43543 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 344,904k (± 0.02%) 0k 🟩-344,904k (-100.00%) 0k 0k
Parse Time 1.93s (± 0.41%) 0.00s 🟩-1.93s (-100.00%) 0.00s 0.00s
Bind Time 0.83s (± 0.87%) 0.00s 🟩-0.83s (-100.00%) 0.00s 0.00s
Check Time 5.09s (± 0.26%) 0.00s 🟩-5.09s (-100.00%) 0.00s 0.00s
Emit Time 5.91s (± 0.60%) 0.00s 🟩-5.91s (-100.00%) 0.00s 0.00s
Total Time 13.76s (± 0.31%) 0.00s 🟩-13.76s (-100.00%) 0.00s 0.00s
Compiler-Unions - node (v10.16.3, x64)
Memory used 203,345k (± 0.03%) 203,366k (± 0.04%) +22k (+ 0.01%) 203,176k 203,523k
Parse Time 0.78s (± 0.43%) 0.78s (± 0.85%) 0.00s ( 0.00%) 0.77s 0.80s
Bind Time 0.52s (± 1.13%) 0.52s (± 1.56%) -0.00s (- 0.19%) 0.50s 0.54s
Check Time 7.46s (± 0.58%) 7.46s (± 0.51%) -0.01s (- 0.12%) 7.38s 7.57s
Emit Time 2.60s (± 1.35%) 2.57s (± 0.71%) -0.03s (- 1.00%) 2.54s 2.61s
Total Time 11.37s (± 0.55%) 11.33s (± 0.38%) -0.04s (- 0.36%) 11.25s 11.42s
Monaco - node (v10.16.3, x64)
Memory used 342,642k (± 0.02%) 0k 🟩-342,642k (-100.00%) 0k 0k
Parse Time 1.55s (± 0.52%) 0.00s 🟩-1.55s (-100.00%) 0.00s 0.00s
Bind Time 0.74s (± 0.92%) 0.00s 🟩-0.74s (-100.00%) 0.00s 0.00s
Check Time 5.26s (± 0.65%) 0.00s 🟩-5.26s (-100.00%) 0.00s 0.00s
Emit Time 3.12s (± 0.41%) 0.00s 🟩-3.12s (-100.00%) 0.00s 0.00s
Total Time 10.67s (± 0.37%) 0.00s 🟩-10.67s (-100.00%) 0.00s 0.00s
TFS - node (v10.16.3, x64)
Memory used 304,257k (± 0.02%) 0k 🟩-304,257k (-100.00%) 0k 0k
Parse Time 1.21s (± 0.48%) 0.00s 🟩-1.21s (-100.00%) 0.00s 0.00s
Bind Time 0.70s (± 0.93%) 0.00s 🟩-0.70s (-100.00%) 0.00s 0.00s
Check Time 4.72s (± 0.54%) 0.00s 🟩-4.72s (-100.00%) 0.00s 0.00s
Emit Time 3.25s (± 1.05%) 0.00s 🟩-3.25s (-100.00%) 0.00s 0.00s
Total Time 9.87s (± 0.38%) 0.00s 🟩-9.87s (-100.00%) 0.00s 0.00s
material-ui - node (v10.16.3, x64)
Memory used 465,406k (± 0.02%) 465,916k (± 0.01%) +509k (+ 0.11%) 465,764k 466,029k
Parse Time 2.00s (± 0.70%) 2.01s (± 0.47%) +0.01s (+ 0.50%) 1.98s 2.03s
Bind Time 0.66s (± 0.98%) 0.65s (± 1.14%) -0.01s (- 0.76%) 0.64s 0.67s
Check Time 14.22s (± 0.36%) 14.19s (± 0.37%) -0.02s (- 0.18%) 14.11s 14.33s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.88s (± 0.29%) 16.85s (± 0.34%) -0.02s (- 0.14%) 16.77s 17.01s
Angular - node (v12.1.0, x64)
Memory used 322,629k (± 0.03%) 0k 🟩-322,629k (-100.00%) 0k 0k
Parse Time 1.92s (± 0.52%) 0.00s 🟩-1.92s (-100.00%) 0.00s 0.00s
Bind Time 0.81s (± 0.55%) 0.00s 🟩-0.81s (-100.00%) 0.00s 0.00s
Check Time 5.00s (± 0.45%) 0.00s 🟩-5.00s (-100.00%) 0.00s 0.00s
Emit Time 5.97s (± 0.41%) 0.00s 🟩-5.97s (-100.00%) 0.00s 0.00s
Total Time 13.69s (± 0.31%) 0.00s 🟩-13.69s (-100.00%) 0.00s 0.00s
Compiler-Unions - node (v12.1.0, x64)
Memory used 190,339k (± 0.16%) 190,464k (± 0.13%) +125k (+ 0.07%) 190,132k 190,934k
Parse Time 0.77s (± 0.89%) 0.77s (± 0.64%) 0.00s ( 0.00%) 0.76s 0.78s
Bind Time 0.53s (± 0.95%) 0.52s (± 0.85%) -0.00s (- 0.57%) 0.51s 0.53s
Check Time 6.95s (± 0.38%) 6.97s (± 0.21%) +0.02s (+ 0.29%) 6.93s 6.99s
Emit Time 2.53s (± 0.89%) 2.54s (± 0.73%) +0.01s (+ 0.43%) 2.49s 2.57s
Total Time 10.76s (± 0.38%) 10.79s (± 0.27%) +0.03s (+ 0.29%) 10.71s 10.86s
Monaco - node (v12.1.0, x64)
Memory used 325,088k (± 0.02%) 0k 🟩-325,088k (-100.00%) 0k 0k
Parse Time 1.53s (± 0.71%) 0.00s 🟩-1.53s (-100.00%) 0.00s 0.00s
Bind Time 0.72s (± 0.56%) 0.00s 🟩-0.72s (-100.00%) 0.00s 0.00s
Check Time 5.07s (± 0.50%) 0.00s 🟩-5.07s (-100.00%) 0.00s 0.00s
Emit Time 3.08s (± 0.47%) 0.00s 🟩-3.08s (-100.00%) 0.00s 0.00s
Total Time 10.40s (± 0.25%) 0.00s 🟩-10.40s (-100.00%) 0.00s 0.00s
TFS - node (v12.1.0, x64)
Memory used 288,785k (± 0.02%) 0k 🟩-288,785k (-100.00%) 0k 0k
Parse Time 1.21s (± 0.58%) 0.00s 🟩-1.21s (-100.00%) 0.00s 0.00s
Bind Time 0.69s (± 0.68%) 0.00s 🟩-0.69s (-100.00%) 0.00s 0.00s
Check Time 4.64s (± 0.57%) 0.00s 🟩-4.64s (-100.00%) 0.00s 0.00s
Emit Time 3.16s (± 0.63%) 0.00s 🟩-3.16s (-100.00%) 0.00s 0.00s
Total Time 9.71s (± 0.44%) 0.00s 🟩-9.71s (-100.00%) 0.00s 0.00s
material-ui - node (v12.1.0, x64)
Memory used 443,470k (± 0.06%) 444,000k (± 0.01%) +530k (+ 0.12%) 443,846k 444,118k
Parse Time 2.03s (± 0.55%) 2.02s (± 0.33%) -0.01s (- 0.44%) 2.00s 2.03s
Bind Time 0.64s (± 0.53%) 0.64s (± 1.04%) +0.00s (+ 0.47%) 0.63s 0.65s
Check Time 12.84s (± 0.49%) 12.85s (± 0.45%) +0.01s (+ 0.07%) 12.76s 12.99s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.51s (± 0.38%) 15.50s (± 0.38%) -0.00s (- 0.01%) 15.39s 15.65s
Angular - node (v14.15.1, x64)
Memory used 321,325k (± 0.01%) 0k 🟩-321,325k (-100.00%) 0k 0k
Parse Time 1.93s (± 0.42%) 0.00s 🟩-1.93s (-100.00%) 0.00s 0.00s
Bind Time 0.86s (± 0.47%) 0.00s 🟩-0.86s (-100.00%) 0.00s 0.00s
Check Time 4.99s (± 0.55%) 0.00s 🟩-4.99s (-100.00%) 0.00s 0.00s
Emit Time 6.29s (± 0.55%) 0.00s 🟩-6.29s (-100.00%) 0.00s 0.00s
Total Time 14.08s (± 0.29%) 0.00s 🟩-14.08s (-100.00%) 0.00s 0.00s
Compiler-Unions - node (v14.15.1, x64)
Memory used 189,403k (± 0.02%) 189,472k (± 0.01%) +69k (+ 0.04%) 189,394k 189,534k
Parse Time 0.80s (± 0.72%) 0.80s (± 0.72%) -0.00s (- 0.00%) 0.79s 0.82s
Bind Time 0.55s (± 0.40%) 0.55s (± 0.66%) +0.00s (+ 0.54%) 0.55s 0.56s
Check Time 7.05s (± 0.47%) 7.04s (± 0.31%) -0.01s (- 0.16%) 7.00s 7.11s
Emit Time 2.55s (± 0.54%) 2.56s (± 0.74%) +0.00s (+ 0.16%) 2.52s 2.60s
Total Time 10.96s (± 0.37%) 10.95s (± 0.33%) -0.01s (- 0.07%) 10.87s 11.01s
Monaco - node (v14.15.1, x64)
Memory used 324,044k (± 0.01%) 0k 🟩-324,044k (-100.00%) 0k 0k
Parse Time 1.56s (± 0.37%) 0.00s 🟩-1.56s (-100.00%) 0.00s 0.00s
Bind Time 0.74s (± 0.49%) 0.00s 🟩-0.74s (-100.00%) 0.00s 0.00s
Check Time 5.03s (± 0.44%) 0.00s 🟩-5.03s (-100.00%) 0.00s 0.00s
Emit Time 3.17s (± 0.53%) 0.00s 🟩-3.17s (-100.00%) 0.00s 0.00s
Total Time 10.50s (± 0.29%) 0.00s 🟩-10.50s (-100.00%) 0.00s 0.00s
TFS - node (v14.15.1, x64)
Memory used 287,658k (± 0.01%) 0k 🟩-287,658k (-100.00%) 0k 0k
Parse Time 1.26s (± 0.67%) 0.00s 🟩-1.26s (-100.00%) 0.00s 0.00s
Bind Time 0.71s (± 0.63%) 0.00s 🟩-0.71s (-100.00%) 0.00s 0.00s
Check Time 4.65s (± 0.40%) 0.00s 🟩-4.65s (-100.00%) 0.00s 0.00s
Emit Time 3.24s (± 0.45%) 0.00s 🟩-3.24s (-100.00%) 0.00s 0.00s
Total Time 9.86s (± 0.22%) 0.00s 🟩-9.86s (-100.00%) 0.00s 0.00s
material-ui - node (v14.15.1, x64)
Memory used 441,589k (± 0.08%) 442,349k (± 0.00%) +760k (+ 0.17%) 442,312k 442,385k
Parse Time 2.09s (± 0.75%) 2.09s (± 0.72%) +0.00s (+ 0.00%) 2.06s 2.13s
Bind Time 0.69s (± 0.80%) 0.69s (± 0.89%) -0.00s (- 0.14%) 0.68s 0.71s
Check Time 13.04s (± 0.82%) 12.93s (± 0.43%) -0.10s (- 0.80%) 12.78s 13.07s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.82s (± 0.72%) 15.71s (± 0.43%) -0.11s (- 0.68%) 15.53s 15.87s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-206-generic
Architecturex64
Available Memory16 GB
Available Memory10 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
Benchmark Name Iterations
Current 43543 10
Baseline master 10

Developer Information:

Download Benchmark

@rbuckton rbuckton force-pushed the reusableZeroLiteral branch from f0ae577 to 5144684 Compare April 6, 2021 02:30
@rbuckton
Copy link
Contributor Author

rbuckton commented Apr 6, 2021

@typescript-bot perf test

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 6, 2021 •
edited
Loading

Heya @rbuckton, I've started to run the perf test suite on this PR at 5144684. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@rbuckton
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..43543

Metric master 43543 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 344,904k (± 0.02%) 344,987k (± 0.03%) +83k (+ 0.02%) 344,764k 345,178k
Parse Time 1.93s (± 0.41%) 1.93s (± 0.49%) +0.00s (+ 0.26%) 1.91s 1.95s
Bind Time 0.83s (± 0.87%) 0.83s (± 0.60%) +0.00s (+ 0.36%) 0.83s 0.85s
Check Time 5.09s (± 0.26%) 5.11s (± 0.35%) +0.02s (+ 0.37%) 5.08s 5.15s
Emit Time 5.91s (± 0.60%) 5.92s (± 0.37%) +0.00s (+ 0.08%) 5.88s 5.98s
Total Time 13.76s (± 0.31%) 13.79s (± 0.32%) +0.03s (+ 0.23%) 13.70s 13.92s
Compiler-Unions - node (v10.16.3, x64)
Memory used 203,345k (± 0.03%) 203,256k (± 0.10%) -89k (- 0.04%) 202,476k 203,539k
Parse Time 0.78s (± 0.43%) 0.79s (± 0.63%) +0.00s (+ 0.26%) 0.78s 0.80s
Bind Time 0.52s (± 1.13%) 0.52s (± 1.54%) -0.01s (- 1.15%) 0.50s 0.53s
Check Time 7.46s (± 0.58%) 7.47s (± 0.37%) +0.01s (+ 0.11%) 7.41s 7.54s
Emit Time 2.60s (± 1.35%) 2.58s (± 0.73%) -0.02s (- 0.73%) 2.54s 2.62s
Total Time 11.37s (± 0.55%) 11.35s (± 0.32%) -0.02s (- 0.18%) 11.29s 11.46s
Monaco - node (v10.16.3, x64)
Memory used 342,642k (± 0.02%) 342,712k (± 0.01%) +71k (+ 0.02%) 342,610k 342,807k
Parse Time 1.55s (± 0.52%) 1.55s (± 0.75%) +0.00s (+ 0.26%) 1.52s 1.58s
Bind Time 0.74s (± 0.92%) 0.74s (± 0.81%) 0.00s ( 0.00%) 0.73s 0.75s
Check Time 5.26s (± 0.65%) 5.25s (± 0.36%) -0.01s (- 0.19%) 5.21s 5.28s
Emit Time 3.12s (± 0.41%) 3.14s (± 0.82%) +0.01s (+ 0.45%) 3.10s 3.20s
Total Time 10.67s (± 0.37%) 10.67s (± 0.45%) +0.00s (+ 0.04%) 10.58s 10.77s
TFS - node (v10.16.3, x64)
Memory used 304,257k (± 0.02%) 304,305k (± 0.01%) +48k (+ 0.02%) 304,224k 304,375k
Parse Time 1.21s (± 0.48%) 1.21s (± 0.49%) -0.00s (- 0.08%) 1.19s 1.22s
Bind Time 0.70s (± 0.93%) 0.70s (± 0.64%) 0.00s ( 0.00%) 0.69s 0.71s
Check Time 4.72s (± 0.54%) 4.72s (± 0.26%) +0.00s (+ 0.04%) 4.69s 4.74s
Emit Time 3.25s (± 1.05%) 3.27s (± 1.32%) +0.01s (+ 0.37%) 3.14s 3.38s
Total Time 9.87s (± 0.38%) 9.89s (± 0.40%) +0.01s (+ 0.13%) 9.78s 10.00s
material-ui - node (v10.16.3, x64)
Memory used 465,406k (± 0.02%) 465,894k (± 0.01%) +488k (+ 0.10%) 465,747k 466,013k
Parse Time 2.00s (± 0.70%) 2.01s (± 0.73%) +0.01s (+ 0.60%) 1.99s 2.05s
Bind Time 0.66s (± 0.98%) 0.66s (± 1.58%) 0.00s ( 0.00%) 0.63s 0.68s
Check Time 14.22s (± 0.36%) 14.24s (± 0.79%) +0.02s (+ 0.14%) 14.05s 14.54s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.88s (± 0.29%) 16.91s (± 0.70%) +0.03s (+ 0.20%) 16.72s 17.22s
Angular - node (v12.1.0, x64)
Memory used 322,629k (± 0.03%) 322,727k (± 0.02%) +98k (+ 0.03%) 322,514k 322,873k
Parse Time 1.92s (± 0.52%) 1.92s (± 0.73%) +0.01s (+ 0.31%) 1.88s 1.95s
Bind Time 0.81s (± 0.55%) 0.81s (± 0.37%) 0.00s ( 0.00%) 0.80s 0.81s
Check Time 5.00s (± 0.45%) 4.99s (± 0.49%) -0.01s (- 0.16%) 4.94s 5.06s
Emit Time 5.97s (± 0.41%) 5.99s (± 0.76%) +0.02s (+ 0.40%) 5.91s 6.12s
Total Time 13.69s (± 0.31%) 13.71s (± 0.45%) +0.02s (+ 0.12%) 13.59s 13.86s
Compiler-Unions - node (v12.1.0, x64)
Memory used 190,339k (± 0.16%) 190,290k (± 0.19%) -48k (- 0.03%) 189,257k 190,958k
Parse Time 0.77s (± 0.89%) 0.77s (± 0.97%) +0.00s (+ 0.13%) 0.76s 0.79s
Bind Time 0.53s (± 0.95%) 0.53s (± 1.30%) 0.00s ( 0.00%) 0.52s 0.55s
Check Time 6.95s (± 0.38%) 6.94s (± 0.43%) -0.01s (- 0.09%) 6.88s 7.00s
Emit Time 2.53s (± 0.89%) 2.55s (± 1.29%) +0.02s (+ 0.99%) 2.49s 2.62s
Total Time 10.76s (± 0.38%) 10.79s (± 0.40%) +0.03s (+ 0.25%) 10.68s 10.87s
Monaco - node (v12.1.0, x64)
Memory used 325,088k (± 0.02%) 325,074k (± 0.02%) -14k (- 0.00%) 324,882k 325,180k
Parse Time 1.53s (± 0.71%) 1.53s (± 0.44%) +0.00s (+ 0.13%) 1.52s 1.55s
Bind Time 0.72s (± 0.56%) 0.72s (± 1.06%) -0.00s (- 0.42%) 0.70s 0.74s
Check Time 5.07s (± 0.50%) 5.09s (± 0.58%) +0.02s (+ 0.45%) 5.04s 5.17s
Emit Time 3.08s (± 0.47%) 3.09s (± 0.70%) +0.01s (+ 0.42%) 3.06s 3.15s
Total Time 10.40s (± 0.25%) 10.44s (± 0.45%) +0.03s (+ 0.33%) 10.36s 10.54s
TFS - node (v12.1.0, x64)
Memory used 288,785k (± 0.02%) 288,832k (± 0.02%) +47k (+ 0.02%) 288,718k 288,992k
Parse Time 1.21s (± 0.58%) 1.21s (± 0.75%) 0.00s ( 0.00%) 1.19s 1.23s
Bind Time 0.69s (± 0.68%) 0.69s (± 1.01%) +0.00s (+ 0.14%) 0.68s 0.71s
Check Time 4.64s (± 0.57%) 4.65s (± 0.50%) +0.01s (+ 0.15%) 4.60s 4.69s
Emit Time 3.16s (± 0.63%) 3.15s (± 0.42%) -0.01s (- 0.28%) 3.13s 3.19s
Total Time 9.71s (± 0.44%) 9.70s (± 0.32%) -0.01s (- 0.06%) 9.62s 9.75s
material-ui - node (v12.1.0, x64)
Memory used 443,470k (± 0.06%) 444,042k (± 0.01%) +572k (+ 0.13%) 443,903k 444,174k
Parse Time 2.03s (± 0.55%) 2.03s (± 0.47%) +0.00s (+ 0.00%) 2.00s 2.04s
Bind Time 0.64s (± 0.53%) 0.65s (± 1.18%) +0.01s (+ 1.26%) 0.63s 0.66s
Check Time 12.84s (± 0.49%) 12.88s (± 0.63%) +0.04s (+ 0.30%) 12.75s 13.08s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.51s (± 0.38%) 15.55s (± 0.54%) +0.04s (+ 0.28%) 15.40s 15.76s
Angular - node (v14.15.1, x64)
Memory used 321,325k (± 0.01%) 321,361k (± 0.01%) +36k (+ 0.01%) 321,302k 321,471k
Parse Time 1.93s (± 0.42%) 1.93s (± 0.59%) +0.00s (+ 0.10%) 1.91s 1.96s
Bind Time 0.86s (± 0.47%) 0.86s (± 0.58%) +0.01s (+ 0.70%) 0.86s 0.88s
Check Time 4.99s (± 0.55%) 5.01s (± 0.43%) +0.02s (+ 0.36%) 4.98s 5.06s
Emit Time 6.29s (± 0.55%) 6.31s (± 0.40%) +0.01s (+ 0.22%) 6.25s 6.35s
Total Time 14.08s (± 0.29%) 14.11s (± 0.28%) +0.04s (+ 0.26%) 14.02s 14.19s
Compiler-Unions - node (v14.15.1, x64)
Memory used 189,403k (± 0.02%) 189,465k (± 0.01%) +62k (+ 0.03%) 189,428k 189,521k
Parse Time 0.80s (± 0.72%) 0.80s (± 0.60%) -0.00s (- 0.38%) 0.79s 0.81s
Bind Time 0.55s (± 0.40%) 0.55s (± 0.66%) +0.00s (+ 0.54%) 0.55s 0.56s
Check Time 7.05s (± 0.47%) 7.04s (± 0.69%) -0.00s (- 0.06%) 6.95s 7.16s
Emit Time 2.55s (± 0.54%) 2.56s (± 0.93%) +0.00s (+ 0.12%) 2.52s 2.64s
Total Time 10.96s (± 0.37%) 10.95s (± 0.46%) -0.01s (- 0.06%) 10.82s 11.04s
Monaco - node (v14.15.1, x64)
Memory used 324,044k (± 0.01%) 324,062k (± 0.01%) +18k (+ 0.01%) 324,021k 324,136k
Parse Time 1.56s (± 0.37%) 1.57s (± 0.71%) +0.01s (+ 0.32%) 1.54s 1.60s
Bind Time 0.74s (± 0.49%) 0.74s (± 0.64%) -0.00s (- 0.13%) 0.74s 0.76s
Check Time 5.03s (± 0.44%) 5.04s (± 0.31%) +0.01s (+ 0.20%) 5.01s 5.09s
Emit Time 3.17s (± 0.53%) 3.18s (± 0.75%) +0.01s (+ 0.25%) 3.13s 3.24s
Total Time 10.50s (± 0.29%) 10.52s (± 0.29%) +0.02s (+ 0.22%) 10.48s 10.59s
TFS - node (v14.15.1, x64)
Memory used 287,658k (± 0.01%) 287,687k (± 0.01%) +29k (+ 0.01%) 287,639k 287,725k
Parse Time 1.26s (± 0.67%) 1.26s (± 0.74%) -0.00s (- 0.24%) 1.23s 1.28s
Bind Time 0.71s (± 0.63%) 0.72s (± 1.49%) +0.01s (+ 0.98%) 0.71s 0.76s
Check Time 4.65s (± 0.40%) 4.68s (± 0.68%) +0.02s (+ 0.47%) 4.62s 4.76s
Emit Time 3.24s (± 0.45%) 3.27s (± 0.69%) +0.03s (+ 0.99%) 3.21s 3.31s
Total Time 9.86s (± 0.22%) 9.92s (± 0.53%) +0.05s (+ 0.56%) 9.86s 10.09s
material-ui - node (v14.15.1, x64)
Memory used 441,589k (± 0.08%) 442,351k (± 0.00%) +763k (+ 0.17%) 442,331k 442,396k
Parse Time 2.09s (± 0.75%) 2.10s (± 0.47%) +0.01s (+ 0.43%) 2.08s 2.11s
Bind Time 0.69s (± 0.80%) 0.69s (± 0.43%) -0.00s (- 0.00%) 0.69s 0.70s
Check Time 13.04s (± 0.82%) 13.01s (± 0.51%) -0.02s (- 0.18%) 12.84s 13.14s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.82s (± 0.72%) 15.80s (± 0.42%) -0.02s (- 0.11%) 15.61s 15.94s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-206-generic
Architecturex64
Available Memory16 GB
Available Memory10 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
Benchmark Name Iterations
Current 43543 10
Baseline master 10

Developer Information:

Download Benchmark

@rbuckton rbuckton mentioned this pull request Apr 6, 2021
Closed
@rbuckton
Copy link
Contributor Author

rbuckton commented Apr 7, 2021

This didn't have a positive impact on the performance, but I'm going to use this branch to try a few different alternatives.

@rbuckton rbuckton force-pushed the reusableZeroLiteral branch from 5144684 to 9e4bd91 Compare April 7, 2021 01:47
@rbuckton
Copy link
Contributor Author

rbuckton commented Apr 7, 2021

@typescript-bot perf test

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 7, 2021 •
edited
Loading

Heya @rbuckton, I've started to run the perf test suite on this PR at 9e4bd91. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@rbuckton
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..43543

Metric master 43543 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 344,904k (± 0.02%) 344,918k (± 0.02%) +14k (+ 0.00%) 344,820k 345,016k
Parse Time 1.93s (± 0.41%) 1.94s (± 0.84%) +0.02s (+ 0.83%) 1.92s 1.99s
Bind Time 0.83s (± 0.87%) 0.83s (± 0.57%) +0.00s (+ 0.12%) 0.82s 0.84s
Check Time 5.09s (± 0.26%) 5.20s (± 0.54%) +0.11s (+ 2.16%) 5.16s 5.26s
Emit Time 5.91s (± 0.60%) 5.89s (± 0.54%) -0.02s (- 0.34%) 5.84s 6.00s
Total Time 13.76s (± 0.31%) 13.87s (± 0.44%) +0.11s (+ 0.78%) 13.76s 14.04s
Compiler-Unions - node (v10.16.3, x64)
Memory used 203,345k (± 0.03%) 202,861k (± 0.04%) -484k (- 0.24%) 202,576k 203,025k
Parse Time 0.78s (± 0.43%) 0.78s (± 0.71%) -0.00s (- 0.13%) 0.77s 0.80s
Bind Time 0.52s (± 1.13%) 0.52s (± 1.11%) -0.00s (- 0.19%) 0.51s 0.54s
Check Time 7.46s (± 0.58%) 7.51s (± 0.62%) +0.04s (+ 0.59%) 7.42s 7.62s
Emit Time 2.60s (± 1.35%) 2.56s (± 0.58%) -0.04s (- 1.39%) 2.53s 2.60s
Total Time 11.37s (± 0.55%) 11.37s (± 0.51%) +0.00s (+ 0.01%) 11.29s 11.53s
Monaco - node (v10.16.3, x64)
Memory used 342,642k (± 0.02%) 342,715k (± 0.01%) +73k (+ 0.02%) 342,590k 342,790k
Parse Time 1.55s (± 0.52%) 1.56s (± 0.81%) +0.01s (+ 0.58%) 1.53s 1.59s
Bind Time 0.74s (± 0.92%) 0.74s (± 0.90%) +0.00s (+ 0.54%) 0.73s 0.76s
Check Time 5.26s (± 0.65%) 5.32s (± 0.43%) +0.06s (+ 1.12%) 5.27s 5.36s
Emit Time 3.12s (± 0.41%) 3.12s (± 0.85%) -0.00s (- 0.10%) 3.07s 3.18s
Total Time 10.67s (± 0.37%) 10.73s (± 0.48%) +0.06s (+ 0.61%) 10.61s 10.84s
TFS - node (v10.16.3, x64)
Memory used 304,257k (± 0.02%) 304,328k (± 0.03%) +71k (+ 0.02%) 304,147k 304,604k
Parse Time 1.21s (± 0.48%) 1.22s (± 0.87%) +0.01s (+ 0.75%) 1.20s 1.24s
Bind Time 0.70s (± 0.93%) 0.70s (± 0.84%) +0.01s (+ 0.86%) 0.69s 0.72s
Check Time 4.72s (± 0.54%) 4.79s (± 0.55%) +0.08s (+ 1.65%) 4.73s 4.83s
Emit Time 3.25s (± 1.05%) 3.26s (± 1.51%) +0.01s (+ 0.28%) 3.14s 3.38s
Total Time 9.87s (± 0.38%) 9.98s (± 0.73%) +0.10s (+ 1.04%) 9.81s 10.14s
material-ui - node (v10.16.3, x64)
Memory used 465,406k (± 0.02%) 466,034k (± 0.02%) +627k (+ 0.13%) 465,830k 466,164k
Parse Time 2.00s (± 0.70%) 2.01s (± 0.64%) +0.01s (+ 0.50%) 1.97s 2.03s
Bind Time 0.66s (± 0.98%) 0.66s (± 0.91%) -0.00s (- 0.46%) 0.64s 0.67s
Check Time 14.22s (± 0.36%) 14.28s (± 0.37%) +0.07s (+ 0.47%) 14.20s 14.43s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.88s (± 0.29%) 16.95s (± 0.32%) +0.07s (+ 0.44%) 16.86s 17.09s
Angular - node (v12.1.0, x64)
Memory used 322,629k (± 0.03%) 322,708k (± 0.03%) +79k (+ 0.02%) 322,540k 322,919k
Parse Time 1.92s (± 0.52%) 1.92s (± 0.59%) +0.01s (+ 0.26%) 1.90s 1.96s
Bind Time 0.81s (± 0.55%) 0.82s (± 1.07%) +0.01s (+ 1.86%) 0.81s 0.85s
Check Time 5.00s (± 0.45%) 5.08s (± 0.29%) +0.08s (+ 1.58%) 5.04s 5.11s
Emit Time 5.97s (± 0.41%) 5.92s (± 0.27%) -0.05s (- 0.75%) 5.90s 5.96s
Total Time 13.69s (± 0.31%) 13.74s (± 0.19%) +0.05s (+ 0.35%) 13.67s 13.78s
Compiler-Unions - node (v12.1.0, x64)
Memory used 190,339k (± 0.16%) 190,110k (± 0.12%) -229k (- 0.12%) 189,530k 190,547k
Parse Time 0.77s (± 0.89%) 0.77s (± 0.68%) +0.00s (+ 0.39%) 0.76s 0.78s
Bind Time 0.53s (± 0.95%) 0.53s (± 0.63%) +0.01s (+ 0.95%) 0.52s 0.54s
Check Time 6.95s (± 0.38%) 6.95s (± 0.41%) +0.00s (+ 0.00%) 6.88s 7.00s
Emit Time 2.53s (± 0.89%) 2.53s (± 0.68%) +0.00s (+ 0.04%) 2.50s 2.58s
Total Time 10.76s (± 0.38%) 10.77s (± 0.25%) +0.01s (+ 0.09%) 10.72s 10.83s
Monaco - node (v12.1.0, x64)
Memory used 325,088k (± 0.02%) 325,113k (± 0.01%) +25k (+ 0.01%) 325,024k 325,198k
Parse Time 1.53s (± 0.71%) 1.53s (± 0.72%) +0.00s (+ 0.13%) 1.51s 1.55s
Bind Time 0.72s (± 0.56%) 0.72s (± 0.92%) +0.00s (+ 0.14%) 0.71s 0.73s
Check Time 5.07s (± 0.50%) 5.14s (± 0.33%) +0.06s (+ 1.26%) 5.10s 5.17s
Emit Time 3.08s (± 0.47%) 3.10s (± 0.50%) +0.02s (+ 0.62%) 3.07s 3.13s
Total Time 10.40s (± 0.25%) 10.49s (± 0.17%) +0.09s (+ 0.84%) 10.45s 10.53s
TFS - node (v12.1.0, x64)
Memory used 288,785k (± 0.02%) 288,775k (± 0.01%) -10k (- 0.00%) 288,658k 288,838k
Parse Time 1.21s (± 0.58%) 1.22s (± 0.77%) +0.01s (+ 0.74%) 1.20s 1.24s
Bind Time 0.69s (± 0.68%) 0.69s (± 1.27%) +0.00s (+ 0.43%) 0.68s 0.72s
Check Time 4.64s (± 0.57%) 4.68s (± 0.42%) +0.04s (+ 0.93%) 4.64s 4.72s
Emit Time 3.16s (± 0.63%) 3.17s (± 0.70%) +0.01s (+ 0.41%) 3.13s 3.22s
Total Time 9.71s (± 0.44%) 9.77s (± 0.35%) +0.07s (+ 0.69%) 9.66s 9.83s
material-ui - node (v12.1.0, x64)
Memory used 443,470k (± 0.06%) 444,126k (± 0.01%) +656k (+ 0.15%) 444,067k 444,188k
Parse Time 2.03s (± 0.55%) 2.04s (± 0.54%) +0.01s (+ 0.54%) 2.01s 2.06s
Bind Time 0.64s (± 0.53%) 0.64s (± 1.08%) -0.00s (- 0.31%) 0.62s 0.65s
Check Time 12.84s (± 0.49%) 12.99s (± 0.37%) +0.15s (+ 1.19%) 12.92s 13.13s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.51s (± 0.38%) 15.66s (± 0.30%) +0.16s (+ 1.03%) 15.58s 15.80s
Angular - node (v14.15.1, x64)
Memory used 321,325k (± 0.01%) 321,279k (± 0.08%) -46k (- 0.01%) 320,265k 321,447k
Parse Time 1.93s (± 0.42%) 1.93s (± 0.54%) +0.00s (+ 0.00%) 1.91s 1.96s
Bind Time 0.86s (± 0.47%) 0.86s (± 0.86%) +0.00s (+ 0.47%) 0.85s 0.89s
Check Time 4.99s (± 0.55%) 5.12s (± 0.55%) +0.13s (+ 2.58%) 5.07s 5.21s
Emit Time 6.29s (± 0.55%) 6.28s (± 0.59%) -0.01s (- 0.13%) 6.21s 6.38s
Total Time 14.08s (± 0.29%) 14.20s (± 0.31%) +0.13s (+ 0.89%) 14.14s 14.31s
Compiler-Unions - node (v14.15.1, x64)
Memory used 189,403k (± 0.02%) 189,036k (± 0.01%) -367k (- 0.19%) 189,016k 189,056k
Parse Time 0.80s (± 0.72%) 0.80s (± 0.56%) +0.00s (+ 0.25%) 0.79s 0.81s
Bind Time 0.55s (± 0.40%) 0.56s (± 0.65%) +0.01s (+ 0.91%) 0.55s 0.56s
Check Time 7.05s (± 0.47%) 7.09s (± 0.68%) +0.04s (+ 0.51%) 7.00s 7.24s
Emit Time 2.55s (± 0.54%) 2.54s (± 0.85%) -0.02s (- 0.70%) 2.48s 2.58s
Total Time 10.96s (± 0.37%) 10.98s (± 0.55%) +0.02s (+ 0.19%) 10.87s 11.18s
Monaco - node (v14.15.1, x64)
Memory used 324,044k (± 0.01%) 324,082k (± 0.01%) +39k (+ 0.01%) 324,025k 324,132k
Parse Time 1.56s (± 0.37%) 1.56s (± 0.67%) +0.00s (+ 0.13%) 1.54s 1.58s
Bind Time 0.74s (± 0.49%) 0.75s (± 0.91%) +0.00s (+ 0.27%) 0.73s 0.76s
Check Time 5.03s (± 0.44%) 5.09s (± 0.34%) +0.06s (+ 1.23%) 5.04s 5.12s
Emit Time 3.17s (± 0.53%) 3.21s (± 0.86%) +0.04s (+ 1.14%) 3.16s 3.28s
Total Time 10.50s (± 0.29%) 10.60s (± 0.34%) +0.10s (+ 0.97%) 10.54s 10.69s
TFS - node (v14.15.1, x64)
Memory used 287,658k (± 0.01%) 287,694k (± 0.01%) +36k (+ 0.01%) 287,642k 287,764k
Parse Time 1.26s (± 0.67%) 1.26s (± 1.10%) -0.00s (- 0.16%) 1.23s 1.30s
Bind Time 0.71s (± 0.63%) 0.71s (± 0.51%) +0.00s (+ 0.28%) 0.71s 0.72s
Check Time 4.65s (± 0.40%) 4.72s (± 0.47%) +0.06s (+ 1.31%) 4.67s 4.78s
Emit Time 3.24s (± 0.45%) 3.28s (± 0.81%) +0.04s (+ 1.24%) 3.21s 3.35s
Total Time 9.86s (± 0.22%) 9.96s (± 0.44%) +0.10s (+ 1.02%) 9.86s 10.04s
material-ui - node (v14.15.1, x64)
Memory used 441,589k (± 0.08%) 442,401k (± 0.00%) +813k (+ 0.18%) 442,351k 442,438k
Parse Time 2.09s (± 0.75%) 2.10s (± 0.80%) +0.01s (+ 0.62%) 2.07s 2.14s
Bind Time 0.69s (± 0.80%) 0.70s (± 0.98%) +0.00s (+ 0.58%) 0.68s 0.71s
Check Time 13.04s (± 0.82%) 13.11s (± 0.74%) +0.07s (+ 0.57%) 12.91s 13.36s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.82s (± 0.72%) 15.91s (± 0.70%) +0.09s (+ 0.58%) 15.69s 16.18s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-206-generic
Architecturex64
Available Memory16 GB
Available Memory10 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
Benchmark Name Iterations
Current 43543 10
Baseline master 10

Developer Information:

Download Benchmark

@rbuckton rbuckton force-pushed the reusableZeroLiteral branch from 9e4bd91 to 68a1265 Compare April 12, 2021 19:55
@rbuckton
Copy link
Contributor Author

@typescript-bot perf test

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 14, 2021 •
edited
Loading

Heya @rbuckton, I've started to run the perf test suite on this PR at 68a1265. You can monitor the build here.

Update: The results are in!

@rbuckton
Copy link
Contributor Author

One option may be to introduce an --indirectImportInvocation flag (or some other name) to opt into the correct behavior to avoid the compile time overhead when this issue is not relevant to your program.

@typescript-bot
Copy link
Collaborator

@rbuckton
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..43543

Metric master 43543 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 345,095k (± 0.02%) 344,956k (± 0.02%) -138k (- 0.04%) 344,809k 345,040k
Parse Time 1.94s (± 0.60%) 1.94s (± 0.60%) -0.00s (- 0.21%) 1.91s 1.96s
Bind Time 0.83s (± 0.71%) 0.84s (± 0.91%) +0.00s (+ 0.24%) 0.82s 0.86s
Check Time 5.18s (± 0.32%) 5.20s (± 0.63%) +0.02s (+ 0.33%) 5.14s 5.31s
Emit Time 5.92s (± 0.58%) 5.83s (± 0.24%) -0.09s (- 1.57%) 5.81s 5.87s
Total Time 13.88s (± 0.25%) 13.80s (± 0.41%) -0.08s (- 0.60%) 13.73s 14.00s
Compiler-Unions - node (v10.16.3, x64)
Memory used 203,421k (± 0.04%) 202,881k (± 0.07%) -540k (- 0.27%) 202,369k 203,140k
Parse Time 0.78s (± 0.61%) 0.79s (± 0.60%) +0.00s (+ 0.51%) 0.78s 0.80s
Bind Time 0.52s (± 1.28%) 0.52s (± 1.00%) -0.00s (- 0.76%) 0.51s 0.53s
Check Time 7.47s (± 0.50%) 7.50s (± 0.79%) +0.02s (+ 0.28%) 7.41s 7.65s
Emit Time 2.57s (± 0.81%) 2.58s (± 0.99%) +0.01s (+ 0.35%) 2.52s 2.63s
Total Time 11.35s (± 0.44%) 11.38s (± 0.55%) +0.03s (+ 0.24%) 11.26s 11.53s
Monaco - node (v10.16.3, x64)
Memory used 342,808k (± 0.01%) 342,831k (± 0.02%) +24k (+ 0.01%) 342,679k 342,971k
Parse Time 1.55s (± 0.66%) 1.54s (± 0.47%) -0.01s (- 0.58%) 1.52s 1.56s
Bind Time 0.74s (± 0.66%) 0.74s (± 0.45%) -0.00s (- 0.54%) 0.73s 0.75s
Check Time 5.32s (± 0.60%) 5.32s (± 0.40%) -0.01s (- 0.13%) 5.27s 5.37s
Emit Time 3.12s (± 0.36%) 3.12s (± 0.66%) -0.01s (- 0.16%) 3.08s 3.19s
Total Time 10.74s (± 0.31%) 10.72s (± 0.22%) -0.03s (- 0.23%) 10.66s 10.77s
TFS - node (v10.16.3, x64)
Memory used 304,387k (± 0.03%) 304,357k (± 0.02%) -31k (- 0.01%) 304,247k 304,446k
Parse Time 1.21s (± 0.61%) 1.21s (± 0.70%) -0.00s (- 0.08%) 1.19s 1.23s
Bind Time 0.70s (± 0.70%) 0.71s (± 0.71%) +0.00s (+ 0.14%) 0.69s 0.71s
Check Time 4.77s (± 0.53%) 4.79s (± 0.38%) +0.02s (+ 0.42%) 4.75s 4.83s
Emit Time 3.26s (± 1.41%) 3.26s (± 0.98%) +0.00s (+ 0.06%) 3.19s 3.33s
Total Time 9.94s (± 0.42%) 9.96s (± 0.39%) +0.02s (+ 0.25%) 9.88s 10.04s
material-ui - node (v10.16.3, x64)
Memory used 466,091k (± 0.01%) 466,112k (± 0.01%) +21k (+ 0.00%) 465,992k 466,311k
Parse Time 2.01s (± 0.47%) 2.01s (± 0.71%) +0.00s (+ 0.20%) 1.98s 2.04s
Bind Time 0.66s (± 1.43%) 0.66s (± 1.05%) -0.00s (- 0.30%) 0.64s 0.67s
Check Time 14.31s (± 0.54%) 14.34s (± 0.51%) +0.03s (+ 0.21%) 14.17s 14.50s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.97s (± 0.45%) 17.00s (± 0.45%) +0.03s (+ 0.17%) 16.82s 17.19s
Angular - node (v12.1.0, x64)
Memory used 322,806k (± 0.02%) 322,686k (± 0.03%) -120k (- 0.04%) 322,448k 322,866k
Parse Time 1.92s (± 0.78%) 1.93s (± 0.81%) +0.01s (+ 0.31%) 1.90s 1.97s
Bind Time 0.81s (± 0.37%) 0.81s (± 0.58%) -0.00s (- 0.25%) 0.80s 0.82s
Check Time 5.11s (± 0.55%) 5.10s (± 0.47%) -0.00s (- 0.08%) 5.05s 5.17s
Emit Time 5.97s (± 0.35%) 5.92s (± 0.66%) -0.05s (- 0.82%) 5.83s 6.02s
Total Time 13.81s (± 0.29%) 13.76s (± 0.40%) -0.05s (- 0.35%) 13.64s 13.89s
Compiler-Unions - node (v12.1.0, x64)
Memory used 190,765k (± 0.43%) 189,906k (± 0.14%) -860k (- 0.45%) 189,329k 190,529k
Parse Time 0.77s (± 0.52%) 0.77s (± 0.78%) -0.00s (- 0.39%) 0.75s 0.78s
Bind Time 0.52s (± 0.69%) 0.53s (± 0.90%) +0.00s (+ 0.57%) 0.52s 0.54s
Check Time 7.00s (± 0.61%) 7.01s (± 0.74%) +0.01s (+ 0.19%) 6.91s 7.17s
Emit Time 2.54s (± 1.50%) 2.55s (± 1.35%) +0.01s (+ 0.55%) 2.49s 2.64s
Total Time 10.83s (± 0.49%) 10.86s (± 0.66%) +0.03s (+ 0.26%) 10.72s 11.06s
Monaco - node (v12.1.0, x64)
Memory used 325,134k (± 0.02%) 325,162k (± 0.02%) +28k (+ 0.01%) 325,047k 325,316k
Parse Time 1.53s (± 0.32%) 1.54s (± 0.57%) +0.02s (+ 1.11%) 1.52s 1.56s
Bind Time 0.72s (± 0.86%) 0.72s (± 0.77%) +0.00s (+ 0.14%) 0.71s 0.74s
Check Time 5.12s (± 0.61%) 5.17s (± 0.59%) +0.05s (+ 0.92%) 5.13s 5.28s
Emit Time 3.07s (± 0.46%) 3.09s (± 0.47%) +0.03s (+ 0.88%) 3.06s 3.12s
Total Time 10.44s (± 0.38%) 10.53s (± 0.37%) +0.09s (+ 0.83%) 10.48s 10.67s
TFS - node (v12.1.0, x64)
Memory used 288,773k (± 0.01%) 288,812k (± 0.02%) +39k (+ 0.01%) 288,708k 288,903k
Parse Time 1.21s (± 1.02%) 1.21s (± 0.63%) -0.00s (- 0.17%) 1.19s 1.22s
Bind Time 0.69s (± 0.90%) 0.69s (± 0.58%) 0.00s ( 0.00%) 0.68s 0.70s
Check Time 4.67s (± 0.38%) 4.70s (± 0.50%) +0.02s (+ 0.45%) 4.64s 4.76s
Emit Time 3.15s (± 0.93%) 3.17s (± 0.83%) +0.02s (+ 0.67%) 3.12s 3.25s
Total Time 9.72s (± 0.30%) 9.77s (± 0.31%) +0.04s (+ 0.45%) 9.70s 9.82s
material-ui - node (v12.1.0, x64)
Memory used 444,215k (± 0.02%) 444,006k (± 0.09%) -209k (- 0.05%) 442,935k 444,395k
Parse Time 2.03s (± 0.57%) 2.03s (± 0.64%) -0.00s (- 0.10%) 2.00s 2.06s
Bind Time 0.64s (± 0.77%) 0.64s (± 0.97%) +0.00s (+ 0.47%) 0.62s 0.65s
Check Time 12.86s (± 0.32%) 12.95s (± 0.77%) +0.10s (+ 0.74%) 12.76s 13.21s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.53s (± 0.25%) 15.62s (± 0.61%) +0.09s (+ 0.59%) 15.44s 15.88s
Angular - node (v14.15.1, x64)
Memory used 321,423k (± 0.01%) 321,423k (± 0.01%) +1k (+ 0.00%) 321,357k 321,509k
Parse Time 1.93s (± 0.55%) 1.93s (± 0.57%) +0.00s (+ 0.16%) 1.91s 1.96s
Bind Time 0.86s (± 0.46%) 0.86s (± 0.52%) +0.00s (+ 0.12%) 0.85s 0.87s
Check Time 5.11s (± 0.32%) 5.13s (± 0.57%) +0.02s (+ 0.39%) 5.04s 5.19s
Emit Time 6.32s (± 0.38%) 6.25s (± 0.50%) -0.07s (- 1.08%) 6.19s 6.33s
Total Time 14.22s (± 0.17%) 14.18s (± 0.40%) -0.04s (- 0.31%) 14.03s 14.28s
Compiler-Unions - node (v14.15.1, x64)
Memory used 189,492k (± 0.01%) 189,039k (± 0.01%) -454k (- 0.24%) 188,967k 189,064k
Parse Time 0.81s (± 0.46%) 0.81s (± 0.45%) +0.00s (+ 0.12%) 0.80s 0.81s
Bind Time 0.55s (± 0.90%) 0.56s (± 0.65%) +0.00s (+ 0.18%) 0.55s 0.56s
Check Time 7.12s (± 0.80%) 7.07s (± 0.38%) -0.05s (- 0.70%) 7.04s 7.14s
Emit Time 2.54s (± 0.59%) 2.54s (± 0.51%) -0.00s (- 0.12%) 2.52s 2.58s
Total Time 11.03s (± 0.61%) 10.97s (± 0.30%) -0.05s (- 0.48%) 10.91s 11.07s
Monaco - node (v14.15.1, x64)
Memory used 324,177k (± 0.01%) 324,153k (± 0.01%) -25k (- 0.01%) 324,070k 324,216k
Parse Time 1.57s (± 0.53%) 1.57s (± 0.49%) -0.00s (- 0.00%) 1.55s 1.58s
Bind Time 0.74s (± 0.46%) 0.74s (± 0.49%) +0.00s (+ 0.13%) 0.74s 0.75s
Check Time 5.12s (± 0.64%) 5.11s (± 0.40%) -0.01s (- 0.20%) 5.07s 5.14s
Emit Time 3.18s (± 0.52%) 3.18s (± 0.54%) -0.00s (- 0.03%) 3.15s 3.23s
Total Time 10.61s (± 0.35%) 10.60s (± 0.26%) -0.01s (- 0.08%) 10.54s 10.66s
TFS - node (v14.15.1, x64)
Memory used 287,779k (± 0.01%) 287,768k (± 0.01%) -10k (- 0.00%) 287,704k 287,799k
Parse Time 1.26s (± 0.98%) 1.27s (± 1.33%) +0.01s (+ 1.11%) 1.24s 1.33s
Bind Time 0.72s (± 0.66%) 0.72s (± 0.69%) -0.00s (- 0.14%) 0.71s 0.73s
Check Time 4.71s (± 0.35%) 4.71s (± 0.76%) +0.01s (+ 0.13%) 4.66s 4.82s
Emit Time 3.26s (± 0.64%) 3.25s (± 0.41%) -0.01s (- 0.34%) 3.22s 3.27s
Total Time 9.94s (± 0.28%) 9.95s (± 0.39%) +0.01s (+ 0.11%) 9.89s 10.07s
material-ui - node (v14.15.1, x64)
Memory used 442,477k (± 0.00%) 442,361k (± 0.06%) -117k (- 0.03%) 441,352k 442,519k
Parse Time 2.09s (± 0.74%) 2.09s (± 0.53%) -0.00s (- 0.05%) 2.06s 2.10s
Bind Time 0.69s (± 0.69%) 0.70s (± 0.68%) +0.00s (+ 0.58%) 0.69s 0.71s
Check Time 13.03s (± 0.56%) 13.13s (± 0.63%) +0.10s (+ 0.79%) 12.99s 13.32s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.81s (± 0.47%) 15.92s (± 0.52%) +0.11s (+ 0.69%) 15.75s 16.10s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-206-generic
Architecturex64
Available Memory16 GB
Available Memory9 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
Benchmark Name Iterations
Current 43543 10
Baseline master 10

Developer Information:

Download Benchmark

@rbuckton rbuckton force-pushed the reusableZeroLiteral branch from 68a1265 to 6253564 Compare April 19, 2021 19:37
@rbuckton
Copy link
Contributor Author

@typescript-bot perf test

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 19, 2021 •
edited
Loading

Heya @rbuckton, I've started to run the perf test suite on this PR at 6253564. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@rbuckton
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..43543

Metric master 43543 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 344,960k (± 0.02%) 344,952k (± 0.03%) -8k (- 0.00%) 344,775k 345,144k
Parse Time 1.95s (± 0.58%) 1.95s (± 0.70%) -0.00s (- 0.10%) 1.92s 1.98s
Bind Time 0.84s (± 0.44%) 0.84s (± 0.74%) +0.00s (+ 0.36%) 0.83s 0.85s
Check Time 5.24s (± 0.40%) 5.23s (± 0.40%) -0.02s (- 0.32%) 5.17s 5.26s
Emit Time 5.92s (± 0.51%) 5.88s (± 0.60%) -0.04s (- 0.66%) 5.81s 5.94s
Total Time 13.95s (± 0.37%) 13.89s (± 0.40%) -0.06s (- 0.39%) 13.75s 14.01s
Compiler-Unions - node (v10.16.3, x64)
Memory used 203,159k (± 0.04%) 202,602k (± 0.04%) -557k (- 0.27%) 202,301k 202,765k
Parse Time 0.79s (± 0.95%) 0.79s (± 0.82%) +0.00s (+ 0.13%) 0.78s 0.81s
Bind Time 0.53s (± 1.13%) 0.52s (± 1.18%) -0.00s (- 0.95%) 0.51s 0.53s
Check Time 7.58s (± 0.89%) 7.49s (± 0.54%) -0.09s (- 1.15%) 7.43s 7.59s
Emit Time 2.51s (± 1.16%) 2.50s (± 1.02%) -0.02s (- 0.80%) 2.43s 2.57s
Total Time 11.41s (± 0.83%) 11.29s (± 0.37%) -0.11s (- 0.98%) 11.21s 11.37s
Monaco - node (v10.16.3, x64)
Memory used 342,644k (± 0.02%) 342,582k (± 0.01%) -62k (- 0.02%) 342,436k 342,694k
Parse Time 1.57s (± 0.48%) 1.56s (± 0.49%) -0.01s (- 0.64%) 1.54s 1.57s
Bind Time 0.74s (± 0.66%) 0.74s (± 0.92%) +0.00s (+ 0.13%) 0.73s 0.76s
Check Time 5.33s (± 0.74%) 5.34s (± 0.49%) +0.01s (+ 0.21%) 5.29s 5.41s
Emit Time 3.02s (± 1.01%) 3.02s (± 0.63%) -0.00s (- 0.03%) 2.98s 3.07s
Total Time 10.66s (± 0.47%) 10.66s (± 0.36%) -0.00s (- 0.02%) 10.59s 10.74s
TFS - node (v10.16.3, x64)
Memory used 304,156k (± 0.01%) 304,186k (± 0.02%) +31k (+ 0.01%) 303,988k 304,353k
Parse Time 1.22s (± 0.56%) 1.22s (± 0.56%) +0.00s (+ 0.08%) 1.21s 1.24s
Bind Time 0.71s (± 0.87%) 0.70s (± 0.63%) -0.01s (- 0.99%) 0.69s 0.71s
Check Time 4.75s (± 0.46%) 4.75s (± 0.49%) +0.00s (+ 0.00%) 4.69s 4.81s
Emit Time 3.19s (± 0.88%) 3.18s (± 1.10%) -0.01s (- 0.31%) 3.07s 3.24s
Total Time 9.86s (± 0.38%) 9.85s (± 0.49%) -0.01s (- 0.14%) 9.72s 9.93s
material-ui - node (v10.16.3, x64)
Memory used 465,277k (± 0.01%) 465,283k (± 0.02%) +6k (+ 0.00%) 465,079k 465,482k
Parse Time 2.02s (± 0.67%) 2.02s (± 0.72%) -0.00s (- 0.05%) 1.98s 2.06s
Bind Time 0.66s (± 1.32%) 0.66s (± 1.27%) -0.00s (- 0.46%) 0.63s 0.67s
Check Time 14.57s (± 0.90%) 14.48s (± 0.67%) -0.10s (- 0.65%) 14.32s 14.73s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 17.25s (± 0.83%) 17.16s (± 0.60%) -0.10s (- 0.56%) 16.97s 17.42s
Angular - node (v12.1.0, x64)
Memory used 322,637k (± 0.02%) 322,561k (± 0.02%) -77k (- 0.02%) 322,411k 322,699k
Parse Time 1.95s (± 0.83%) 1.93s (± 0.72%) -0.02s (- 1.18%) 1.91s 1.97s
Bind Time 0.82s (± 0.73%) 0.82s (± 0.95%) +0.00s (+ 0.49%) 0.81s 0.84s
Check Time 5.11s (± 0.42%) 5.11s (± 0.57%) -0.00s (- 0.10%) 5.05s 5.18s
Emit Time 6.15s (± 0.90%) 6.09s (± 0.68%) -0.06s (- 0.99%) 5.99s 6.22s
Total Time 14.02s (± 0.51%) 13.94s (± 0.49%) -0.08s (- 0.59%) 13.81s 14.15s
Compiler-Unions - node (v12.1.0, x64)
Memory used 190,161k (± 0.14%) 189,621k (± 0.11%) -540k (- 0.28%) 189,024k 190,116k
Parse Time 0.77s (± 0.52%) 0.77s (± 0.97%) -0.00s (- 0.52%) 0.75s 0.79s
Bind Time 0.53s (± 0.84%) 0.53s (± 0.71%) -0.00s (- 0.57%) 0.52s 0.53s
Check Time 7.04s (± 0.65%) 7.01s (± 0.54%) -0.03s (- 0.38%) 6.93s 7.10s
Emit Time 2.48s (± 1.31%) 2.50s (± 1.10%) +0.01s (+ 0.56%) 2.45s 2.55s
Total Time 10.82s (± 0.37%) 10.80s (± 0.27%) -0.02s (- 0.19%) 10.73s 10.85s
Monaco - node (v12.1.0, x64)
Memory used 324,913k (± 0.06%) 325,003k (± 0.01%) +90k (+ 0.03%) 324,862k 325,126k
Parse Time 1.54s (± 1.14%) 1.54s (± 0.54%) -0.01s (- 0.39%) 1.52s 1.56s
Bind Time 0.72s (± 0.86%) 0.72s (± 0.41%) -0.00s (- 0.42%) 0.71s 0.72s
Check Time 5.18s (± 0.41%) 5.16s (± 0.40%) -0.02s (- 0.33%) 5.13s 5.22s
Emit Time 3.10s (± 0.88%) 3.09s (± 0.63%) -0.01s (- 0.35%) 3.05s 3.15s
Total Time 10.54s (± 0.42%) 10.50s (± 0.26%) -0.04s (- 0.38%) 10.44s 10.55s
TFS - node (v12.1.0, x64)
Memory used 288,655k (± 0.02%) 288,645k (± 0.02%) -9k (- 0.00%) 288,462k 288,766k
Parse Time 1.22s (± 0.68%) 1.21s (± 0.55%) -0.01s (- 1.14%) 1.20s 1.23s
Bind Time 0.69s (± 0.89%) 0.69s (± 1.45%) +0.00s (+ 0.43%) 0.68s 0.73s
Check Time 4.68s (± 0.34%) 4.66s (± 0.47%) -0.02s (- 0.41%) 4.61s 4.71s
Emit Time 3.24s (± 1.60%) 3.21s (± 1.30%) -0.03s (- 0.83%) 3.15s 3.32s
Total Time 9.83s (± 0.59%) 9.77s (± 0.58%) -0.06s (- 0.59%) 9.66s 9.90s
material-ui - node (v12.1.0, x64)
Memory used 443,186k (± 0.07%) 443,115k (± 0.08%) -71k (- 0.02%) 442,070k 443,465k
Parse Time 2.04s (± 0.71%) 2.03s (± 0.28%) -0.01s (- 0.39%) 2.02s 2.05s
Bind Time 0.64s (± 0.96%) 0.64s (± 1.10%) -0.00s (- 0.31%) 0.63s 0.66s
Check Time 13.14s (± 1.16%) 13.06s (± 0.77%) -0.08s (- 0.62%) 12.86s 13.32s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.82s (± 0.95%) 15.73s (± 0.63%) -0.09s (- 0.54%) 15.53s 15.98s
Angular - node (v14.15.1, x64)
Memory used 321,255k (± 0.01%) 321,235k (± 0.01%) -20k (- 0.01%) 321,210k 321,287k
Parse Time 1.93s (± 0.64%) 1.94s (± 0.64%) +0.01s (+ 0.26%) 1.91s 1.97s
Bind Time 0.87s (± 0.51%) 0.87s (± 2.09%) 0.00s ( 0.00%) 0.85s 0.94s
Check Time 5.13s (± 0.54%) 5.11s (± 0.31%) -0.02s (- 0.33%) 5.08s 5.15s
Emit Time 6.22s (± 0.77%) 6.15s (± 0.48%) -0.06s (- 1.05%) 6.10s 6.25s
Total Time 14.15s (± 0.49%) 14.07s (± 0.31%) -0.08s (- 0.54%) 13.98s 14.16s
Compiler-Unions - node (v14.15.1, x64)
Memory used 189,572k (± 0.38%) 190,398k (± 0.62%) +827k (+ 0.44%) 188,779k 192,011k
Parse Time 0.80s (± 0.61%) 0.80s (± 0.94%) -0.00s (- 0.00%) 0.79s 0.82s
Bind Time 0.56s (± 1.10%) 0.56s (± 0.93%) +0.00s (+ 0.00%) 0.55s 0.57s
Check Time 7.14s (± 0.52%) 7.10s (± 0.50%) -0.03s (- 0.46%) 7.04s 7.20s
Emit Time 2.51s (± 0.76%) 2.49s (± 0.71%) -0.02s (- 0.60%) 2.45s 2.54s
Total Time 11.00s (± 0.45%) 10.95s (± 0.42%) -0.05s (- 0.44%) 10.83s 11.07s
Monaco - node (v14.15.1, x64)
Memory used 324,028k (± 0.01%) 324,052k (± 0.01%) +24k (+ 0.01%) 324,002k 324,101k
Parse Time 1.58s (± 0.95%) 1.57s (± 0.84%) -0.01s (- 0.57%) 1.54s 1.59s
Bind Time 0.75s (± 0.80%) 0.74s (± 0.49%) -0.00s (- 0.13%) 0.74s 0.75s
Check Time 5.12s (± 0.55%) 5.11s (± 0.56%) -0.01s (- 0.18%) 5.03s 5.17s
Emit Time 3.12s (± 0.50%) 3.15s (± 1.11%) +0.02s (+ 0.77%) 3.08s 3.23s
Total Time 10.57s (± 0.47%) 10.58s (± 0.50%) +0.01s (+ 0.09%) 10.45s 10.67s
TFS - node (v14.15.1, x64)
Memory used 287,633k (± 0.01%) 287,632k (± 0.01%) -1k (- 0.00%) 287,577k 287,683k
Parse Time 1.27s (± 1.10%) 1.26s (± 1.06%) -0.01s (- 0.55%) 1.23s 1.29s
Bind Time 0.71s (± 0.56%) 0.71s (± 0.48%) +0.00s (+ 0.28%) 0.71s 0.72s
Check Time 4.72s (± 0.41%) 4.71s (± 0.44%) -0.01s (- 0.28%) 4.66s 4.77s
Emit Time 3.30s (± 0.51%) 3.31s (± 0.64%) +0.02s (+ 0.45%) 3.27s 3.36s
Total Time 10.01s (± 0.29%) 10.00s (± 0.41%) -0.00s (- 0.04%) 9.93s 10.12s
material-ui - node (v14.15.1, x64)
Memory used 441,460k (± 0.06%) 441,572k (± 0.01%) +112k (+ 0.03%) 441,521k 441,625k
Parse Time 2.10s (± 0.77%) 2.09s (± 0.53%) -0.00s (- 0.24%) 2.07s 2.12s
Bind Time 0.70s (± 0.63%) 0.70s (± 0.68%) -0.01s (- 0.71%) 0.69s 0.71s
Check Time 13.23s (± 0.64%) 13.18s (± 0.58%) -0.05s (- 0.36%) 13.06s 13.43s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.03s (± 0.56%) 15.97s (± 0.46%) -0.06s (- 0.36%) 15.84s 16.20s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-206-generic
Architecturex64
Available Memory16 GB
Available Memory8 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
Benchmark Name Iterations
Current 43543 10
Baseline master 10

Developer Information:

Download Benchmark

@rbuckton rbuckton closed this Jun 18, 2021
@rbuckton rbuckton deleted the reusableZeroLiteral branch June 18, 2021 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rbuckton rbuckton

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbuckton @typescript-bot