Skip to content

Conversation

@hn3000
Copy link
Contributor

@hn3000 hn3000 commented Aug 10, 2014

sourceMap option no longer worked because code expects the M to be upper case, options structure had a lower case m

@hn3000
Copy link
Contributor Author

hn3000 commented Aug 11, 2014

Without this fix "jake debug local" fails, because the flag is stored under the wrong name in the options object.

Also: do you need a signed copy of the contribution license agreement for a simple typo? As I understand it, this type of change can't be copyrighted, anyway -- or can it? (I thought I read somewhere that you won't need it, but I can't find where I might have read that.)

@mhegazy
Copy link
Contributor

mhegazy commented Aug 11, 2014

Thanks for submitting this change, but before we can accept the PR, we will need you to complete and submit the Contributor License Agreement (CLA). Download the agreement (Microsoft Contribution License Agreement.docx), sign, scan, and email it back to [email protected].

For more details see https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md

@hn3000
Copy link
Contributor Author

hn3000 commented Aug 12, 2014

I submitted the CLA as requested.

mhegazy added a commit that referenced this pull request Aug 12, 2014
fix typo: sourcemap -> sourceMap
@mhegazy mhegazy merged commit 6070dcc into microsoft:master Aug 12, 2014
@mhegazy
Copy link
Contributor

mhegazy commented Aug 12, 2014

thanks!

@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants