Add a basic dev container #42041
Add a basic dev container #42041
Conversation
Adds a basic dev container. This basic development environment has tools like gulp installed
typescript-bot
added
the
For Uncommitted Bug
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
CONTRIBUTING.md
Outdated
| This repository includes a [development container](https://code.visualstudio.com/docs/remote/containers) that you can use to quickly create an isolated development environment with all the tools you need to start working on TypeScript. To get started with a dev container and VS Code, either: | ||
|
|
||
| - Clone the TypeScript repository locally and use the `Open Folder in Container` command. | ||
| - Use the `Clone Repository in Container Volume` command to clone the TypeScript repository into a new container. |
There was a problem hiding this comment.
Should this one go first? Sounds like it's probably more ideal for most users, but I don't know much about containers.
There was a problem hiding this comment.
Sounds good to me. Dev containers definitely make things easy once you have VS Code and docker setup, and with Codespaces you can just connect and the container will automatically be setup for you
.devcontainer/devcontainer.json
Outdated
| "dbaeumer.vscode-eslint" | ||
| ], | ||
| "remoteUser": "node" | ||
| } |
There was a problem hiding this comment.
Just for the sake of consistency, we do use spaces over tabs in the repo. Could you swap these over to spaces?
|
Looking at the dockerfile, I think I'd like us to use Volta instead of nvm in the future, but it's not a blocker. |
Adds a basic dev container. This basic development environment has tools like gulp installed and should make it easier to get started contributing to TS. The dev container also will be picked for codespaces
Fixes #42042