preserve this when extracting functions #41992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
requested changes
Jan 12, 2021
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Quick suggestion about naming enum member
jakebailey
reviewed
Mar 4, 2022
Member
|
Do you want to keep working on this? Otherwise I'd like to close it to reduce the number of open PRs. |
Contributor
Author
|
Yes, I will keep working on this. |
Zzzen
force-pushed
the
extract-symbol-this
branch
from
0b0a5bf to
5502a24
Compare
jakebailey
approved these changes
Apr 4, 2022
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
This seems fine to me, no pun intended.
sandersn
approved these changes
Apr 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39931
Previously,
thisis assumed to be a reference to class. Now we can detect whetherthisis referring to a class or function. in the latter case, we need to passthisto the new function.