Fix missing file name of extended source file in synchronizeProjectList when it is missing on disk #41222
Conversation
…st when it is missing on disk Fixes #40136
typescript-bot
added
Author: Team
For Milestone Bug
| { fileName: libFile.path, isSourceOfProjectReferenceRedirect: false }, | ||
| { fileName: file.path, isSourceOfProjectReferenceRedirect: false }, | ||
| { fileName: config.path, isSourceOfProjectReferenceRedirect: false }, | ||
| { fileName: `${tscWatch.projectRoot}/tsconfig_base.json`, isSourceOfProjectReferenceRedirect: false }, |
There was a problem hiding this comment.
Why include it instead of removing it from the response? Are there other cases where TSServer could tell us to expect a file that doesn't actually exist?
There was a problem hiding this comment.
That is, where we're not expected to then create it? Of course, move to file probably gives a non-existent file path but expects us to go create it - I'm not sure about that though.
There was a problem hiding this comment.
I am not sure. but i am certain that extendedSourceFiles should contain source file name that wasnt present. It would need another file exists check or another field just to return information if file is present or not and that seems unnecessary just to let project structure information. Let me know if you think its necessary. If it is we would probably need another field on tsconfig source files
There was a problem hiding this comment.
Ping @uniqueiniquity
There was a problem hiding this comment.
Sorry for the delay.
After further thought, it's probably fine.
If you send VS a file here that doesn't exist, the user will see a somewhat strange diagnostic in the error list complaining that the file doesn't exist, but it won't break or crash.
If we ask for semantic diagnostics for the tsconfig that does exist, will we get one complaining about the missing referenced file?
Fixes #40136