fix(37578): Deprecate variable name AllowQualifedNameInPlaceOfIdentifier #38726
Conversation
…lifiedNameInPlaceOfIdentifier
There was a problem hiding this comment.
In #37578 I asked to deprecate misspelled variable instead of removing it, as it may break backward-compatibility (in linters, etc.)
It was previously done here, for example:
TypeScript/src/compiler/types.ts
Lines 3380 to 3381 in a1c8608
| @@ -3691,7 +3691,7 @@ namespace ts { | |||
|
|
|||
| // Error handling | |||
| AllowThisInObjectLiteral = 1 << 15, | |||
| AllowQualifedNameInPlaceOfIdentifier = 1 << 16, | |||
| AllowQualifiedNameInPlaceOfIdentifier = 1 << 16, | |||
There was a problem hiding this comment.
In #37578 I asked to deprecate misspelled variable instead of removing it, as it may break backward-compatibility (in linters, etc.)
It was previously done here, for example:
TypeScript/src/compiler/types.ts
Lines 3380 to 3381 in a1c8608
What do you think about it?
There was a problem hiding this comment.
Oh yeah, that sounds much better than deleting it. I just updated my code to deprecate it instead.
cljazouli
changed the title
| @@ -5366,6 +5366,7 @@ namespace ts { | |||
|
|
|||
| if (expectsIdentifier && chain.length !== 1 | |||
| && !context.encounteredError | |||
| && !(context.flags & NodeBuilderFlags.AllowQualifiedNameInPlaceOfIdentifier) | |||
| && !(context.flags & NodeBuilderFlags.AllowQualifedNameInPlaceOfIdentifier)) { | |||
There was a problem hiding this comment.
the new value is the same as the old, so you should replace the old usage instead of adding to it.
src/compiler/types.ts
Outdated
| @@ -3702,7 +3704,7 @@ namespace ts { | |||
| AllowNodeModulesRelativePaths = 1 << 26, | |||
| /* @internal */ DoNotIncludeSymbolChain = 1 << 27, // Skip looking up and printing an accessible symbol chain | |||
|
|
|||
| IgnoreErrors = AllowThisInObjectLiteral | AllowQualifedNameInPlaceOfIdentifier | AllowAnonymousIdentifier | AllowEmptyUnionOrIntersection | AllowEmptyTuple | AllowEmptyIndexInfoType | AllowNodeModulesRelativePaths, | |||
| IgnoreErrors = AllowThisInObjectLiteral | AllowQualifedNameInPlaceOfIdentifier | AllowQualifiedNameInPlaceOfIdentifier | AllowAnonymousIdentifier | AllowEmptyUnionOrIntersection | AllowEmptyTuple | AllowEmptyIndexInfoType | AllowNodeModulesRelativePaths, | |||
src/compiler/types.ts
Outdated
| @@ -3691,6 +3691,8 @@ namespace ts { | |||
|
|
|||
| // Error handling | |||
| AllowThisInObjectLiteral = 1 << 15, | |||
| AllowQualifiedNameInPlaceOfIdentifier = 1 << 16, | |||
| /** @deprecated AllowQualifedNameInPlaceOfIdentifier. Use AllowQualifiedNameInPlaceOfIdentifier instead. */ | |||
| AllowQualifedNameInPlaceOfIdentifier = 1 << 16, | |||
There was a problem hiding this comment.
please replace 1 << 16 with AllowQualifiedNameInPlaceOfIdentifier
|
@sandersn Thanks! I will make those changes |
typescript-bot
added
the
For Uncommitted Bug
Description:
Change variable name AllowQualifedNameInPlaceOfIdentifier to AllowQualifiedNameInPlaceOfIdentifier
Bug introduced in: #14709
Expected behavior:
AllowQualifedNameInPlaceOfIdentifier should be deprecated in favor of AllowQualifiedNameInPlaceOfIdentifier
Actual behavior:
AllowQualifedNameInPlaceOfIdentifier is not deprecated
Fixes #37578