Skip to content

fix(37287): False positive for TS2448 "use before declaration" in 3.8.3 --target esnext #37323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2020
Merged

fix(37287): False positive for TS2448 "use before declaration" in 3.8.3 --target esnext #37323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1402,7 +1402,7 @@ namespace ts {
return true;
}
if (isUsedInFunctionOrInstanceProperty(usage, declaration, container)) {
if (compilerOptions.target === ScriptTarget.ESNext && !!compilerOptions.useDefineForClassFields) {
if (compilerOptions.target === ScriptTarget.ESNext && !!compilerOptions.useDefineForClassFields && getContainingClass(declaration)) {
return (isPropertyDeclaration(declaration) || isParameterPropertyDeclaration(declaration, declaration.parent)) &&
!isPropertyImmediatelyReferencedWithinDeclaration(declaration, usage, /*stopAtAnyPropertyDeclaration*/ true);
}
Expand Down
9 changes: 9 additions & 0 deletions tests/baselines/reference/defineVariables_useDefineForClassFields.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
//// [defineVariables_useDefineForClassFields.ts]
const a = () => b()
const b = () => null
a()

//// [defineVariables_useDefineForClassFields.js]
const a = () => b();
const b = () => null;
a();
11 changes: 11 additions & 0 deletions tests/baselines/reference/defineVariables_useDefineForClassFields.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
=== tests/cases/compiler/defineVariables_useDefineForClassFields.ts ===
const a = () => b()
>a : Symbol(a, Decl(defineVariables_useDefineForClassFields.ts, 0, 5))
>b : Symbol(b, Decl(defineVariables_useDefineForClassFields.ts, 1, 5))

const b = () => null
>b : Symbol(b, Decl(defineVariables_useDefineForClassFields.ts, 1, 5))

a()
>a : Symbol(a, Decl(defineVariables_useDefineForClassFields.ts, 0, 5))

16 changes: 16 additions & 0 deletions tests/baselines/reference/defineVariables_useDefineForClassFields.types
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
=== tests/cases/compiler/defineVariables_useDefineForClassFields.ts ===
const a = () => b()
>a : () => any
>() => b() : () => any
>b() : any
>b : () => any

const b = () => null
>b : () => any
>() => null : () => any
>null : null

a()
>a() : any
>a : () => any
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that this is the result type; I guess because --strictNullChecks is off by default in tests?

Might be better to change from () => null to () => 0 just to make sure the types propagate properly (or enable --strict)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think types matter that much for this test since it's just trying to show the absence of an error.


6 changes: 6 additions & 0 deletions tests/cases/compiler/defineVariables_useDefineForClassFields.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// @target: ESNext
// @useDefineForClassFields: true

const a = () => b()
const b = () => null
a()