Skip to content

Use fs.existsSync to check for cancellation #36190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2020
Merged

Use fs.existsSync to check for cancellation #36190

merged 1 commit into from
Jan 15, 2020

Conversation

amcasey
Copy link
Member

@amcasey amcasey commented Jan 15, 2020

Unlike statSync, it doesn't throw if the file doesn't exist, saving both time and allocations.

@amcasey
Use fs.existsSync to check for cancellation
dfc5570 
Unlike statSync, it doesn't throw if the file doesn't exist, saving both
time and allocations.
@amcasey amcasey requested a review from sheetalkamat January 15, 2020 00:09
sheetalkamat
sheetalkamat reviewed Jan 15, 2020
View reviewed changes
@amcasey amcasey merged commit a9cbea4 into microsoft:master Jan 15, 2020
Kingwl pushed a commit to Kingwl/TypeScript that referenced this pull request Mar 4, 2020
@amcasey @Kingwl
Use fs.existsSync to check for cancellation (microsoft#36190)
1eae316 
Unlike statSync, it doesn't throw if the file doesn't exist, saving both
time and allocations.
@gluxon gluxon mentioned this pull request Aug 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheetalkamat sheetalkamat sheetalkamat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amcasey @sheetalkamat