Ignore @private/@protected on constructor functions #35782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was incorrect in the best of circumstances and caused a crash when the parent of the function had no symbol, because the accessibility check assumed it was operating on a constructor and that the parent was always the containing class.
Member
Author
|
This showed up in lodash because lodash uses |
andrewbranch
approved these changes
Dec 19, 2019
sandersn
commented
Dec 19, 2019
src/compiler/checker.ts
Outdated
| // Public constructor is accessible. | ||
| if (!modifiers) { | ||
| // (1) Public constructors and (2) constructor functions are always accessible. | ||
| if (!modifiers || isFunctionLikeDeclaration(declaration)) { |
Member
Author
There was a problem hiding this comment.
oops, isFunctionLikeDeclaration includes constructors. I think I'll flip the check and exclude SyntaxKind.Constructor explicitly.
Previously, all function-like kinds were accessible, which includes constructors. This was wrong.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was incorrect in the best of circumstances and caused a crash when the parent of the function had no symbol, because the accessibility check assumed it was operating on a constructor and that the parent was always the containing class.
Fixes #35766