Skip to content

Fix isInJsxText after JSXOpeningElement with type arguments #34958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 6, 2019
Merged

Fix isInJsxText after JSXOpeningElement with type arguments #34958

merged 2 commits into from
Nov 6, 2019

Conversation

andrewbranch
Copy link
Member

Fixes #34110

amcasey
amcasey approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've convinced myself it's correct, but I have some thoughts on readability.

@andrewbranch andrewbranch merged commit f2146a6 into microsoft:master Nov 6, 2019
@andrewbranch andrewbranch deleted the bug/34110 branch November 6, 2019 23:02
@varemenos varemenos mentioned this pull request Feb 19, 2023
Closed
@andrewbranch andrewbranch mentioned this pull request Feb 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheetalkamat sheetalkamat Awaiting requested review from sheetalkamat

1 more reviewer

@amcasey amcasey amcasey approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generic react component (TSX) and intellisense not working
2 participants
@andrewbranch @amcasey