Skip to content

Move class property transform #31847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Move class property transform #31847

wants to merge 2 commits into from

Conversation

rbuckton
Copy link
Contributor

This PR is an updated version of #30467, which moves the class property transform to a separate transformation phase.

Fixes #31792
Supersedes #30467

@rbuckton rbuckton requested a review from weswigham June 10, 2019 18:14
@rbuckton
Copy link
Contributor Author

cc: @joeywatts

@rbuckton
Copy link
Contributor Author

@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 10, 2019 •
edited
Loading

Heya @rbuckton, I've started to run the extended test suite on this PR at c1197c5. You can monitor the build here. It should now contribute to this PR's status checks.

@rbuckton rbuckton requested review from ahejlsberg and sandersn June 10, 2019 18:17
@rbuckton
Copy link
Contributor Author

I found a few more issues to investigate.

@rbuckton rbuckton closed this Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham Awaiting requested review from weswigham

@ahejlsberg ahejlsberg Awaiting requested review from ahejlsberg

@sandersn sandersn Awaiting requested review from sandersn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emitting type parameters (regression)
2 participants
@rbuckton @typescript-bot