Skip to content

Conversation

@rpgeeganage
Copy link
Contributor

@rpgeeganage rpgeeganage commented May 5, 2019

This PR is an attempt to solve: #31180
(Quick info on 'new' keyword should be the same as that of resolved expression)

Fixes #31180

@rpgeeganage rpgeeganage changed the title New keyword consistent resolve Quick info on 'new' keyword should be the same as that of resolved expression May 5, 2019
@rpgeeganage
Copy link
Contributor Author

@DanielRosenwasser ,
I fixed the changes. Yes, the baseline files were not changed.
Sorry for the wrong approach.

I have changed the test case too. I have removed the marker 3.
////n/*1*/ew C/*2*/at(/*3*/);
because it doesn't have the same quick info and documentation marker 1 and marker 2.
is it ok?

@DanielRosenwasser DanielRosenwasser merged commit d484163 into microsoft:master May 15, 2019
@DanielRosenwasser
Copy link
Member

Thanks for the PR and the patience! 🙏🏻

@rpgeeganage
Copy link
Contributor Author

I'm honored to contribute to this wonderful repo.

@rpgeeganage rpgeeganage deleted the new_keyword_consistent_resolve branch May 15, 2019 08:30
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quick info on 'new' keyword should be the same as that of resolved expression

2 participants