Skip to content

🤖 User test baselines have changed #30832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2019
Merged

🤖 User test baselines have changed #30832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 20 additions & 15 deletions tests/baselines/reference/user/chrome-devtools-frontend.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
Exit Code: 1
Standard output:
../../../../built/local/lib.dom.d.ts(2439,11): error TS2300: Duplicate identifier 'CSSRule'.
../../../../built/local/lib.dom.d.ts(2458,13): error TS2300: Duplicate identifier 'CSSRule'.
../../../../built/local/lib.dom.d.ts(3339,11): error TS2300: Duplicate identifier 'Comment'.
../../../../built/local/lib.dom.d.ts(3342,13): error TS2300: Duplicate identifier 'Comment'.
../../../../built/local/lib.dom.d.ts(5032,11): error TS2300: Duplicate identifier 'Event'.
../../../../built/local/lib.dom.d.ts(5092,13): error TS2300: Duplicate identifier 'Event'.
../../../../built/local/lib.dom.d.ts(11453,11): error TS2300: Duplicate identifier 'Position'.
../../../../built/local/lib.dom.d.ts(12214,11): error TS2300: Duplicate identifier 'Request'.
../../../../built/local/lib.dom.d.ts(12294,13): error TS2300: Duplicate identifier 'Request'.
../../../../built/local/lib.dom.d.ts(16941,11): error TS2300: Duplicate identifier 'Window'.
../../../../built/local/lib.dom.d.ts(17073,13): error TS2300: Duplicate identifier 'Window'.
../../../../built/local/lib.dom.d.ts(2466,11): error TS2300: Duplicate identifier 'CSSRule'.
../../../../built/local/lib.dom.d.ts(2485,13): error TS2300: Duplicate identifier 'CSSRule'.
../../../../built/local/lib.dom.d.ts(3370,11): error TS2300: Duplicate identifier 'Comment'.
../../../../built/local/lib.dom.d.ts(3373,13): error TS2300: Duplicate identifier 'Comment'.
../../../../built/local/lib.dom.d.ts(5054,11): error TS2300: Duplicate identifier 'Event'.
../../../../built/local/lib.dom.d.ts(5114,13): error TS2300: Duplicate identifier 'Event'.
../../../../built/local/lib.dom.d.ts(11501,11): error TS2300: Duplicate identifier 'Position'.
../../../../built/local/lib.dom.d.ts(12257,11): error TS2300: Duplicate identifier 'Request'.
../../../../built/local/lib.dom.d.ts(12337,13): error TS2300: Duplicate identifier 'Request'.
../../../../built/local/lib.dom.d.ts(17014,11): error TS2300: Duplicate identifier 'Window'.
../../../../built/local/lib.dom.d.ts(17149,13): error TS2300: Duplicate identifier 'Window'.
../../../../built/local/lib.es5.d.ts(1416,11): error TS2300: Duplicate identifier 'ArrayLike'.
../../../../built/local/lib.es5.d.ts(1452,6): error TS2300: Duplicate identifier 'Record'.
../../../../node_modules/@types/node/index.d.ts(150,13): error TS2403: Subsequent variable declarations must have the same type. Variable 'module' must be of type '{}', but here has type 'NodeModule'.
Expand All @@ -34,6 +34,8 @@ node_modules/chrome-devtools-frontend/front_end/Runtime.js(693,7): error TS2322:
node_modules/chrome-devtools-frontend/front_end/Runtime.js(705,5): error TS2322: Type 'Promise<boolean>' is not assignable to type 'Promise<undefined>'.
node_modules/chrome-devtools-frontend/front_end/Runtime.js(715,7): error TS2322: Type 'Promise<void>' is not assignable to type 'Promise<undefined>'.
node_modules/chrome-devtools-frontend/front_end/Runtime.js(729,7): error TS2322: Type 'Promise<void>' is not assignable to type 'Promise<undefined>'.
node_modules/chrome-devtools-frontend/front_end/Runtime.js(746,5): error TS2322: Type 'Window | {}' is not assignable to type 'Window'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar problem to puppeteer, except that the assignment almost works.

Type '{}' is missing the following properties from type 'Window': Blob, TextDecoder, TextEncoder, URL, and 233 more.
node_modules/chrome-devtools-frontend/front_end/Runtime.js(854,36): error TS2339: Property 'eval' does not exist on type 'Window'.
node_modules/chrome-devtools-frontend/front_end/Runtime.js(1083,15): error TS2355: A function whose declared type is neither 'void' nor 'any' must return a value.
node_modules/chrome-devtools-frontend/front_end/Runtime.js(1088,15): error TS2355: A function whose declared type is neither 'void' nor 'any' must return a value.
Expand Down Expand Up @@ -3354,7 +3356,8 @@ node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(26,46): error T
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(44,23): error TS2322: Type 'number' is not assignable to type 'RegExpMatchArray'.
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(45,23): error TS2365: Operator '>=' cannot be applied to types 'RegExpMatchArray' and 'number'.
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(47,76): error TS2365: Operator '<' cannot be applied to types 'RegExpMatchArray' and 'number'.
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(94,25): error TS2339: Property 'createTextRange' does not exist on type 'HTMLElement'.
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(94,25): error TS2339: Property 'createTextRange' does not exist on type 'HTMLBodyElement | HTMLFrameSetElement'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better type from DOM

Property 'createTextRange' does not exist on type 'HTMLBodyElement'.
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(683,31): error TS2339: Property 'length' does not exist on type 'never'.
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(684,33): error TS2339: Property 'find' does not exist on type 'never'.
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(689,28): error TS2339: Property 'inclusiveLeft' does not exist on type 'never'.
Expand Down Expand Up @@ -5144,7 +5147,7 @@ node_modules/chrome-devtools-frontend/front_end/dom_extension/DOMExtension.js(74
node_modules/chrome-devtools-frontend/front_end/dom_extension/DOMExtension.js(745,48): error TS2339: Property 'pageX' does not exist on type 'Event'.
node_modules/chrome-devtools-frontend/front_end/dom_extension/DOMExtension.js(745,60): error TS2339: Property 'pageY' does not exist on type 'Event'.
node_modules/chrome-devtools-frontend/front_end/dom_extension/DOMExtension.js(753,20): error TS2339: Property 'deepElementFromPoint' does not exist on type 'Document'.
node_modules/chrome-devtools-frontend/front_end/dom_extension/DOMExtension.js(761,5): error TS2740: Type 'ShadowRoot' is missing the following properties from type 'Document': URL, alinkColor, all, anchors, and 174 more.
node_modules/chrome-devtools-frontend/front_end/dom_extension/DOMExtension.js(761,5): error TS2740: Type 'ShadowRoot' is missing the following properties from type 'Document': URL, alinkColor, all, anchors, and 176 more.
node_modules/chrome-devtools-frontend/front_end/dom_extension/DOMExtension.js(766,28): error TS2339: Property 'deepElementFromPoint' does not exist on type 'DocumentFragment'.
node_modules/chrome-devtools-frontend/front_end/dom_extension/DOMExtension.js(766,70): error TS2339: Property 'deepElementFromPoint' does not exist on type 'Document'.
node_modules/chrome-devtools-frontend/front_end/dom_extension/DOMExtension.js(771,20): error TS2339: Property 'deepActiveElement' does not exist on type 'Document'.
Expand Down Expand Up @@ -6133,7 +6136,8 @@ node_modules/chrome-devtools-frontend/front_end/extensions/ExtensionServer.js(12
node_modules/chrome-devtools-frontend/front_end/extensions/ExtensionServer.js(136,5): error TS2555: Expected at least 2 arguments, but got 1.
node_modules/chrome-devtools-frontend/front_end/extensions/ExtensionServer.js(161,5): error TS2555: Expected at least 2 arguments, but got 1.
node_modules/chrome-devtools-frontend/front_end/extensions/ExtensionServer.js(219,43): error TS2694: Namespace 'Protocol' has no exported member 'Network'.
node_modules/chrome-devtools-frontend/front_end/extensions/ExtensionServer.js(244,54): error TS2339: Property 'traverseNextNode' does not exist on type 'HTMLElement'.
node_modules/chrome-devtools-frontend/front_end/extensions/ExtensionServer.js(244,54): error TS2339: Property 'traverseNextNode' does not exist on type 'HTMLBodyElement | HTMLFrameSetElement'.
Property 'traverseNextNode' does not exist on type 'HTMLBodyElement'.
node_modules/chrome-devtools-frontend/front_end/extensions/ExtensionServer.js(463,53): error TS2345: Argument of type '{ url: string; type: string; }' is not assignable to parameter of type '{ contentURL(): string; contentType(): ResourceType; contentEncoded(): Promise<boolean>; requestContent(): Promise<string>; searchInContent(query: string, caseSensitive: boolean, isRegex: boolean): Promise<...>; }'.
Type '{ url: string; type: string; }' is missing the following properties from type '{ contentURL(): string; contentType(): ResourceType; contentEncoded(): Promise<boolean>; requestContent(): Promise<string>; searchInContent(query: string, caseSensitive: boolean, isRegex: boolean): Promise<...>; }': contentURL, contentType, contentEncoded, requestContent, searchInContent
node_modules/chrome-devtools-frontend/front_end/extensions/ExtensionServer.js(471,22): error TS2339: Property 'valuesArray' does not exist on type 'Map<string, { contentURL(): string; contentType(): ResourceType; contentEncoded(): Promise<boolean>; requestContent(): Promise<string>; searchInContent(query: string, caseSensitive: boolean, isRegex: boolean): Promise<...>; }>'.
Expand Down Expand Up @@ -13251,7 +13255,8 @@ node_modules/chrome-devtools-frontend/front_end/ui/Toolbar.js(855,15): error TS7
node_modules/chrome-devtools-frontend/front_end/ui/Toolbar.js(861,40): error TS2339: Property 'createChild' does not exist on type 'Element'.
node_modules/chrome-devtools-frontend/front_end/ui/Toolbar.js(1053,38): error TS2339: Property 'checkboxElement' does not exist on type 'Element'.
node_modules/chrome-devtools-frontend/front_end/ui/Toolbar.js(1055,20): error TS2339: Property 'title' does not exist on type 'Element'.
node_modules/chrome-devtools-frontend/front_end/ui/Tooltip.js(12,29): error TS2339: Property 'createChild' does not exist on type 'HTMLElement'.
node_modules/chrome-devtools-frontend/front_end/ui/Tooltip.js(12,29): error TS2339: Property 'createChild' does not exist on type 'HTMLBodyElement | HTMLFrameSetElement'.
Property 'createChild' does not exist on type 'HTMLBodyElement'.
node_modules/chrome-devtools-frontend/front_end/ui/Tooltip.js(15,45): error TS2339: Property 'createChild' does not exist on type 'DocumentFragment'.
node_modules/chrome-devtools-frontend/front_end/ui/Tooltip.js(57,27): error TS2339: Property 'path' does not exist on type 'MouseEvent'.
node_modules/chrome-devtools-frontend/front_end/ui/Tooltip.js(85,31): error TS2339: Property 'isSelfOrDescendant' does not exist on type 'Element'.
Expand Down
2 changes: 2 additions & 0 deletions tests/baselines/reference/user/puppeteer.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ lib/Page.js(112,33): error TS2345: Argument of type 'CDPSession' is not assignab
lib/Page.js(189,15): error TS2503: Cannot find namespace 'Protocol'.
lib/Page.js(284,15): error TS2503: Cannot find namespace 'Protocol'.
lib/Page.js(369,20): error TS2503: Cannot find namespace 'Protocol'.
lib/Page.js(432,7): error TS2740: Type '(...args: any[]) => Promise<any>' is missing the following properties from type 'Window': Blob, TextDecoder, TextEncoder, URL, and 231 more.
lib/Page.js(442,9): error TS2349: Cannot invoke an expression whose type lacks a call signature. Type 'Window' has no compatible call signatures.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

numeric index signature means that window[x] : Window where x: any. And the arrow in question is not assignable to Window.

lib/Page.js(478,15): error TS2503: Cannot find namespace 'Protocol'.
lib/Page.js(488,22): error TS2503: Cannot find namespace 'Protocol'.
lib/Page.js(501,15): error TS2503: Cannot find namespace 'Protocol'.
Expand Down
8 changes: 8 additions & 0 deletions tests/baselines/reference/user/webpack.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
Exit Code: 1
Standard output:
../../../../../built/local/lib.dom.d.ts(17566,19): error TS2451: Cannot redeclare block-scoped variable 'WebAssembly'.
declarations.d.ts(258,15): error TS2451: Cannot redeclare block-scoped variable 'WebAssembly'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have wEbbasSeMBly now~~~

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by webpack/webpack#9022




Standard error: