Adjust offset to account for 'this' parameter when emitting parameter decorators #30495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| >C : C | ||
|
|
||
| method(@dec this: C) {} | ||
| >method : (: any, this: C) => void |
Member
There was a problem hiding this comment.
this type seems incorrectly printed?
Member
There was a problem hiding this comment.
Are decorators on this parameters even a thing? O.o
Contributor
Author
There was a problem hiding this comment.
That's because this is a parse error (i.e. @dec this fails because this isn't an identifier), so you end up with a missing identifier.
Contributor
Author
There was a problem hiding this comment.
No, decorators on this parameters were never valid, but we did not have a test that reflects this. I opted to add one while investigating this fix
weswigham
approved these changes
Mar 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29427