Skip to content

Fix _superIndex emit when super access captured in async arrow #30491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2019
Merged

Fix _superIndex emit when super access captured in async arrow #30491

merged 1 commit into from
Mar 19, 2019

Conversation

@rbuckton
Copy link
Contributor

@rbuckton rbuckton commented Mar 19, 2019

We were incorrectly resetting hasSuperElementAccess and capturedSuperProperties when transforming the body of an async arrow function.

NOTE: This is the same fix as #30479 except that this targets master

Fixes #30066

@rbuckton rbuckton requested a review from weswigham March 19, 2019 17:22
@rbuckton rbuckton mentioned this pull request Mar 19, 2019
Merged
@rbuckton rbuckton merged commit 4b3178c into master Mar 19, 2019
@rbuckton rbuckton deleted the fix30066-master branch March 19, 2019 18:26
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@weswigham weswigham weswigham approved these changes

@sandersn sandersn Awaiting requested review from sandersn

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wrong async scope resolution

3 participants

@rbuckton @weswigham