Skip to content

Fix instanceof and typeof control flow #29714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 4, 2019
Merged

Fix instanceof and typeof control flow #29714

merged 5 commits into from
Feb 4, 2019

Conversation

ahejlsberg
Copy link
Member

This PR reverts #28112 and instead puts in place a targeted fix for --strictPropertyInitialization checks in control flow paths that include this instanceof XXX checks.

Fixes #29513.

@ahejlsberg ahejlsberg merged commit b7c5c07 into master Feb 4, 2019
@ahejlsberg ahejlsberg deleted the fixInstanceofTypeofControlFlow branch February 4, 2019 20:22
@ahejlsberg ahejlsberg mentioned this pull request Feb 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strange narrowing behavior for types assigned to in while loop
2 participants
@ahejlsberg @RyanCavanaugh